You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@accumulo.apache.org by GitBox <gi...@apache.org> on 2022/08/23 11:30:01 UTC

[GitHub] [accumulo] dlmarion commented on a diff in pull request #2880: Replace use of Guava in ScanAttemptsImpl

dlmarion commented on code in PR #2880:
URL: https://github.com/apache/accumulo/pull/2880#discussion_r952489931


##########
core/src/main/java/org/apache/accumulo/core/clientImpl/ScanAttemptsImpl.java:
##########
@@ -111,16 +110,27 @@ public void report(ScanAttempt.Result result) {
   }
 
   Map<TabletId,Collection<ScanAttemptImpl>> snapshot() {

Review Comment:
   Suggest turning the comment you removed at line 114 into a method javadoc. Just so we now the top level goal of the method. This gives a little more context to the comments inside the method.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org