You are viewing a plain text version of this content. The canonical link for it is here.

Posted to jira@kafka.apache.org by "cmccabe (via GitHub)" <gi...@apache.org> on 2023/04/19 23:26:26 UTC

[GitHub] [kafka] cmccabe commented on pull request #13461: KAFKA-14840: Support for snapshots during ZK migration

cmccabe commented on PR #13461:
URL: https://github.com/apache/kafka/pull/13461#issuecomment-1515504502

   Thanks for this @mumrah .
   
   Can we have a ZkConfigMigrationClientTest and so on, for the other new migrationclient classes?
   
   Should we wrap the calls to `quotaEntityConsumer.accept` (and other consumers) so that if it throws an exception, we log an ERROR message to log4j to let us know what failed?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org