You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/06/12 02:08:24 UTC
[GitHub] [shardingsphere] menghaoranss opened a new pull request #6006: Update node state after slave database is disabled # control-panel-cluster
menghaoranss opened a new pull request #6006:
URL: https://github.com/apache/shardingsphere/pull/6006
Fixes #6005.
Changes proposed in this pull request:
- Update node state after slave database is disabled
- Display disabled node state in real time on UI
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] codecov-commenter commented on pull request #6006: Update node state after slave database is disabled # control-panel-cluster
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #6006:
URL: https://github.com/apache/shardingsphere/pull/6006#issuecomment-643030930
# [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/6006?src=pr&el=h1) Report
> Merging [#6006](https://codecov.io/gh/apache/shardingsphere/pull/6006?src=pr&el=desc) into [master](https://codecov.io/gh/apache/shardingsphere/commit/dff4c8a218e7765a18b9bc03f3cfc7e92db4b0a8&el=desc) will **decrease** coverage by `0.02%`.
> The diff coverage is `42.85%`.
[](https://codecov.io/gh/apache/shardingsphere/pull/6006?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6006 +/- ##
============================================
- Coverage 53.11% 53.09% -0.03%
+ Complexity 439 438 -1
============================================
Files 1190 1190
Lines 20895 20898 +3
Branches 3766 3766
============================================
- Hits 11099 11096 -3
- Misses 9103 9106 +3
- Partials 693 696 +3
```
| [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/6006?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...e/shardingsphere/cluster/facade/ClusterFacade.java](https://codecov.io/gh/apache/shardingsphere/pull/6006/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtY29udHJvbC1wYW5lbC9zaGFyZGluZ3NwaGVyZS1jbHVzdGVyL3NoYXJkaW5nc3BoZXJlLWNsdXN0ZXItZmFjYWRlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9jbHVzdGVyL2ZhY2FkZS9DbHVzdGVyRmFjYWRlLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...re/cluster/heartbeat/ClusterHeartbeatInstance.java](https://codecov.io/gh/apache/shardingsphere/pull/6006/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtY29udHJvbC1wYW5lbC9zaGFyZGluZ3NwaGVyZS1jbHVzdGVyL3NoYXJkaW5nc3BoZXJlLWNsdXN0ZXItaGVhcnRiZWF0L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9jbHVzdGVyL2hlYXJ0YmVhdC9DbHVzdGVySGVhcnRiZWF0SW5zdGFuY2UuamF2YQ==) | `41.66% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...hestration/core/registrycenter/RegistryCenter.java](https://codecov.io/gh/apache/shardingsphere/pull/6006/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtY29udHJvbC1wYW5lbC9zaGFyZGluZ3NwaGVyZS1vcmNoZXN0cmF0aW9uL3NoYXJkaW5nc3BoZXJlLW9yY2hlc3RyYXRpb24tY29yZS9zaGFyZGluZ3NwaGVyZS1vcmNoZXN0cmF0aW9uLWNvcmUtcmVnaXN0cnljZW50ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL29yY2hlc3RyYXRpb24vY29yZS9yZWdpc3RyeWNlbnRlci9SZWdpc3RyeUNlbnRlci5qYXZh) | `75.00% <0.00%> (-10.72%)` | `0.00 <0.00> (ø)` | |
| [...dingsphere/cluster/state/ClusterStateInstance.java](https://codecov.io/gh/apache/shardingsphere/pull/6006/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtY29udHJvbC1wYW5lbC9zaGFyZGluZ3NwaGVyZS1jbHVzdGVyL3NoYXJkaW5nc3BoZXJlLWNsdXN0ZXItc3RhdGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2NsdXN0ZXIvc3RhdGUvQ2x1c3RlclN0YXRlSW5zdGFuY2UuamF2YQ==) | `25.00% <33.33%> (+3.94%)` | `0.00 <0.00> (ø)` | |
| [...ster/heartbeat/detect/AbstractHeartbeatDetect.java](https://codecov.io/gh/apache/shardingsphere/pull/6006/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtY29udHJvbC1wYW5lbC9zaGFyZGluZ3NwaGVyZS1jbHVzdGVyL3NoYXJkaW5nc3BoZXJlLWNsdXN0ZXItaGVhcnRiZWF0L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9jbHVzdGVyL2hlYXJ0YmVhdC9kZXRlY3QvQWJzdHJhY3RIZWFydGJlYXREZXRlY3QuamF2YQ==) | `76.19% <50.00%> (-7.15%)` | `1.00 <1.00> (ø)` | |
| [...ere/cluster/heartbeat/detect/HeartbeatHandler.java](https://codecov.io/gh/apache/shardingsphere/pull/6006/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtY29udHJvbC1wYW5lbC9zaGFyZGluZ3NwaGVyZS1jbHVzdGVyL3NoYXJkaW5nc3BoZXJlLWNsdXN0ZXItaGVhcnRiZWF0L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9jbHVzdGVyL2hlYXJ0YmVhdC9kZXRlY3QvSGVhcnRiZWF0SGFuZGxlci5qYXZh) | `76.66% <50.00%> (-7.34%)` | `0.00 <0.00> (-1.00)` | |
| [...here/cluster/heartbeat/detect/HeartbeatDetect.java](https://codecov.io/gh/apache/shardingsphere/pull/6006/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtY29udHJvbC1wYW5lbC9zaGFyZGluZ3NwaGVyZS1jbHVzdGVyL3NoYXJkaW5nc3BoZXJlLWNsdXN0ZXItaGVhcnRiZWF0L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9jbHVzdGVyL2hlYXJ0YmVhdC9kZXRlY3QvSGVhcnRiZWF0RGV0ZWN0LmphdmE=) | `78.94% <66.66%> (-4.39%)` | `0.00 <0.00> (ø)` | |
| [.../core/registrycenter/RegistryCenterNodeStatus.java](https://codecov.io/gh/apache/shardingsphere/pull/6006/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtY29udHJvbC1wYW5lbC9zaGFyZGluZ3NwaGVyZS1vcmNoZXN0cmF0aW9uL3NoYXJkaW5nc3BoZXJlLW9yY2hlc3RyYXRpb24tY29yZS9zaGFyZGluZ3NwaGVyZS1vcmNoZXN0cmF0aW9uLWNvcmUtcmVnaXN0cnljZW50ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL29yY2hlc3RyYXRpb24vY29yZS9yZWdpc3RyeWNlbnRlci9SZWdpc3RyeUNlbnRlck5vZGVTdGF0dXMuamF2YQ==) | `100.00% <100.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...swapper/OrchestrationConfigurationYamlSwapper.java](https://codecov.io/gh/apache/shardingsphere/pull/6006/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtY29udHJvbC1wYW5lbC9zaGFyZGluZ3NwaGVyZS1vcmNoZXN0cmF0aW9uL3NoYXJkaW5nc3BoZXJlLW9yY2hlc3RyYXRpb24tY2VudGVyL3NoYXJkaW5nc3BoZXJlLW9yY2hlc3RyYXRpb24tY2VudGVyLWNvbmZpZ3VyYXRpb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL29yY2hlc3RyYXRpb24vY2VudGVyL3lhbWwvc3dhcHBlci9PcmNoZXN0cmF0aW9uQ29uZmlndXJhdGlvbllhbWxTd2FwcGVyLmphdmE=) | `100.00% <0.00%> (ø)` | `0.00% <0.00%> (ø%)` | |
| [...che/shardingsphere/sharding/rule/ShardingRule.java](https://codecov.io/gh/apache/shardingsphere/pull/6006/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtc2hhcmRpbmcvc2hhcmRpbmdzcGhlcmUtc2hhcmRpbmctY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9zaGFyZGluZy9ydWxlL1NoYXJkaW5nUnVsZS5qYXZh) | `79.06% <0.00%> (+5.60%)` | `0.00% <0.00%> (ø%)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/shardingsphere/pull/6006?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/6006?src=pr&el=footer). Last update [dff4c8a...7db93f7](https://codecov.io/gh/apache/shardingsphere/pull/6006?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] kimmking merged pull request #6006: Update node state after slave database is disabled # control-panel-cluster
Posted by GitBox <gi...@apache.org>.
kimmking merged pull request #6006:
URL: https://github.com/apache/shardingsphere/pull/6006
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org