You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@myfaces.apache.org by "Gary VanMatre (Created) (JIRA)" <de...@myfaces.apache.org> on 2011/10/21 15:12:32 UTC

[jira] [Created] (TRINIDAD-2152) token cache pinning session attribute map

 token cache pinning session attribute map
------------------------------------------

                 Key: TRINIDAD-2152
                 URL: https://issues.apache.org/jira/browse/TRINIDAD-2152
             Project: MyFaces Trinidad
          Issue Type: Bug
          Components: Components
    Affects Versions: 2.0.2-core
            Reporter: Gary VanMatre


Stevan Malesevic found that the token cache is pinning the session map. 

com.sun.faces.context.ExternalContextImpl will create a instance of com.sun.faces.context.SessionMap on every request. SessionMap points to 
Request object. However this is per request so it is not carried over between requests.  Now, the reason why we always have request object pined between requests is Trinidad code TokenCache which pins the owner (SessionMap) which would otherwise be gc-ed.  From what I can see 
Trinidad code can be changed to always get extContext.getSessionMap() instead pinning it permanently. This will make sure we are not pinning Request object and all its attributes in between requests. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (TRINIDAD-2152) token cache pinning session attribute map

Posted by "Gabrielle Crawford (Updated) (JIRA)" <de...@myfaces.apache.org>.
     [ https://issues.apache.org/jira/browse/TRINIDAD-2152?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Gabrielle Crawford updated TRINIDAD-2152:
-----------------------------------------

    Resolution: Fixed
      Assignee: Gabrielle Crawford
        Status: Resolved  (was: Patch Available)
    
>  token cache pinning session attribute map
> ------------------------------------------
>
>                 Key: TRINIDAD-2152
>                 URL: https://issues.apache.org/jira/browse/TRINIDAD-2152
>             Project: MyFaces Trinidad
>          Issue Type: Bug
>          Components: Components
>    Affects Versions: 2.0.2-core
>            Reporter: Gary VanMatre
>            Assignee: Gabrielle Crawford
>         Attachments: TokenCache-trunk.patch, TokenCache-trunk.patch
>
>
> Stevan Malesevic found that the token cache is pinning the session map. 
> com.sun.faces.context.ExternalContextImpl will create a instance of com.sun.faces.context.SessionMap on every request. SessionMap points to 
> Request object. However this is per request so it is not carried over between requests.  Now, the reason why we always have request object pined between requests is Trinidad code TokenCache which pins the owner (SessionMap) which would otherwise be gc-ed.  From what I can see 
> Trinidad code can be changed to always get extContext.getSessionMap() instead pinning it permanently. This will make sure we are not pinning Request object and all its attributes in between requests. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (TRINIDAD-2152) token cache pinning session attribute map

Posted by "Gary VanMatre (Updated) (JIRA)" <de...@myfaces.apache.org>.
     [ https://issues.apache.org/jira/browse/TRINIDAD-2152?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Gary VanMatre updated TRINIDAD-2152:
------------------------------------

    Status: Patch Available  (was: Open)
    
>  token cache pinning session attribute map
> ------------------------------------------
>
>                 Key: TRINIDAD-2152
>                 URL: https://issues.apache.org/jira/browse/TRINIDAD-2152
>             Project: MyFaces Trinidad
>          Issue Type: Bug
>          Components: Components
>    Affects Versions: 2.0.2-core
>            Reporter: Gary VanMatre
>
> Stevan Malesevic found that the token cache is pinning the session map. 
> com.sun.faces.context.ExternalContextImpl will create a instance of com.sun.faces.context.SessionMap on every request. SessionMap points to 
> Request object. However this is per request so it is not carried over between requests.  Now, the reason why we always have request object pined between requests is Trinidad code TokenCache which pins the owner (SessionMap) which would otherwise be gc-ed.  From what I can see 
> Trinidad code can be changed to always get extContext.getSessionMap() instead pinning it permanently. This will make sure we are not pinning Request object and all its attributes in between requests. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira