You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "tomvanbussel (via GitHub)" <gi...@apache.org> on 2023/03/01 15:28:17 UTC
[GitHub] [spark] tomvanbussel opened a new pull request, #40234: [SPARK-34827][CONNECT] Support custom extensions in Scala client
tomvanbussel opened a new pull request, #40234:
URL: https://github.com/apache/spark/pull/40234
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
8. If you want to add or modify an error type or message, please read the guideline first in
'core/src/main/resources/error/README.md'.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
If benchmark tests were added, please run the benchmarks in GitHub Actions for the consistent environment, and the instructions could accord to: https://spark.apache.org/developer-tools.html#github-workflow-benchmarks.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] hvanhovell commented on pull request #40234: [SPARK-42631][CONNECT] Support custom extensions in Scala client
Posted by "hvanhovell (via GitHub)" <gi...@apache.org>.
hvanhovell commented on PR #40234:
URL: https://github.com/apache/spark/pull/40234#issuecomment-1451100966
Alright, merging this one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] hvanhovell commented on a diff in pull request #40234: [SPARK-42631][CONNECT] Support custom extensions in Scala client
Posted by "hvanhovell (via GitHub)" <gi...@apache.org>.
hvanhovell commented on code in PR #40234:
URL: https://github.com/apache/spark/pull/40234#discussion_r1122149243
##########
connector/connect/client/jvm/src/main/scala/org/apache/spark/sql/Column.scala:
##########
@@ -1312,6 +1312,10 @@ private[sql] object Column {
new Column(builder.build())
}
+ def apply(extension: com.google.protobuf.Any): Column = {
+ apply { builder => builder.setExtension(extension) }
Review Comment:
does this pass style checks?
OCD: this also works: `apply(_.setExtension(extension))`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] hvanhovell commented on a diff in pull request #40234: [SPARK-42631][CONNECT] Support custom extensions in Scala client
Posted by "hvanhovell (via GitHub)" <gi...@apache.org>.
hvanhovell commented on code in PR #40234:
URL: https://github.com/apache/spark/pull/40234#discussion_r1122149643
##########
connector/connect/client/jvm/src/main/scala/org/apache/spark/sql/Dataset.scala:
##########
@@ -120,7 +120,7 @@ import org.apache.spark.util.Utils
*/
class Dataset[T] private[sql] (
val sparkSession: SparkSession,
- private[sql] val plan: proto.Plan,
+ val plan: proto.Plan,
Review Comment:
Can we mark this field as `@DeveloperApi`. Not sure if we can do that at the field level though.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] hvanhovell commented on a diff in pull request #40234: [SPARK-42631][CONNECT] Support custom extensions in Scala client
Posted by "hvanhovell (via GitHub)" <gi...@apache.org>.
hvanhovell commented on code in PR #40234:
URL: https://github.com/apache/spark/pull/40234#discussion_r1122155644
##########
connector/connect/client/jvm/src/test/scala/org/apache/spark/sql/PlanGenerationTestSuite.scala:
##########
@@ -152,11 +161,9 @@ class PlanGenerationTestSuite
}
private def readRelation(path: Path): proto.Relation = {
- val input = Files.newInputStream(path)
- try proto.Relation.parseFrom(input)
- finally {
- input.close()
- }
+ val builder = proto.Relation.newBuilder()
+ parser.merge(Files.readString(path), builder)
Review Comment:
Are you sure it is safe to read this as a string? The files we are reading are binary (so no valid UTF-8).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] hvanhovell commented on a diff in pull request #40234: [SPARK-42631][CONNECT] Support custom extensions in Scala client
Posted by "hvanhovell (via GitHub)" <gi...@apache.org>.
hvanhovell commented on code in PR #40234:
URL: https://github.com/apache/spark/pull/40234#discussion_r1122149643
##########
connector/connect/client/jvm/src/main/scala/org/apache/spark/sql/Dataset.scala:
##########
@@ -120,7 +120,7 @@ import org.apache.spark.util.Utils
*/
class Dataset[T] private[sql] (
val sparkSession: SparkSession,
- private[sql] val plan: proto.Plan,
+ val plan: proto.Plan,
Review Comment:
Can we mark this field as DeveloperApi. Not sure if we can do that at the field level though.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] tomvanbussel commented on a diff in pull request #40234: [SPARK-42631][CONNECT] Support custom extensions in Scala client
Posted by "tomvanbussel (via GitHub)" <gi...@apache.org>.
tomvanbussel commented on code in PR #40234:
URL: https://github.com/apache/spark/pull/40234#discussion_r1122194474
##########
connector/connect/client/jvm/src/main/scala/org/apache/spark/sql/Dataset.scala:
##########
@@ -120,7 +120,7 @@ import org.apache.spark.util.Utils
*/
class Dataset[T] private[sql] (
val sparkSession: SparkSession,
- private[sql] val plan: proto.Plan,
+ val plan: proto.Plan,
Review Comment:
It's possible. It's also done for the non-Connect `Dataset`: https://github.com/apache/spark/blob/master/sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala#L191
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] tomvanbussel commented on pull request #40234: [SPARK-42631][CONNECT] Support custom extensions in Scala client
Posted by "tomvanbussel (via GitHub)" <gi...@apache.org>.
tomvanbussel commented on PR #40234:
URL: https://github.com/apache/spark/pull/40234#issuecomment-1450620126
@dongjoon-hyun It is! Not sure how that happened... Should be fixed now!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] hvanhovell commented on a diff in pull request #40234: [SPARK-42631][CONNECT] Support custom extensions in Scala client
Posted by "hvanhovell (via GitHub)" <gi...@apache.org>.
hvanhovell commented on code in PR #40234:
URL: https://github.com/apache/spark/pull/40234#discussion_r1122151812
##########
connector/connect/client/jvm/src/main/scala/org/apache/spark/sql/SparkSession.scala:
##########
@@ -261,6 +261,14 @@ class SparkSession private[sql] (
new Dataset[T](this, plan, encoder)
}
+ def newDataFrame(extension: com.google.protobuf.Any): DataFrame = {
Review Comment:
Same for all the other methods you have added here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #40234: [SPARK-42631][CONNECT] Support custom extensions in Scala client
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on PR #40234:
URL: https://github.com/apache/spark/pull/40234#issuecomment-1451098428
Sure! Thank you for checking again, @hvanhovell .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] hvanhovell commented on pull request #40234: [SPARK-42631][CONNECT] Support custom extensions in Scala client
Posted by "hvanhovell (via GitHub)" <gi...@apache.org>.
hvanhovell commented on PR #40234:
URL: https://github.com/apache/spark/pull/40234#issuecomment-1451097485
@dongjoon-hyun are you ok with this PR now?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] hvanhovell commented on a diff in pull request #40234: [SPARK-42631][CONNECT] Support custom extensions in Scala client
Posted by "hvanhovell (via GitHub)" <gi...@apache.org>.
hvanhovell commented on code in PR #40234:
URL: https://github.com/apache/spark/pull/40234#discussion_r1122151369
##########
connector/connect/client/jvm/src/main/scala/org/apache/spark/sql/SparkSession.scala:
##########
@@ -261,6 +261,14 @@ class SparkSession private[sql] (
new Dataset[T](this, plan, encoder)
}
+ def newDataFrame(extension: com.google.protobuf.Any): DataFrame = {
Review Comment:
Please mark as `@DeveloperApi`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] tomvanbussel commented on a diff in pull request #40234: [SPARK-42631][CONNECT] Support custom extensions in Scala client
Posted by "tomvanbussel (via GitHub)" <gi...@apache.org>.
tomvanbussel commented on code in PR #40234:
URL: https://github.com/apache/spark/pull/40234#discussion_r1122180297
##########
connector/connect/client/jvm/src/test/scala/org/apache/spark/sql/PlanGenerationTestSuite.scala:
##########
@@ -152,11 +161,9 @@ class PlanGenerationTestSuite
}
private def readRelation(path: Path): proto.Relation = {
- val input = Files.newInputStream(path)
- try proto.Relation.parseFrom(input)
- finally {
- input.close()
- }
+ val builder = proto.Relation.newBuilder()
+ parser.merge(Files.readString(path), builder)
Review Comment:
Oops, meant to revert this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] hvanhovell closed pull request #40234: [SPARK-42631][CONNECT] Support custom extensions in Scala client
Posted by "hvanhovell (via GitHub)" <gi...@apache.org>.
hvanhovell closed pull request #40234: [SPARK-42631][CONNECT] Support custom extensions in Scala client
URL: https://github.com/apache/spark/pull/40234
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org