You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@beam.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2017/04/26 06:31:04 UTC
[jira] [Commented] (BEAM-2072) MicrobatchSource.reader stops
reading after reaching maxNumRecords for the first time
[ https://issues.apache.org/jira/browse/BEAM-2072?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15984241#comment-15984241 ]
ASF GitHub Bot commented on BEAM-2072:
--------------------------------------
GitHub user staslev opened a pull request:
https://github.com/apache/beam/pull/2698
[BEAM-2072] Fixed MicrobatchSource.reader stops reading unexpectedly.
Be sure to do all of the following to help us incorporate your contribution
quickly and easily:
- [ ] Make sure the PR title is formatted like:
`[BEAM-<Jira issue #>] Description of pull request`
- [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable
Travis-CI on your fork and ensure the whole test matrix passes).
- [ ] Replace `<Jira issue #>` in the title with the actual Jira issue
number, if there is one.
- [ ] If this contribution is large, please file an Apache
[Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
---
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/staslev/beam BEAM-2072-MicrobatchSource-reader-stops-reading
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/beam/pull/2698.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2698
----
commit 5726e38b86cb3b7ef343463b3b9697bc583dcd80
Author: Stas Levin <st...@apache.org>
Date: 2017-04-26T06:28:08Z
[BEAM-2072] Fixed MicrobatchSource.reader stops reading after reaching maxNumRecords for the first time.
----
> MicrobatchSource.reader stops reading after reaching maxNumRecords for the first time
> -------------------------------------------------------------------------------------
>
> Key: BEAM-2072
> URL: https://issues.apache.org/jira/browse/BEAM-2072
> Project: Beam
> Issue Type: Bug
> Components: runner-spark
> Affects Versions: Not applicable
> Reporter: Stas Levin
> Assignee: Stas Levin
>
> {{MicrobatchSource.Reader}} stops reading further data after the first batch in which it has reached {{maxNumRecords}}. Subsequent read request will check the {{recordsRead}} and conclude that no data can be read.
> The root cause being that {{recordsRead}} is maintained throughout the reader's lifecycle, and can span multiple (spark) batches.
> We should reset {{recordsRead}} every time the reader starts reading a fresh batch.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)