You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/11/14 12:55:57 UTC

[GitHub] [arrow] rok commented on a diff in pull request #14632: MINOR: [Docs][C++] Improve docs for ConcatenateTables

rok commented on code in PR #14632:
URL: https://github.com/apache/arrow/pull/14632#discussion_r1021491833


##########
cpp/src/arrow/table.h:
##########
@@ -286,7 +286,18 @@ struct ARROW_EXPORT ConcatenateTablesOptions {
   static ConcatenateTablesOptions Defaults() { return {}; }
 };
 
-/// \brief Construct table from multiple input tables.
+/// \brief Construct a new table from multiple input tables. Underlying column arrays
+/// are concatenated without copying except in case of schema missmatch in which case
+/// columns will be cast to promoted types which will cause a copy. Tables will be
+/// concatenated in order they are provided in and order of rows within tables will be
+/// preserved.
+///
+/// \param[in] tables a std::vector of Tables to be concatenated
+/// \param[in] options specify how to unify schema of input tables
+/// \param[in] memory_pool MemoryPool to be used if null-filled arrays need to
+/// be created.
+/// \return Status

Review Comment:
   ```suggestion
   /// \return new Table
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org