You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by twalthr <gi...@git.apache.org> on 2018/04/18 10:52:12 UTC

[GitHub] flink issue #5867: [FLINK-8686] [sql-client] Improve basic embedded SQL clie...

Github user twalthr commented on the issue:

    https://github.com/apache/flink/pull/5867
  
    @fhueske @walterddr @suez1224 I added the possibility to make the JVM heap size configurable. After a short offline discussion with @StephanEwen, I'm not sure if we should add such configuration to the flink-conf.yaml or in a separate configuration file. I don't know which configuration we will need in the future outside of the SQL Client environment files. I don't know if it is worth to have a separate file just for JVM options. Or we hard code it into the sql-client.sh script that can be modified by a variable. What do you think?


---