[jira] [Commented] (KAFKA-5607) Improve error handling in SocketServer to reduce illegal states later

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/KAFKA-5607?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16092914#comment-16092914 ] 

ASF GitHub Bot commented on KAFKA-5607:
---------------------------------------

GitHub user rajinisivaram opened a pull request:

    https://github.com/apache/kafka/pull/3548

    KAFKA-5607: Improve error handling in SocketServer to avoid issues later

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/rajinisivaram/kafka KAFKA-5607

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/kafka/pull/3548.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #3548
    
----
commit 9d656f066dbdb86c78e150593c94cc118c843038
Author: Rajini Sivaram <ra...@googlemail.com>
Date:   2017-07-19T09:42:43Z

    KAFKA-5607: Improve error handling in SocketServer to avoid issues later

----


> Improve error handling in SocketServer to reduce illegal states later
> ---------------------------------------------------------------------
>
>                 Key: KAFKA-5607
>                 URL: https://issues.apache.org/jira/browse/KAFKA-5607
>             Project: Kafka
>          Issue Type: Bug
>          Components: core
>    Affects Versions: 0.11.0.0
>            Reporter: Rajini Sivaram
>            Assignee: Rajini Sivaram
>
> From [~junrao] in https://github.com/apache/kafka/pull/3526:
> {quote}
> In SocketServer, it may be better to catch unexpected exceptions within the loop of socket key iteration in places like processCompletedReceives(). That way, if we hit an unexpected exception, it only affects a single key. 
> {quote}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)