You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by jasongin <gi...@git.apache.org> on 2016/01/04 19:38:44 UTC
[GitHub] cordova-windows pull request: CB-10292: Windows platform support f...
GitHub user jasongin opened a pull request:
https://github.com/apache/cordova-windows/pull/133
CB-10292: Windows platform support for next version of VS/MSBuild
Reference the JIRA issue for more explanation.
The targets filter for 15.0 is currently the same as 14.0, but I copied to a separate function for clarity and in case it ever changes while 15.0 is being developed further.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jasongin/cordova-windows CB-10292
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-windows/pull/133.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #133
----
commit 70daf2a92849d5effd1d85d2f85fe3f1f85a3d3c
Author: Jason Ginchereau <ja...@microsoft.com>
Date: 2016-01-04T18:31:48Z
CB-10292: Windows platform support for next version of VS/MSBuild
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-windows pull request: CB-10292: Windows platform support f...
Posted by vladimir-kotikov <gi...@git.apache.org>.
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-windows/pull/133#discussion_r48823595
--- Diff: template/cordova/lib/MSBuildTools.js ---
@@ -50,11 +50,11 @@ MSBuildTools.prototype.buildProject = function(projFile, buildType, buildarch, o
// returns full path to msbuild tools required to build the project and tools version
module.exports.findAvailableVersion = function () {
--- End diff --
We would also need to update [`findAllAvailableVersions` method](https://github.com/apache/cordova-windows/pull/133/files#diff-cb73739fe4756cb409aeb5941bbb8e47R64)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-windows pull request: CB-10292: Windows platform support f...
Posted by jasongin <gi...@git.apache.org>.
Github user jasongin commented on the pull request:
https://github.com/apache/cordova-windows/pull/133#issuecomment-169083097
I updated a couple more places to support 15.0 in addition to 14.0. While those changes weren't necessary to build a cordova project from VS in the scenario we tested, it's more consistent and will probably handle other scenarios more correctly.
For now, the next version of VS still supports all the same targets as 2015. If that ever changes (e.g. it drops support for targeting Windows 8.1) then we'll need to update the logic.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-windows pull request: CB-10292: Windows platform support f...
Posted by jasongin <gi...@git.apache.org>.
Github user jasongin commented on a diff in the pull request:
https://github.com/apache/cordova-windows/pull/133#discussion_r48873267
--- Diff: template/cordova/lib/MSBuildTools.js ---
@@ -50,11 +50,11 @@ MSBuildTools.prototype.buildProject = function(projFile, buildType, buildarch, o
// returns full path to msbuild tools required to build the project and tools version
module.exports.findAvailableVersion = function () {
--- End diff --
Done.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-windows pull request: CB-10292: Windows platform support f...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-windows/pull/133
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-windows pull request: CB-10292: Windows platform support f...
Posted by jasongin <gi...@git.apache.org>.
Github user jasongin commented on the pull request:
https://github.com/apache/cordova-windows/pull/133#issuecomment-168763100
@vladimir-kotikov please review, and commit if it looks good.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-windows pull request: CB-10292: Windows platform support f...
Posted by vladimir-kotikov <gi...@git.apache.org>.
Github user vladimir-kotikov commented on the pull request:
https://github.com/apache/cordova-windows/pull/133#issuecomment-168938643
Looks like [`getMsBuildForTargets`](https://github.com/jasongin/cordova-windows/blob/CB-10292/template/cordova/lib/build.js#L506) also requires update, otherwise we won't use 15.0 for build even if it is installed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org