You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by GitBox <gi...@apache.org> on 2022/01/02 10:01:07 UTC
[GitHub] [maven-surefire] slawekjaranowski opened a new pull request #425: GitHub Shared Action v2
slawekjaranowski opened a new pull request #425:
URL: https://github.com/apache/maven-surefire/pull/425
Following this checklist to help us incorporate your
contribution quickly and easily:
- [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/SUREFIRE) filed
for the change (usually before you start working on it). Trivial changes like typos do not
require a JIRA issue. Your pull request should address just this issue, without
pulling in other changes.
- [ ] Each commit in the pull request should have a meaningful subject line and body.
- [ ] Format the pull request title like `[SUREFIRE-XXX] - Fixes bug in ApproximateQuantiles`,
where you replace `SUREFIRE-XXX` with the appropriate JIRA issue. Best practice
is to use the JIRA issue title in the pull request title and in the first line of the
commit message.
- [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [ ] Run `mvn clean install` to make sure basic checks pass. A more thorough check will
be performed on your pull request automatically.
- [ ] You have run the integration tests successfully (`mvn -Prun-its clean install`).
If your pull request is about ~20 lines of code you don't need to sign an
[Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
you have to acknowledge this by using the following check-box.
- [ ] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
- [ ] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-surefire] Tibor17 commented on pull request #425: GitHub Shared Action v2
Posted by GitBox <gi...@apache.org>.
Tibor17 commented on pull request #425:
URL: https://github.com/apache/maven-surefire/pull/425#issuecomment-1003710865
Two checks [1](https://github.com/apache/maven-surefire/runs/4683705902?check_suite_focus=true), [2](https://github.com/apache/maven-surefire/runs/4683705967?check_suite_focus=true) were skipped. Can you please have a look what happened there? Thx
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-surefire] slawekjaranowski merged pull request #425: GitHub Shared Action v2
Posted by GitBox <gi...@apache.org>.
slawekjaranowski merged pull request #425:
URL: https://github.com/apache/maven-surefire/pull/425
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-surefire] Tibor17 commented on pull request #425: GitHub Shared Action v2
Posted by GitBox <gi...@apache.org>.
Tibor17 commented on pull request #425:
URL: https://github.com/apache/maven-surefire/pull/425#issuecomment-1003711574
Is it possible to assign a timeout to each individual verification run? So that we can prevent from scenarios where the issue exhausted all resources ASF was given by GH?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-surefire] slawekjaranowski commented on pull request #425: GitHub Shared Action v2
Posted by GitBox <gi...@apache.org>.
slawekjaranowski commented on pull request #425:
URL: https://github.com/apache/maven-surefire/pull/425#issuecomment-1003713523
time out will be in next PR, first must be added to shared action as options
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-surefire] slawekjaranowski commented on pull request #425: GitHub Shared Action v2
Posted by GitBox <gi...@apache.org>.
slawekjaranowski commented on pull request #425:
URL: https://github.com/apache/maven-surefire/pull/425#issuecomment-1003712812
Check 1,2 are skipped because was triggered for `pull_request` event, and PR is from local branch from repo so build on branch `push` will be enough.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-surefire] Tibor17 commented on pull request #425: GitHub Shared Action v2
Posted by GitBox <gi...@apache.org>.
Tibor17 commented on pull request #425:
URL: https://github.com/apache/maven-surefire/pull/425#issuecomment-1003711295
Here are 10 parallel builds and they do not fail. So the disk capacity 14GB is enough here. But if we employed more h/w or jdk versions making 20 builds again, some verification may crash again on low disk space.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-surefire] slawekjaranowski commented on pull request #425: GitHub Shared Action v2
Posted by GitBox <gi...@apache.org>.
slawekjaranowski commented on pull request #425:
URL: https://github.com/apache/maven-surefire/pull/425#issuecomment-1003761135
ok, everything can be add to shared action so other project can also have the same benefits.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-surefire] slawekjaranowski commented on pull request #425: GitHub Shared Action v2
Posted by GitBox <gi...@apache.org>.
slawekjaranowski commented on pull request #425:
URL: https://github.com/apache/maven-surefire/pull/425#issuecomment-1003713322
I think that each job is executed on separate vm with separate disk space.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-surefire] Tibor17 commented on pull request #425: GitHub Shared Action v2
Posted by GitBox <gi...@apache.org>.
Tibor17 commented on pull request #425:
URL: https://github.com/apache/maven-surefire/pull/425#issuecomment-1003746851
@slawekjaranowski
I have found something interesting, see [this](https://github.com/easimon/maximize-build-space).
By default, public shared Github runners come with around 25-29 GB of free disk space to be consumed by your build job. Even if VM reserved 14 GB on SSD, the entire job has its own limits and this is maybe the reason why we reached the limits. We can maximize available disk space for our build tasks, see this [step extension](https://github.com/easimon/maximize-build-space) and feel free to discus it with ASF colleagues. What you think about this step extension?
If we employ more Java versions or Maven versions and platforms we may run out of disk space again.
One of our ASF colleagues says that you can free up a bit of space by cleaning these dirs:
```
sudo rm -rf /usr/local/lib/android # will release about 10 GB if you don't need Android
sudo rm -rf /usr/share/dotnet # will release about 20GB if you don't need .NET
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org