You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by "Zhenye-Na (via GitHub)" <gi...@apache.org> on 2023/09/26 04:51:26 UTC
[GitHub] [shardingsphere] Zhenye-Na opened a new pull request, #28588: Feature: add world map of contributors to shardingsphere project
Zhenye-Na opened a new pull request, #28588:
URL: https://github.com/apache/shardingsphere/pull/28588
Fixes #26521
Changes proposed in this pull request:
- Created a new Github Actions to automatically update the generated SVG based on Cronjob
---
Before committing this PR, I'm sure that I have checked the following options:
- [ ] My code follows the [code of conduct](https://shardingsphere.apache.org/community/en/involved/conduct/code/) of this project.
- [x] I have self-reviewed the commit code.
- [ ] I have (or in comment I request) added corresponding labels for the pull request.
- [ ] I have passed maven check locally : `./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e`.
- [ ] I have made corresponding changes to the documentation.
- [ ] I have added corresponding unit tests for my changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Feature: add world map of contributors to shardingsphere project [shardingsphere]
Posted by "taojintianxia (via GitHub)" <gi...@apache.org>.
taojintianxia merged PR #28588:
URL: https://github.com/apache/shardingsphere/pull/28588
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] Zhenye-Na commented on pull request #28588: Feature: add world map of contributors to shardingsphere project
Posted by "Zhenye-Na (via GitHub)" <gi...@apache.org>.
Zhenye-Na commented on PR #28588:
URL: https://github.com/apache/shardingsphere/pull/28588#issuecomment-1741970464
I have created a dummy workflow in my own fork with the this workflow executed successfully, [job history](https://github.com/Zhenye-Na/shardingsphere/actions/runs/6368471123/job/17287850146)
I have attached the generated image as follows:

--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] Zhenye-Na commented on pull request #28588: Feature: add world map of contributors to shardingsphere project
Posted by "Zhenye-Na (via GitHub)" <gi...@apache.org>.
Zhenye-Na commented on PR #28588:
URL: https://github.com/apache/shardingsphere/pull/28588#issuecomment-1737874195
> I suggest change the PR as followings :
>
> 1. move the content of contributors-map to nightly-build.yml
>
> 2. attach the screenshot of the svg file in the corresponding issue
>
>
> BTW, there are some code of conducts for github : https://shardingsphere.apache.org/community/cn/involved/conduct/code/ so, for the original file `contributors-map.yaml` , it's not a good name ^_^
Hi @taojintianxia
Thanks for the fast response.
1. I will make a new revision to move this to `nightly-build.yml`
2. I will attach the screenshot as well in the original issue and this PR for testing/validation purpose
3. Regarding the naming convention, sorry for the inconvenience, I will double check the link you paste here to avoid this in the future.
Will let you know once I publish a new revision of PR
Thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org