[GitHub] logging-log4net pull request #17: Save one frame from being accessed twice u...

[shubagarwal <gi...@git.apache.org>]

GitHub user shubagarwal opened a pull request:

    https://github.com/apache/logging-log4net/pull/17

    Save one frame from being accessed twice unnecessarily in ctor of LocationInfo

    The last frame in stack with declaringType as callerStackBoundaryDeclaringType was being accessed in both while loops.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/shubagarwal/logging-log4net feature/optimize-locationInfo-constructor

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/logging-log4net/pull/17.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #17
    
----
commit 37d1e9d2c13c142542bd4fafd04626b34d095be5
Author: Shubham Agarwal <sh...@aepl.com>
Date:   2017-11-09T10:54:10Z

    Save one frame from being accessed twice unnecessarily in ctor of LocationInfo
    The last frame in stack with declaringType as callerStackBoundaryDeclaringType was being accessed in both while loops.

----


---

[GitHub] logging-log4net issue #17: Save one frame from being accessed twice unnecess...

[dpsenner <gi...@git.apache.org>]

Github user dpsenner commented on the issue:

    https://github.com/apache/logging-log4net/pull/17
  
    Would you please explain the changeset more verbosely?


---

[GitHub] logging-log4net issue #17: Save one frame from being accessed twice unnecess...

[shubagarwal <gi...@git.apache.org>]

Github user shubagarwal commented on the issue:

    https://github.com/apache/logging-log4net/pull/17
  
    Update the description in first comment. Please check.


---