You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Saurav Lahiri <sa...@sungard.com> on 2014/03/24 16:00:11 UTC
Review Request 19584: CLOUDSTACK-6258: Disable systemvm cloud startup script
from logging messages to /var/log/cloud/cloud.out
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19584/
-----------------------------------------------------------
Review request for cloudstack.
Repository: cloudstack-git
Description
-------
This will prevent the /etc/init.d/cloud script from logging messages to /var/log/cloud/cloud.out if the CLOUD_DEBUG flag is not defined. If the flag is defined only then will messages be logged. This is because the cloud.out file gets rolled over once max size is reached via the log4j settings, since the script is not aware of the log4j settings it causes the log file to exceed its max size and fill up the file system.
Diffs
-----
systemvm/patches/debian/config/etc/init.d/cloud 83853bc
Diff: https://reviews.apache.org/r/19584/diff/
Testing
-------
The console proxy vm was started and console sessions tested. The secondary storage vm was succesfully started.
Thanks,
Saurav Lahiri
Re: Review Request 19584: CLOUDSTACK-6258: Disable systemvm cloud startup
script from logging messages to /var/log/cloud/cloud.out
Posted by Rajani Karuturi <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19584/#review39408
-----------------------------------------------------------
systemvm/patches/debian/config/etc/init.d/cloud
<https://reviews.apache.org/r/19584/#comment71807>
since the check is about the log file location, i think it should set just that
if()
LOG_FILE = /var/log/cloud/cloud.out
else
LOG_FILE = /dev/null
and the actual cmd can be
(cd $CLOUDSTACK_HOME/systemvm; nohup ./run.sh > $LOG_FILE 2>&1 &)
- Rajani Karuturi
On March 24, 2014, 3 p.m., Saurav Lahiri wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19584/
> -----------------------------------------------------------
>
> (Updated March 24, 2014, 3 p.m.)
>
>
> Review request for cloudstack.
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> This will prevent the /etc/init.d/cloud script from logging messages to /var/log/cloud/cloud.out if the CLOUD_DEBUG flag is not defined. If the flag is defined only then will messages be logged. This is because the cloud.out file gets rolled over once max size is reached via the log4j settings, since the script is not aware of the log4j settings it causes the log file to exceed its max size and fill up the file system.
>
>
> Diffs
> -----
>
> systemvm/patches/debian/config/etc/init.d/cloud 83853bc
>
> Diff: https://reviews.apache.org/r/19584/diff/
>
>
> Testing
> -------
>
> The console proxy vm was started and console sessions tested. The secondary storage vm was succesfully started.
>
>
> Thanks,
>
> Saurav Lahiri
>
>
Re: Review Request 19584: CLOUDSTACK-6258: Disable systemvm cloud
startup script from logging messages to /var/log/cloud/cloud.out
Posted by Saurav Lahiri <sa...@sungardas.com>.
Hi Rajesh,
I Just closed this as submitted, but don't see the changes on the master.
Do I need to reopen this one? Also can the changes to be applied back to
4.3 and 4.4?
Thanks
Saurav
On Tue, Apr 15, 2014 at 11:14 PM, Rajesh Battala
<ra...@citrix.com>wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19584/#review40414
> -----------------------------------------------------------
>
> Ship it!
>
>
> Ship It!
>
> - Rajesh Battala
>
>
> On April 14, 2014, 7:10 a.m., Saurav Lahiri wrote:
> >
> > -----------------------------------------------------------
> > This is an automatically generated e-mail. To reply, visit:
> > https://reviews.apache.org/r/19584/
> > -----------------------------------------------------------
> >
> > (Updated April 14, 2014, 7:10 a.m.)
> >
> >
> > Review request for cloudstack and Jayapal Reddy.
> >
> >
> > Repository: cloudstack-git
> >
> >
> > Description
> > -------
> >
> > This will prevent the /etc/init.d/cloud script from logging messages to
> /var/log/cloud/cloud.out if the CLOUD_DEBUG flag is not defined. If the
> flag is defined only then will messages be logged. This is because the
> cloud.out file gets rolled over once max size is reached via the log4j
> settings, since the script is not aware of the log4j settings it causes the
> log file to exceed its max size and fill up the file system.
> >
> >
> > Diffs
> > -----
> >
> > systemvm/patches/debian/config/etc/init.d/cloud 83853bc
> >
> > Diff: https://reviews.apache.org/r/19584/diff/
> >
> >
> > Testing
> > -------
> >
> > The console proxy vm was started and console sessions tested. The
> secondary storage vm was succesfully started.
> >
> >
> > Thanks,
> >
> > Saurav Lahiri
> >
> >
>
>
Re: Review Request 19584: CLOUDSTACK-6258: Disable systemvm cloud startup
script from logging messages to /var/log/cloud/cloud.out
Posted by Rajesh Battala <ra...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19584/#review40414
-----------------------------------------------------------
Ship it!
Ship It!
- Rajesh Battala
On April 14, 2014, 7:10 a.m., Saurav Lahiri wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19584/
> -----------------------------------------------------------
>
> (Updated April 14, 2014, 7:10 a.m.)
>
>
> Review request for cloudstack and Jayapal Reddy.
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> This will prevent the /etc/init.d/cloud script from logging messages to /var/log/cloud/cloud.out if the CLOUD_DEBUG flag is not defined. If the flag is defined only then will messages be logged. This is because the cloud.out file gets rolled over once max size is reached via the log4j settings, since the script is not aware of the log4j settings it causes the log file to exceed its max size and fill up the file system.
>
>
> Diffs
> -----
>
> systemvm/patches/debian/config/etc/init.d/cloud 83853bc
>
> Diff: https://reviews.apache.org/r/19584/diff/
>
>
> Testing
> -------
>
> The console proxy vm was started and console sessions tested. The secondary storage vm was succesfully started.
>
>
> Thanks,
>
> Saurav Lahiri
>
>
Re: Review Request 19584: CLOUDSTACK-6258: Disable systemvm cloud startup
script from logging messages to /var/log/cloud/cloud.out
Posted by Saurav Lahiri <sa...@sungard.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19584/
-----------------------------------------------------------
(Updated April 14, 2014, 7:10 a.m.)
Review request for cloudstack and Jayapal Reddy.
Changes
-------
Added Jayapal.
Repository: cloudstack-git
Description
-------
This will prevent the /etc/init.d/cloud script from logging messages to /var/log/cloud/cloud.out if the CLOUD_DEBUG flag is not defined. If the flag is defined only then will messages be logged. This is because the cloud.out file gets rolled over once max size is reached via the log4j settings, since the script is not aware of the log4j settings it causes the log file to exceed its max size and fill up the file system.
Diffs
-----
systemvm/patches/debian/config/etc/init.d/cloud 83853bc
Diff: https://reviews.apache.org/r/19584/diff/
Testing
-------
The console proxy vm was started and console sessions tested. The secondary storage vm was succesfully started.
Thanks,
Saurav Lahiri
Re: Review Request 19584: CLOUDSTACK-6258: Disable systemvm cloud startup
script from logging messages to /var/log/cloud/cloud.out
Posted by Saurav Lahiri <sa...@sungard.com>.
> On April 4, 2014, 6:01 a.m., Rajani Karuturi wrote:
> > systemvm/patches/debian/config/etc/init.d/cloud, line 36
> > <https://reviews.apache.org/r/19584/diff/2/?file=547785#file547785line36>
> >
> > Can we consider $CLOUD_DEBUG not set as true ie) log to cloud.out when $CLOUD_DEBUG is not set or $CLOUD_DEBUG is 1 ?
> >
> > redirect to /dev/null when $CLOUD_DEBUG is 0
> >
> > this way, it wont change the default behaviour of it. whoever doesnt want logging can set the variable to 0
>
> Saurav Lahiri wrote:
> Since the earlier behaviour was causing the file system to fill up( which is a serious issue) , I would think that changing that and preventing the init script to write to cloud.out, should be useful. And if required logging can be turned on, any problems identified and turned off.
So if there is a confusion here, the fix only prevents messages logged by the init shell script, the java process will still continue to log messages via log4j and roll over once it reaches maxSize. This has not changed.
- Saurav
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19584/#review39517
-----------------------------------------------------------
On April 3, 2014, 2:12 p.m., Saurav Lahiri wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19584/
> -----------------------------------------------------------
>
> (Updated April 3, 2014, 2:12 p.m.)
>
>
> Review request for cloudstack.
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> This will prevent the /etc/init.d/cloud script from logging messages to /var/log/cloud/cloud.out if the CLOUD_DEBUG flag is not defined. If the flag is defined only then will messages be logged. This is because the cloud.out file gets rolled over once max size is reached via the log4j settings, since the script is not aware of the log4j settings it causes the log file to exceed its max size and fill up the file system.
>
>
> Diffs
> -----
>
> systemvm/patches/debian/config/etc/init.d/cloud 83853bc
>
> Diff: https://reviews.apache.org/r/19584/diff/
>
>
> Testing
> -------
>
> The console proxy vm was started and console sessions tested. The secondary storage vm was succesfully started.
>
>
> Thanks,
>
> Saurav Lahiri
>
>
Re: Review Request 19584: CLOUDSTACK-6258: Disable systemvm cloud startup
script from logging messages to /var/log/cloud/cloud.out
Posted by Rajani Karuturi <ra...@gmail.com>.
> On April 4, 2014, 6:01 a.m., Rajani Karuturi wrote:
> > systemvm/patches/debian/config/etc/init.d/cloud, line 36
> > <https://reviews.apache.org/r/19584/diff/2/?file=547785#file547785line36>
> >
> > Can we consider $CLOUD_DEBUG not set as true ie) log to cloud.out when $CLOUD_DEBUG is not set or $CLOUD_DEBUG is 1 ?
> >
> > redirect to /dev/null when $CLOUD_DEBUG is 0
> >
> > this way, it wont change the default behaviour of it. whoever doesnt want logging can set the variable to 0
>
> Saurav Lahiri wrote:
> Since the earlier behaviour was causing the file system to fill up( which is a serious issue) , I would think that changing that and preventing the init script to write to cloud.out, should be useful. And if required logging can be turned on, any problems identified and turned off.
>
> Saurav Lahiri wrote:
> So if there is a confusion here, the fix only prevents messages logged by the init shell script, the java process will still continue to log messages via log4j and roll over once it reaches maxSize. This has not changed.
agreed
- Rajani
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19584/#review39517
-----------------------------------------------------------
On April 3, 2014, 2:12 p.m., Saurav Lahiri wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19584/
> -----------------------------------------------------------
>
> (Updated April 3, 2014, 2:12 p.m.)
>
>
> Review request for cloudstack.
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> This will prevent the /etc/init.d/cloud script from logging messages to /var/log/cloud/cloud.out if the CLOUD_DEBUG flag is not defined. If the flag is defined only then will messages be logged. This is because the cloud.out file gets rolled over once max size is reached via the log4j settings, since the script is not aware of the log4j settings it causes the log file to exceed its max size and fill up the file system.
>
>
> Diffs
> -----
>
> systemvm/patches/debian/config/etc/init.d/cloud 83853bc
>
> Diff: https://reviews.apache.org/r/19584/diff/
>
>
> Testing
> -------
>
> The console proxy vm was started and console sessions tested. The secondary storage vm was succesfully started.
>
>
> Thanks,
>
> Saurav Lahiri
>
>
Re: Review Request 19584: CLOUDSTACK-6258: Disable systemvm cloud startup
script from logging messages to /var/log/cloud/cloud.out
Posted by Saurav Lahiri <sa...@sungard.com>.
> On April 4, 2014, 6:01 a.m., Rajani Karuturi wrote:
> > systemvm/patches/debian/config/etc/init.d/cloud, line 36
> > <https://reviews.apache.org/r/19584/diff/2/?file=547785#file547785line36>
> >
> > Can we consider $CLOUD_DEBUG not set as true ie) log to cloud.out when $CLOUD_DEBUG is not set or $CLOUD_DEBUG is 1 ?
> >
> > redirect to /dev/null when $CLOUD_DEBUG is 0
> >
> > this way, it wont change the default behaviour of it. whoever doesnt want logging can set the variable to 0
>
> Saurav Lahiri wrote:
> Since the earlier behaviour was causing the file system to fill up( which is a serious issue) , I would think that changing that and preventing the init script to write to cloud.out, should be useful. And if required logging can be turned on, any problems identified and turned off.
>
> Saurav Lahiri wrote:
> So if there is a confusion here, the fix only prevents messages logged by the init shell script, the java process will still continue to log messages via log4j and roll over once it reaches maxSize. This has not changed.
>
> Rajani Karuturi wrote:
> agreed
Would someone commit this change to master ?
- Saurav
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19584/#review39517
-----------------------------------------------------------
On April 3, 2014, 2:12 p.m., Saurav Lahiri wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19584/
> -----------------------------------------------------------
>
> (Updated April 3, 2014, 2:12 p.m.)
>
>
> Review request for cloudstack.
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> This will prevent the /etc/init.d/cloud script from logging messages to /var/log/cloud/cloud.out if the CLOUD_DEBUG flag is not defined. If the flag is defined only then will messages be logged. This is because the cloud.out file gets rolled over once max size is reached via the log4j settings, since the script is not aware of the log4j settings it causes the log file to exceed its max size and fill up the file system.
>
>
> Diffs
> -----
>
> systemvm/patches/debian/config/etc/init.d/cloud 83853bc
>
> Diff: https://reviews.apache.org/r/19584/diff/
>
>
> Testing
> -------
>
> The console proxy vm was started and console sessions tested. The secondary storage vm was succesfully started.
>
>
> Thanks,
>
> Saurav Lahiri
>
>
Re: Review Request 19584: CLOUDSTACK-6258: Disable systemvm cloud startup
script from logging messages to /var/log/cloud/cloud.out
Posted by Saurav Lahiri <sa...@sungard.com>.
> On April 4, 2014, 6:01 a.m., Rajani Karuturi wrote:
> > systemvm/patches/debian/config/etc/init.d/cloud, line 36
> > <https://reviews.apache.org/r/19584/diff/2/?file=547785#file547785line36>
> >
> > Can we consider $CLOUD_DEBUG not set as true ie) log to cloud.out when $CLOUD_DEBUG is not set or $CLOUD_DEBUG is 1 ?
> >
> > redirect to /dev/null when $CLOUD_DEBUG is 0
> >
> > this way, it wont change the default behaviour of it. whoever doesnt want logging can set the variable to 0
Since the earlier behaviour was causing the file system to fill up( which is a serious issue) , I would think that changing that and preventing the init script to write to cloud.out, should be useful. And if required logging can be turned on, any problems identified and turned off.
- Saurav
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19584/#review39517
-----------------------------------------------------------
On April 3, 2014, 2:12 p.m., Saurav Lahiri wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19584/
> -----------------------------------------------------------
>
> (Updated April 3, 2014, 2:12 p.m.)
>
>
> Review request for cloudstack.
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> This will prevent the /etc/init.d/cloud script from logging messages to /var/log/cloud/cloud.out if the CLOUD_DEBUG flag is not defined. If the flag is defined only then will messages be logged. This is because the cloud.out file gets rolled over once max size is reached via the log4j settings, since the script is not aware of the log4j settings it causes the log file to exceed its max size and fill up the file system.
>
>
> Diffs
> -----
>
> systemvm/patches/debian/config/etc/init.d/cloud 83853bc
>
> Diff: https://reviews.apache.org/r/19584/diff/
>
>
> Testing
> -------
>
> The console proxy vm was started and console sessions tested. The secondary storage vm was succesfully started.
>
>
> Thanks,
>
> Saurav Lahiri
>
>
Re: Review Request 19584: CLOUDSTACK-6258: Disable systemvm cloud startup
script from logging messages to /var/log/cloud/cloud.out
Posted by Rajani Karuturi <ra...@gmail.com>.
> On April 4, 2014, 6:01 a.m., Rajani Karuturi wrote:
> > systemvm/patches/debian/config/etc/init.d/cloud, line 36
> > <https://reviews.apache.org/r/19584/diff/2/?file=547785#file547785line36>
> >
> > Can we consider $CLOUD_DEBUG not set as true ie) log to cloud.out when $CLOUD_DEBUG is not set or $CLOUD_DEBUG is 1 ?
> >
> > redirect to /dev/null when $CLOUD_DEBUG is 0
> >
> > this way, it wont change the default behaviour of it. whoever doesnt want logging can set the variable to 0
>
> Saurav Lahiri wrote:
> Since the earlier behaviour was causing the file system to fill up( which is a serious issue) , I would think that changing that and preventing the init script to write to cloud.out, should be useful. And if required logging can be turned on, any problems identified and turned off.
>
> Saurav Lahiri wrote:
> So if there is a confusion here, the fix only prevents messages logged by the init shell script, the java process will still continue to log messages via log4j and roll over once it reaches maxSize. This has not changed.
>
> Rajani Karuturi wrote:
> agreed
>
> Saurav Lahiri wrote:
> Would someone commit this change to master ?
I will request someone with committer rights to review and commit.
Thanks
- Rajani
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19584/#review39517
-----------------------------------------------------------
On April 3, 2014, 2:12 p.m., Saurav Lahiri wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19584/
> -----------------------------------------------------------
>
> (Updated April 3, 2014, 2:12 p.m.)
>
>
> Review request for cloudstack.
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> This will prevent the /etc/init.d/cloud script from logging messages to /var/log/cloud/cloud.out if the CLOUD_DEBUG flag is not defined. If the flag is defined only then will messages be logged. This is because the cloud.out file gets rolled over once max size is reached via the log4j settings, since the script is not aware of the log4j settings it causes the log file to exceed its max size and fill up the file system.
>
>
> Diffs
> -----
>
> systemvm/patches/debian/config/etc/init.d/cloud 83853bc
>
> Diff: https://reviews.apache.org/r/19584/diff/
>
>
> Testing
> -------
>
> The console proxy vm was started and console sessions tested. The secondary storage vm was succesfully started.
>
>
> Thanks,
>
> Saurav Lahiri
>
>
Re: Review Request 19584: CLOUDSTACK-6258: Disable systemvm cloud startup
script from logging messages to /var/log/cloud/cloud.out
Posted by Rajani Karuturi <ra...@gmail.com>.
> On April 4, 2014, 6:01 a.m., Rajani Karuturi wrote:
> > systemvm/patches/debian/config/etc/init.d/cloud, line 36
> > <https://reviews.apache.org/r/19584/diff/2/?file=547785#file547785line36>
> >
> > Can we consider $CLOUD_DEBUG not set as true ie) log to cloud.out when $CLOUD_DEBUG is not set or $CLOUD_DEBUG is 1 ?
> >
> > redirect to /dev/null when $CLOUD_DEBUG is 0
> >
> > this way, it wont change the default behaviour of it. whoever doesnt want logging can set the variable to 0
>
> Saurav Lahiri wrote:
> Since the earlier behaviour was causing the file system to fill up( which is a serious issue) , I would think that changing that and preventing the init script to write to cloud.out, should be useful. And if required logging can be turned on, any problems identified and turned off.
>
> Saurav Lahiri wrote:
> So if there is a confusion here, the fix only prevents messages logged by the init shell script, the java process will still continue to log messages via log4j and roll over once it reaches maxSize. This has not changed.
>
> Rajani Karuturi wrote:
> agreed
>
> Saurav Lahiri wrote:
> Would someone commit this change to master ?
>
> Rajani Karuturi wrote:
> I will request someone with committer rights to review and commit.
> Thanks
Saurav,
Can you add Jayapal to the reviewers list for this?
- Rajani
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19584/#review39517
-----------------------------------------------------------
On April 3, 2014, 2:12 p.m., Saurav Lahiri wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19584/
> -----------------------------------------------------------
>
> (Updated April 3, 2014, 2:12 p.m.)
>
>
> Review request for cloudstack.
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> This will prevent the /etc/init.d/cloud script from logging messages to /var/log/cloud/cloud.out if the CLOUD_DEBUG flag is not defined. If the flag is defined only then will messages be logged. This is because the cloud.out file gets rolled over once max size is reached via the log4j settings, since the script is not aware of the log4j settings it causes the log file to exceed its max size and fill up the file system.
>
>
> Diffs
> -----
>
> systemvm/patches/debian/config/etc/init.d/cloud 83853bc
>
> Diff: https://reviews.apache.org/r/19584/diff/
>
>
> Testing
> -------
>
> The console proxy vm was started and console sessions tested. The secondary storage vm was succesfully started.
>
>
> Thanks,
>
> Saurav Lahiri
>
>
Re: Review Request 19584: CLOUDSTACK-6258: Disable systemvm cloud startup
script from logging messages to /var/log/cloud/cloud.out
Posted by Rajani Karuturi <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19584/#review39517
-----------------------------------------------------------
systemvm/patches/debian/config/etc/init.d/cloud
<https://reviews.apache.org/r/19584/#comment71929>
Can we consider $CLOUD_DEBUG not set as true ie) log to cloud.out when $CLOUD_DEBUG is not set or $CLOUD_DEBUG is 1 ?
redirect to /dev/null when $CLOUD_DEBUG is 0
this way, it wont change the default behaviour of it. whoever doesnt want logging can set the variable to 0
- Rajani Karuturi
On April 3, 2014, 2:12 p.m., Saurav Lahiri wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19584/
> -----------------------------------------------------------
>
> (Updated April 3, 2014, 2:12 p.m.)
>
>
> Review request for cloudstack.
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> This will prevent the /etc/init.d/cloud script from logging messages to /var/log/cloud/cloud.out if the CLOUD_DEBUG flag is not defined. If the flag is defined only then will messages be logged. This is because the cloud.out file gets rolled over once max size is reached via the log4j settings, since the script is not aware of the log4j settings it causes the log file to exceed its max size and fill up the file system.
>
>
> Diffs
> -----
>
> systemvm/patches/debian/config/etc/init.d/cloud 83853bc
>
> Diff: https://reviews.apache.org/r/19584/diff/
>
>
> Testing
> -------
>
> The console proxy vm was started and console sessions tested. The secondary storage vm was succesfully started.
>
>
> Thanks,
>
> Saurav Lahiri
>
>
Re: Review Request 19584: CLOUDSTACK-6258: Disable systemvm cloud startup
script from logging messages to /var/log/cloud/cloud.out
Posted by Saurav Lahiri <sa...@sungard.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19584/
-----------------------------------------------------------
(Updated April 3, 2014, 2:12 p.m.)
Review request for cloudstack.
Changes
-------
Incorporate Review comments and retested.
Repository: cloudstack-git
Description
-------
This will prevent the /etc/init.d/cloud script from logging messages to /var/log/cloud/cloud.out if the CLOUD_DEBUG flag is not defined. If the flag is defined only then will messages be logged. This is because the cloud.out file gets rolled over once max size is reached via the log4j settings, since the script is not aware of the log4j settings it causes the log file to exceed its max size and fill up the file system.
Diffs (updated)
-----
systemvm/patches/debian/config/etc/init.d/cloud 83853bc
Diff: https://reviews.apache.org/r/19584/diff/
Testing
-------
The console proxy vm was started and console sessions tested. The secondary storage vm was succesfully started.
Thanks,
Saurav Lahiri