[GitHub] [airflow] eladkal commented on a diff in pull request #25939: Fix insert placeholders in TrinoHook

[GitBox <gi...@apache.org>]

eladkal commented on code in PR #25939:
URL: https://github.com/apache/airflow/pull/25939#discussion_r953930263


##########
airflow/providers/trino/hooks/trino.py:
##########
@@ -251,3 +251,33 @@ def test_connection(self):
             message = str(e)
 
         return status, message
+
+    @staticmethod
+    def _generate_insert_sql(table, values, target_fields, replace, **kwargs):
+        """
+        Static helper method that generates the INSERT SQL statement.
+        The REPLACE variant is specific to MySQL syntax.
+
+        :param table: Name of the target table
+        :param values: The row to insert into the table
+        :param target_fields: The names of the columns to fill in the table
+        :param replace: Whether to replace instead of insert
+        :return: The generated INSERT or REPLACE SQL statement
+        :rtype: str
+        """
+        placeholders = [
+            "?",

Review Comment:
   This is a lot of code duplication for changing just one char.
   Sqlite provider also duplicate this function just to change this one char...
   Maybe we can think of a better way to handle this?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org