You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@teaclave.apache.org by GitBox <gi...@apache.org> on 2021/08/04 20:30:15 UTC

[GitHub] [incubator-teaclave] ya0guang opened a new pull request #536: integrate pre-built TVM in the dokcer image

ya0guang opened a new pull request #536:
URL: https://github.com/apache/incubator-teaclave/pull/536


   ## Description
   
   integrate pre-built TVM in the dokcer image for faster CI. Users can also use the image to build their own TVM functions.
   
   Fixes # (issue)
   
   ## Type of change (select or add applied and delete the others)
   
   - [ ] Bug fix (non-breaking change which fixes an issue)
   - [ ] New feature (non-breaking change which adds functionality)
   - [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
   - [ ] API change with a documentation update
   - [ ] Additional test coverage
   - [ ] Code cleanup or just sync with upstream third-party crates
   
   ## How has this been tested?
   
   ## Checklist
   
   - [X] Fork the repo and create your branch from `master`.
   - [ ] If you've added code that should be tested, add tests.
   - [ ] If you've changed APIs, update the documentation.
   - [ ] Ensure the tests pass (see CI results).
   - [ ] Make sure your code lints/format.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@teaclave.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@teaclave.apache.org
For additional commands, e-mail: notifications-help@teaclave.apache.org


[GitHub] [incubator-teaclave] mssun commented on a change in pull request #536: integrate pre-built TVM in the dokcer image

Posted by GitBox <gi...@apache.org>.
mssun commented on a change in pull request #536:
URL: https://github.com/apache/incubator-teaclave/pull/536#discussion_r682937955



##########
File path: docker/build.ubuntu-1804.sgx-2.14.Dockerfile
##########
@@ -96,6 +96,20 @@ RUN apt-get install -q -y \
 # TVM Python builder dependencies
 RUN pip3 install onnx==1.9.0 numpy decorator attrs spicy
 
+# Build TVM
+# Build TVM

Review comment:
       multiple lines.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@teaclave.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@teaclave.apache.org
For additional commands, e-mail: notifications-help@teaclave.apache.org


[GitHub] [incubator-teaclave] mssun merged pull request #536: integrate pre-built TVM in the dokcer image

Posted by GitBox <gi...@apache.org>.
mssun merged pull request #536:
URL: https://github.com/apache/incubator-teaclave/pull/536


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@teaclave.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@teaclave.apache.org
For additional commands, e-mail: notifications-help@teaclave.apache.org


[GitHub] [incubator-teaclave] mssun commented on a change in pull request #536: integrate pre-built TVM in the dokcer image

Posted by GitBox <gi...@apache.org>.
mssun commented on a change in pull request #536:
URL: https://github.com/apache/incubator-teaclave/pull/536#discussion_r682953331



##########
File path: docker/build.ubuntu-1804.sgx-2.14.Dockerfile
##########
@@ -96,6 +96,19 @@ RUN apt-get install -q -y \
 # TVM Python builder dependencies
 RUN pip3 install onnx==1.9.0 numpy decorator attrs spicy
 
+# Build TVM
+RUN git clone https://github.com/apache/tvm /tvm                && \
+    cd /tvm                                                     && \
+    git checkout df06c5848f59108a8e6e7dffb997b4b659b573a7       && \
+    git submodule init                                          && \
+    git submodule update                                        && \
+    mkdir build                                                 && \
+    cd build                                                    && \
+    cp ../cmake/config.cmake ./                                 && \
+    sed -i '/set(USE_LLVM OFF)/c\set(USE_LLVM ON)' config.cmake && \
+    cmake -DUSE_LLVM=ON ..                                      && \
+    make -j4 

Review comment:
       `make -j$(nproc)`




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@teaclave.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@teaclave.apache.org
For additional commands, e-mail: notifications-help@teaclave.apache.org


[GitHub] [incubator-teaclave] mssun merged pull request #536: integrate pre-built TVM in the dokcer image

Posted by GitBox <gi...@apache.org>.
mssun merged pull request #536:
URL: https://github.com/apache/incubator-teaclave/pull/536


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@teaclave.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@teaclave.apache.org
For additional commands, e-mail: notifications-help@teaclave.apache.org


[GitHub] [incubator-teaclave] mssun commented on a change in pull request #536: integrate pre-built TVM in the dokcer image

Posted by GitBox <gi...@apache.org>.
mssun commented on a change in pull request #536:
URL: https://github.com/apache/incubator-teaclave/pull/536#discussion_r682937955



##########
File path: docker/build.ubuntu-1804.sgx-2.14.Dockerfile
##########
@@ -96,6 +96,20 @@ RUN apt-get install -q -y \
 # TVM Python builder dependencies
 RUN pip3 install onnx==1.9.0 numpy decorator attrs spicy
 
+# Build TVM
+# Build TVM

Review comment:
       multiple lines.

##########
File path: docker/build.ubuntu-1804.sgx-2.14.Dockerfile
##########
@@ -96,6 +96,19 @@ RUN apt-get install -q -y \
 # TVM Python builder dependencies
 RUN pip3 install onnx==1.9.0 numpy decorator attrs spicy
 
+# Build TVM
+RUN git clone https://github.com/apache/tvm /tvm                && \
+    cd /tvm                                                     && \
+    git checkout df06c5848f59108a8e6e7dffb997b4b659b573a7       && \
+    git submodule init                                          && \
+    git submodule update                                        && \
+    mkdir build                                                 && \
+    cd build                                                    && \
+    cp ../cmake/config.cmake ./                                 && \
+    sed -i '/set(USE_LLVM OFF)/c\set(USE_LLVM ON)' config.cmake && \
+    cmake -DUSE_LLVM=ON ..                                      && \
+    make -j4 

Review comment:
       `make -j$(nproc)`




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@teaclave.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@teaclave.apache.org
For additional commands, e-mail: notifications-help@teaclave.apache.org