You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@samza.apache.org by GitBox <gi...@apache.org> on 2020/03/31 18:50:32 UTC
[GitHub] [samza] prateekm commented on a change in pull request #1327:
SAMZA-2493: Keep checkpoint manager consumer open for repeated polling
prateekm commented on a change in pull request #1327: SAMZA-2493: Keep checkpoint manager consumer open for repeated polling
URL: https://github.com/apache/samza/pull/1327#discussion_r401138531
##########
File path: samza-core/src/main/java/org/apache/samza/config/TaskConfig.java
##########
@@ -105,6 +105,7 @@
private static final String BROADCAST_STREAM_PATTERN = "^[\\d]+$";
private static final String BROADCAST_STREAM_RANGE_PATTERN = "^\\[[\\d]+\\-[\\d]+\\]$";
public static final String CHECKPOINT_MANAGER_FACTORY = "task.checkpoint.factory";
+ public static final String CHECKPOINT_MANAGER_CONSUMER_STOP_AFTER_FIRST_READ = "task.checkpoint.consumer.stop.after.first.read";
Review comment:
Why do this as a config instead of a parameter?
If internal config, let's use samza.internal prefix.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services