[jira] [Commented] (UIMA-3374) A new mode for annotation viewer based on feature values

["Marshall Schor (JIRA)" <de...@uima.apache.org>]

    [ https://issues.apache.org/jira/browse/UIMA-3374?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14538382#comment-14538382 ] 

Marshall Schor commented on UIMA-3374:
--------------------------------------

question: the changes in createTextScrollPane, 495 (original) - The changes removed a test "if (viewMode == MODE_ANNOTATIONS)".  What was the reason for this change?

Just a comment; I'm not changing this, because of the need to avoid "bike-shedding" ( http://en.wikipedia.org/wiki/Parkinson%27s_law_of_triviality ).
It seems like the refactor to initialize things only when needed had the side effect of increasing many methods with additional checks to see if the thing needed initializing.  E.g., there's many places where code like this appears:
{code}if (this.xxxx == null) {
  this.xxxx = new ... initialization
}
{code}.  This would seem to be perhaps a bit more error-prone with future maintenance, vs. the previous approach which would initialize these in their declaration, because future maintainers might forget to include this check in new code.


> A new mode for annotation viewer based on feature values
> --------------------------------------------------------
>
>                 Key: UIMA-3374
>                 URL: https://issues.apache.org/jira/browse/UIMA-3374
>             Project: UIMA
>          Issue Type: Improvement
>          Components: InternalTools
>    Affects Versions: 2.5.0SDK
>            Reporter: James Zhu
>            Assignee: Marshall Schor
>            Priority: Minor
>              Labels: annotation, feature, filter, type, value, viewer
>         Attachments: UIMA-3374 patch 2015-04-21.txt, UIMA-3374 patch 2015-04-23.txt, UIMA-3374 patch 2015-04-28.txt, UIMA-3374 patch 2015-05-08.txt, screenshot-1.jpg, screenshot-2.jpg, screenshot-3.jpg, screenshot-4.jpg
>
>   Original Estimate: 504h
>  Remaining Estimate: 504h
>
> I'd like to propose adding a new "view mode" in the UIMA Annotation Viewer so that user can pick a specific type of annotations, and then pick a specific feature, and pick specific feature values available so user can see a subset of those annotation objects that have the specific feature values.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)