You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "aprimadi (via GitHub)" <gi...@apache.org> on 2023/05/06 05:44:57 UTC

[GitHub] [arrow-datafusion] aprimadi opened a new issue, #6258: sqllogictest statement error no escaping

aprimadi opened a new issue, #6258:
URL: https://github.com/apache/arrow-datafusion/issues/6258

   ### Is your feature request related to a problem or challenge?
   
   Currently `(` and `)` character needs to be escaped in sqllogictest statement error. Not sure if this is possible but it would be great if I can just supply a string that is an exact match of the output and not need to escape the character.
   
   For example:
   
   Expected
   ```
   statement error ParserError("blablabla")
   ```
   
   Right now:
   ```
   statement error ParserError\("blablabla"\)
   ```
   
   ### Describe the solution you'd like
   
   _No response_
   
   ### Describe alternatives you've considered
   
   _No response_
   
   ### Additional context
   
   _No response_


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-datafusion] alamb commented on issue #6258: sqllogictest statement error no escaping

Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on issue #6258:
URL: https://github.com/apache/arrow-datafusion/issues/6258#issuecomment-1555081262

   Closing this ticket as working as expected, I think


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-datafusion] alamb commented on issue #6258: sqllogictest statement error no escaping

Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on issue #6258:
URL: https://github.com/apache/arrow-datafusion/issues/6258#issuecomment-1555080946

   I think I have seen errors (maybe where newlines aren't escaped?) I'll pay attention to this in more detail if it happens again


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-datafusion] alamb closed issue #6258: sqllogictest statement error no escaping

Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb closed issue #6258: sqllogictest statement error no escaping
URL: https://github.com/apache/arrow-datafusion/issues/6258


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-datafusion] alamb commented on issue #6258: sqllogictest statement error no escaping

Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on issue #6258:
URL: https://github.com/apache/arrow-datafusion/issues/6258#issuecomment-1554629383

   FYI @melgenek  -- this seems very similar to https://github.com/apache/arrow-datafusion/issues/5727
   
    I wonder if we can apply a similar fix 🤔 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-datafusion] melgenek commented on issue #6258: sqllogictest statement error no escaping

Posted by "melgenek (via GitHub)" <gi...@apache.org>.
melgenek commented on issue #6258:
URL: https://github.com/apache/arrow-datafusion/issues/6258#issuecomment-1555069229

   >  it would be great if I can just supply a string that is an exact match of the output and not need to escape the character.
   
   If I understand correctly, there is no issue at the moment, and validation works correctly when symbols are escaped.
   
   `sqllogictest-rs` makes an explicit choice to have errors as Regexp, that's why there is a need to escape characters that have special meaning in Regex like `(`,`)`,`.`,`[`,`]`
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org