You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@pegasus.apache.org by GitBox <gi...@apache.org> on 2022/06/28 15:59:17 UTC
[GitHub] [incubator-pegasus] acelyc111 opened a new pull request, #1022: chore(clang-format): unify rdsn and Pegasus clang-format
acelyc111 opened a new pull request, #1022:
URL: https://github.com/apache/incubator-pegasus/pull/1022
### What problem does this PR solve? <!--add issue link with summary if exists-->
Unify the rdsn and the Pegasus projects' clang-format tools.
### What is changed and how does it work?
### Checklist <!--REMOVE the items that are not applicable-->
##### Tests <!-- At least one of them must be included. -->
- Integration test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org
[GitHub] [incubator-pegasus] acelyc111 closed pull request #1022: chore(clang-format): unify rdsn and Pegasus clang-format
Posted by GitBox <gi...@apache.org>.
acelyc111 closed pull request #1022: chore(clang-format): unify rdsn and Pegasus clang-format
URL: https://github.com/apache/incubator-pegasus/pull/1022
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org
[GitHub] [incubator-pegasus] acelyc111 closed pull request #1022: chore(clang-format): unify rdsn and Pegasus clang-format
Posted by GitBox <gi...@apache.org>.
acelyc111 closed pull request #1022: chore(clang-format): unify rdsn and Pegasus clang-format
URL: https://github.com/apache/incubator-pegasus/pull/1022
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org
[GitHub] [incubator-pegasus] acelyc111 commented on pull request #1022: chore(clang-format): unify rdsn and Pegasus clang-format
Posted by GitBox <gi...@apache.org>.
acelyc111 commented on PR #1022:
URL: https://github.com/apache/incubator-pegasus/pull/1022#issuecomment-1176958669
Let's merge this pr, the left issue is not introduced by this pr, we can resolve it latter.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org
[GitHub] [incubator-pegasus] acelyc111 commented on pull request #1022: chore(clang-format): unify rdsn and Pegasus clang-format
Posted by GitBox <gi...@apache.org>.
acelyc111 commented on PR #1022:
URL: https://github.com/apache/incubator-pegasus/pull/1022#issuecomment-1176943802
> Can it be merged now?
It will report an illegal instruction error if I don't skip building third party, as shown in https://github.com/apache/incubator-pegasus/runs/7209009710?check_suite_focus=true, I'm not sure how it happened, even I re-trigger rebuild the third party bin package.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org
[GitHub] [incubator-pegasus] acelyc111 merged pull request #1022: chore(clang-format): unify rdsn and Pegasus clang-format
Posted by GitBox <gi...@apache.org>.
acelyc111 merged PR #1022:
URL: https://github.com/apache/incubator-pegasus/pull/1022
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org
[GitHub] [incubator-pegasus] acelyc111 commented on pull request #1022: chore(clang-format): unify rdsn and Pegasus clang-format
Posted by GitBox <gi...@apache.org>.
acelyc111 commented on PR #1022:
URL: https://github.com/apache/incubator-pegasus/pull/1022#issuecomment-1186544589
also related to: https://github.com/apache/incubator-pegasus/issues/1053
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org
[GitHub] [incubator-pegasus] acelyc111 commented on pull request #1022: chore(clang-format): unify rdsn and Pegasus clang-format
Posted by GitBox <gi...@apache.org>.
acelyc111 commented on PR #1022:
URL: https://github.com/apache/incubator-pegasus/pull/1022#issuecomment-1176946212
> > Can it be merged now?
>
> It will report an illegal instruction error if I don't skip building third party, as shown in https://github.com/apache/incubator-pegasus/runs/7209009710?check_suite_focus=true, I'm not sure how it happened, even I re-trigger rebuild the third party bin package.
So I remove --skip_thirdpary in .github/workflows/lint_and_test_pegasus.yaml
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org