You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@eagle.apache.org by qingwen220 <gi...@git.apache.org> on 2016/10/11 14:01:24 UTC
[GitHub] incubator-eagle pull request #492: EAGLE-609: Fix nullPointerException in De...
GitHub user qingwen220 opened a pull request:
https://github.com/apache/incubator-eagle/pull/492
EAGLE-609: Fix nullPointerException in DefaultDeduplicator
https://issues.apache.org/jira/browse/EAGLE-609
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/qingwen220/incubator-eagle EAGLE-609
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-eagle/pull/492.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #492
----
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-eagle pull request #492: EAGLE-609: Fix nullPointerException in De...
Posted by haoch <gi...@git.apache.org>.
Github user haoch commented on a diff in the pull request:
https://github.com/apache/incubator-eagle/pull/492#discussion_r82824325
--- Diff: eagle-core/eagle-alert-parent/eagle-alert-app/src/main/resources/META-INF/providers/org.apache.eagle.alert.app.AlertUnitTopologyAppProvider.xml ---
@@ -25,6 +25,12 @@
<configuration>
<!-- alert topology sizing parameters -->
<property>
+ <name>topology.name</name>
+ <displayName>topology.name</displayName>
+ <value>alertUnitTopology_1</value>
--- End diff --
I think we should not keep current implementation only supporting hard-coded "alertUnitTopology_1", and coordinator should be able to easily fix it to use actual topology name accordingly.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-eagle pull request #492: EAGLE-609: Fix nullPointerException in De...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-eagle/pull/492
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---