You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "Sven Meier (JIRA)" <ji...@apache.org> on 2007/09/22 16:19:50 UTC
[jira] Created: (WICKET-998) Remove obsolete attribute modifier
Remove obsolete attribute modifier
----------------------------------
Key: WICKET-998
URL: https://issues.apache.org/jira/browse/WICKET-998
Project: Wicket
Issue Type: Improvement
Components: wicket-examples
Affects Versions: 1.3.0-beta3
Reporter: Sven Meier
Priority: Trivial
I'm sorry to bother you with such a trivial thing, but we should spare new users the need to look for the reason for the AttributeModifier: there's none.
Index: /home/sven/workspace/wicket/jdk-1.5/wicket-examples/src/main/java/org/apache/wicket/examples/hangman/Guess.java
===================================================================
--- /home/sven/workspace/wicket/jdk-1.5/wicket-examples/src/main/java/org/apache/wicket/examples/hangman/Guess.java (revision 578440)
+++ /home/sven/workspace/wicket/jdk-1.5/wicket-examples/src/main/java/org/apache/wicket/examples/hangman/Guess.java (working copy)
@@ -89,9 +89,6 @@
}
}
};
- link
- .add(new AttributeModifier("id", true, new Model("letter_"
- + letter.asString())));
link.add(new Image("image", letter.getSharedImageResource()));
listItem.add(link);
}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (WICKET-998) Remove obsolete attribute modifier
Posted by "Igor Vaynberg (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-998?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Igor Vaynberg resolved WICKET-998.
----------------------------------
Resolution: Fixed
Fix Version/s: 1.3.0-beta4
Assignee: Igor Vaynberg
> Remove obsolete attribute modifier
> ----------------------------------
>
> Key: WICKET-998
> URL: https://issues.apache.org/jira/browse/WICKET-998
> Project: Wicket
> Issue Type: Improvement
> Components: wicket-examples
> Affects Versions: 1.3.0-beta3
> Reporter: Sven Meier
> Assignee: Igor Vaynberg
> Priority: Trivial
> Fix For: 1.3.0-beta4
>
>
> I'm sorry to bother you with such a trivial thing, but we should spare new users the need to look for the reason for the AttributeModifier: there's none.
> Index: /home/sven/workspace/wicket/jdk-1.5/wicket-examples/src/main/java/org/apache/wicket/examples/hangman/Guess.java
> ===================================================================
> --- /home/sven/workspace/wicket/jdk-1.5/wicket-examples/src/main/java/org/apache/wicket/examples/hangman/Guess.java (revision 578440)
> +++ /home/sven/workspace/wicket/jdk-1.5/wicket-examples/src/main/java/org/apache/wicket/examples/hangman/Guess.java (working copy)
> @@ -89,9 +89,6 @@
> }
> }
> };
> - link
> - .add(new AttributeModifier("id", true, new Model("letter_"
> - + letter.asString())));
> link.add(new Image("image", letter.getSharedImageResource()));
> listItem.add(link);
> }
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-998) Remove obsolete attribute modifier
Posted by "Igor Vaynberg (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12529780 ]
Igor Vaynberg commented on WICKET-998:
--------------------------------------
i actually had to put it back because that id is used for unittesting. i did simplify the code though a bit, using simpleattributemodiier instead.
> Remove obsolete attribute modifier
> ----------------------------------
>
> Key: WICKET-998
> URL: https://issues.apache.org/jira/browse/WICKET-998
> Project: Wicket
> Issue Type: Improvement
> Components: wicket-examples
> Affects Versions: 1.3.0-beta3
> Reporter: Sven Meier
> Assignee: Igor Vaynberg
> Priority: Trivial
> Fix For: 1.3.0-beta4
>
>
> I'm sorry to bother you with such a trivial thing, but we should spare new users the need to look for the reason for the AttributeModifier: there's none.
> Index: /home/sven/workspace/wicket/jdk-1.5/wicket-examples/src/main/java/org/apache/wicket/examples/hangman/Guess.java
> ===================================================================
> --- /home/sven/workspace/wicket/jdk-1.5/wicket-examples/src/main/java/org/apache/wicket/examples/hangman/Guess.java (revision 578440)
> +++ /home/sven/workspace/wicket/jdk-1.5/wicket-examples/src/main/java/org/apache/wicket/examples/hangman/Guess.java (working copy)
> @@ -89,9 +89,6 @@
> }
> }
> };
> - link
> - .add(new AttributeModifier("id", true, new Model("letter_"
> - + letter.asString())));
> link.add(new Image("image", letter.getSharedImageResource()));
> listItem.add(link);
> }
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.