You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-dev@hadoop.apache.org by "Raghu Angadi (JIRA)" <ji...@apache.org> on 2008/04/04 20:05:25 UTC
[jira] Created: (HADOOP-3175) "-get file -" does not work
"-get file -" does not work
---------------------------
Key: HADOOP-3175
URL: https://issues.apache.org/jira/browse/HADOOP-3175
Project: Hadoop Core
Issue Type: Bug
Affects Versions: 0.17.0
Reporter: Raghu Angadi
{noformat}
$ bin/hadoop fs -get file - > /dev/null
Usage: java FsShell -get [-ignoreCrc] [-crc] <src> <localdst>
get: Illegal option -
{noformat}
In 0.16, it used to write 'file' to stdout.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-3175) "-get file -" does not work
Posted by "Raghu Angadi (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-3175?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12586653#action_12586653 ]
Raghu Angadi commented on HADOOP-3175:
--------------------------------------
bq. I don't see why rest (ex. '> /dev/null')
"> /dev/null" is not part of the command. That is interpreted by the user shell. I don't think there is a requirement that "-" should only be the last arg. Could also add test case where it is not the last arg to your test?
Would replacing {noformat}if (args[pos].charAt(0) == '-') ... {noformat} with {noformat} if (args[pos].charAt(0) == '-' && arg[pos].length > 0) ... {noformat} be enough for the fix?
> "-get file -" does not work
> ---------------------------
>
> Key: HADOOP-3175
> URL: https://issues.apache.org/jira/browse/HADOOP-3175
> Project: Hadoop Core
> Issue Type: Bug
> Components: fs
> Affects Versions: 0.17.0
> Reporter: Raghu Angadi
> Assignee: Edward J. Yoon
> Priority: Blocker
> Fix For: 0.17.0
>
> Attachments: 3175.patch
>
>
> {noformat}
> $ bin/hadoop fs -get file - > /dev/null
> Usage: java FsShell -get [-ignoreCrc] [-crc] <src> <localdst>
> get: Illegal option -
> {noformat}
> In 0.16, it used to write 'file' to stdout.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-3175) "-get file -" does not work
Posted by "Raghu Angadi (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-3175?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Raghu Angadi updated HADOOP-3175:
---------------------------------
Attachment: 3175_v02.patch
Updated patch attached.
What I meant is that adding {code}
cf = new CommandFormat("put", 2, 10000);
assertEquals(cf.parse(new String[] {"-put", "-", "dest"}, 1).get(1), "dest"); {code}
to your test fails the test, but it should not. Attached patch fixes that.
> "-get file -" does not work
> ---------------------------
>
> Key: HADOOP-3175
> URL: https://issues.apache.org/jira/browse/HADOOP-3175
> Project: Hadoop Core
> Issue Type: Bug
> Components: fs
> Affects Versions: 0.17.0
> Reporter: Raghu Angadi
> Assignee: Edward J. Yoon
> Priority: Blocker
> Fix For: 0.17.0
>
> Attachments: 3175.patch, 3175_v01.patch, 3175_v02.patch
>
>
> {noformat}
> $ bin/hadoop fs -get file - > /dev/null
> Usage: java FsShell -get [-ignoreCrc] [-crc] <src> <localdst>
> get: Illegal option -
> {noformat}
> In 0.16, it used to write 'file' to stdout.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-3175) "-get file -" does not work
Posted by "Edward J. Yoon (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-3175?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12586710#action_12586710 ]
Edward J. Yoon commented on HADOOP-3175:
----------------------------------------
If dststr.equals("-") in copyToLocal(), it will be redirect to cat().
We don't need an rest arguments to add to parameter list.
{code}
if (dststr.equals("-")) {
...
cat(srcstr, verifyChecksum);
} else {
...
copyToLocal(srcFS, p, f, copyCrc);
}
{code}
And, I added a testFsShell() to TestFileSystem.
> "-get file -" does not work
> ---------------------------
>
> Key: HADOOP-3175
> URL: https://issues.apache.org/jira/browse/HADOOP-3175
> Project: Hadoop Core
> Issue Type: Bug
> Components: fs
> Affects Versions: 0.17.0
> Reporter: Raghu Angadi
> Assignee: Edward J. Yoon
> Priority: Blocker
> Fix For: 0.17.0
>
> Attachments: 3175.patch, 3175_v01.patch
>
>
> {noformat}
> $ bin/hadoop fs -get file - > /dev/null
> Usage: java FsShell -get [-ignoreCrc] [-crc] <src> <localdst>
> get: Illegal option -
> {noformat}
> In 0.16, it used to write 'file' to stdout.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-3175) "-get file -" does not work
Posted by "Edward J. Yoon (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-3175?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Edward J. Yoon updated HADOOP-3175:
-----------------------------------
Status: Open (was: Patch Available)
> "-get file -" does not work
> ---------------------------
>
> Key: HADOOP-3175
> URL: https://issues.apache.org/jira/browse/HADOOP-3175
> Project: Hadoop Core
> Issue Type: Bug
> Components: fs
> Affects Versions: 0.17.0
> Reporter: Raghu Angadi
> Assignee: Edward J. Yoon
> Priority: Blocker
> Fix For: 0.17.0
>
> Attachments: 3175.patch
>
>
> {noformat}
> $ bin/hadoop fs -get file - > /dev/null
> Usage: java FsShell -get [-ignoreCrc] [-crc] <src> <localdst>
> get: Illegal option -
> {noformat}
> In 0.16, it used to write 'file' to stdout.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-3175) "-get file -" does not work
Posted by "Raghu Angadi (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-3175?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12587392#action_12587392 ]
Raghu Angadi commented on HADOOP-3175:
--------------------------------------
This affects only 0.17 and above.
> "-get file -" does not work
> ---------------------------
>
> Key: HADOOP-3175
> URL: https://issues.apache.org/jira/browse/HADOOP-3175
> Project: Hadoop Core
> Issue Type: Bug
> Components: fs
> Affects Versions: 0.17.0
> Reporter: Raghu Angadi
> Assignee: Edward J. Yoon
> Priority: Blocker
> Fix For: 0.17.0
>
> Attachments: 3175.patch, 3175_v01.patch, 3175_v02.patch
>
>
> {noformat}
> $ bin/hadoop fs -get file - > /dev/null
> Usage: java FsShell -get [-ignoreCrc] [-crc] <src> <localdst>
> get: Illegal option -
> {noformat}
> In 0.16, it used to write 'file' to stdout.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-3175) "-get file -" does not work
Posted by "Milind Bhandarkar (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-3175?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12587357#action_12587357 ]
Milind Bhandarkar commented on HADOOP-3175:
-------------------------------------------
I can't believe I missed this !
How about backporting it to 0.16.3 ?
> "-get file -" does not work
> ---------------------------
>
> Key: HADOOP-3175
> URL: https://issues.apache.org/jira/browse/HADOOP-3175
> Project: Hadoop Core
> Issue Type: Bug
> Components: fs
> Affects Versions: 0.17.0
> Reporter: Raghu Angadi
> Assignee: Edward J. Yoon
> Priority: Blocker
> Fix For: 0.17.0
>
> Attachments: 3175.patch, 3175_v01.patch, 3175_v02.patch
>
>
> {noformat}
> $ bin/hadoop fs -get file - > /dev/null
> Usage: java FsShell -get [-ignoreCrc] [-crc] <src> <localdst>
> get: Illegal option -
> {noformat}
> In 0.16, it used to write 'file' to stdout.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-3175) "-get file -" does not work
Posted by "Edward J. Yoon (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-3175?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Edward J. Yoon updated HADOOP-3175:
-----------------------------------
Attachment: 3175.patch
Escape parsing(CommandFormat.parse()) for the native OS commands when appear ' - '.
> "-get file -" does not work
> ---------------------------
>
> Key: HADOOP-3175
> URL: https://issues.apache.org/jira/browse/HADOOP-3175
> Project: Hadoop Core
> Issue Type: Bug
> Components: fs
> Affects Versions: 0.17.0
> Reporter: Raghu Angadi
> Assignee: Edward J. Yoon
> Priority: Blocker
> Fix For: 0.17.0
>
> Attachments: 3175.patch
>
>
> {noformat}
> $ bin/hadoop fs -get file - > /dev/null
> Usage: java FsShell -get [-ignoreCrc] [-crc] <src> <localdst>
> get: Illegal option -
> {noformat}
> In 0.16, it used to write 'file' to stdout.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-3175) "-get file -" does not work
Posted by "Raghu Angadi (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-3175?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Raghu Angadi updated HADOOP-3175:
---------------------------------
Fix Version/s: 0.17.0
Thank Edward for looking into this. I am setting the fix version to "0.17" since this is a very user visible problem.
> "-get file -" does not work
> ---------------------------
>
> Key: HADOOP-3175
> URL: https://issues.apache.org/jira/browse/HADOOP-3175
> Project: Hadoop Core
> Issue Type: Bug
> Components: fs
> Affects Versions: 0.17.0
> Reporter: Raghu Angadi
> Assignee: Edward J. Yoon
> Fix For: 0.17.0
>
>
> {noformat}
> $ bin/hadoop fs -get file - > /dev/null
> Usage: java FsShell -get [-ignoreCrc] [-crc] <src> <localdst>
> get: Illegal option -
> {noformat}
> In 0.16, it used to write 'file' to stdout.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-3175) "-get file -" does not work
Posted by "Raghu Angadi (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-3175?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12586488#action_12586488 ]
Raghu Angadi commented on HADOOP-3175:
--------------------------------------
does "-put - file" work with this? Looks like args after "-" are not added to parameter list. Do you want to call the test 'testUdanax'?
> "-get file -" does not work
> ---------------------------
>
> Key: HADOOP-3175
> URL: https://issues.apache.org/jira/browse/HADOOP-3175
> Project: Hadoop Core
> Issue Type: Bug
> Components: fs
> Affects Versions: 0.17.0
> Reporter: Raghu Angadi
> Assignee: Edward J. Yoon
> Priority: Blocker
> Fix For: 0.17.0
>
> Attachments: 3175.patch
>
>
> {noformat}
> $ bin/hadoop fs -get file - > /dev/null
> Usage: java FsShell -get [-ignoreCrc] [-crc] <src> <localdst>
> get: Illegal option -
> {noformat}
> In 0.16, it used to write 'file' to stdout.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-3175) "-get file -" does not work
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-3175?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12587614#action_12587614 ]
Hudson commented on HADOOP-3175:
--------------------------------
Integrated in Hadoop-trunk #456 (See [http://hudson.zones.apache.org/hudson/job/Hadoop-trunk/456/])
> "-get file -" does not work
> ---------------------------
>
> Key: HADOOP-3175
> URL: https://issues.apache.org/jira/browse/HADOOP-3175
> Project: Hadoop Core
> Issue Type: Bug
> Components: fs
> Affects Versions: 0.17.0
> Reporter: Raghu Angadi
> Assignee: Edward J. Yoon
> Priority: Blocker
> Fix For: 0.17.0
>
> Attachments: 3175.patch, 3175_v01.patch, 3175_v02.patch
>
>
> {noformat}
> $ bin/hadoop fs -get file - > /dev/null
> Usage: java FsShell -get [-ignoreCrc] [-crc] <src> <localdst>
> get: Illegal option -
> {noformat}
> In 0.16, it used to write 'file' to stdout.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-3175) "-get file -" does not work
Posted by "Edward J. Yoon (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-3175?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12586649#action_12586649 ]
Edward J. Yoon commented on HADOOP-3175:
----------------------------------------
>> does 'put - file' work with this? Looks like args after "" are not added to parameter list.
I don't see why rest (ex. '> /dev/null') should remain as argument of parameter list.
Would you explain it more clearly?
> "-get file -" does not work
> ---------------------------
>
> Key: HADOOP-3175
> URL: https://issues.apache.org/jira/browse/HADOOP-3175
> Project: Hadoop Core
> Issue Type: Bug
> Components: fs
> Affects Versions: 0.17.0
> Reporter: Raghu Angadi
> Assignee: Edward J. Yoon
> Priority: Blocker
> Fix For: 0.17.0
>
> Attachments: 3175.patch
>
>
> {noformat}
> $ bin/hadoop fs -get file - > /dev/null
> Usage: java FsShell -get [-ignoreCrc] [-crc] <src> <localdst>
> get: Illegal option -
> {noformat}
> In 0.16, it used to write 'file' to stdout.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-3175) "-get file -" does not work
Posted by "Raghu Angadi (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-3175?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Raghu Angadi updated HADOOP-3175:
---------------------------------
Component/s: fs
> "-get file -" does not work
> ---------------------------
>
> Key: HADOOP-3175
> URL: https://issues.apache.org/jira/browse/HADOOP-3175
> Project: Hadoop Core
> Issue Type: Bug
> Components: fs
> Affects Versions: 0.17.0
> Reporter: Raghu Angadi
>
> {noformat}
> $ bin/hadoop fs -get file - > /dev/null
> Usage: java FsShell -get [-ignoreCrc] [-crc] <src> <localdst>
> get: Illegal option -
> {noformat}
> In 0.16, it used to write 'file' to stdout.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-3175) "-get file -" does not work
Posted by "Edward J. Yoon (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-3175?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12586659#action_12586659 ]
Edward J. Yoon commented on HADOOP-3175:
----------------------------------------
Then, { '>', '/dev/null' } will be added to parameter list and return the exception of "Illegal number of arguments".
IMO, Should be escaped for the native OS commands when appear ' - '.
> "-get file -" does not work
> ---------------------------
>
> Key: HADOOP-3175
> URL: https://issues.apache.org/jira/browse/HADOOP-3175
> Project: Hadoop Core
> Issue Type: Bug
> Components: fs
> Affects Versions: 0.17.0
> Reporter: Raghu Angadi
> Assignee: Edward J. Yoon
> Priority: Blocker
> Fix For: 0.17.0
>
> Attachments: 3175.patch
>
>
> {noformat}
> $ bin/hadoop fs -get file - > /dev/null
> Usage: java FsShell -get [-ignoreCrc] [-crc] <src> <localdst>
> get: Illegal option -
> {noformat}
> In 0.16, it used to write 'file' to stdout.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-3175) "-get file -" does not work
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-3175?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12587280#action_12587280 ]
Hadoop QA commented on HADOOP-3175:
-----------------------------------
+1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12379682/3175_v02.patch
against trunk revision 645773.
@author +1. The patch does not contain any @author tags.
tests included +1. The patch appears to include 3 new or modified tests.
javadoc +1. The javadoc tool did not generate any warning messages.
javac +1. The applied patch does not generate any new javac compiler warnings.
release audit +1. The applied patch does not generate any new release audit warnings.
findbugs +1. The patch does not introduce any new Findbugs warnings.
core tests +1. The patch passed core unit tests.
contrib tests +1. The patch passed contrib unit tests.
Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2187/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2187/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2187/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2187/console
This message is automatically generated.
> "-get file -" does not work
> ---------------------------
>
> Key: HADOOP-3175
> URL: https://issues.apache.org/jira/browse/HADOOP-3175
> Project: Hadoop Core
> Issue Type: Bug
> Components: fs
> Affects Versions: 0.17.0
> Reporter: Raghu Angadi
> Assignee: Edward J. Yoon
> Priority: Blocker
> Fix For: 0.17.0
>
> Attachments: 3175.patch, 3175_v01.patch, 3175_v02.patch
>
>
> {noformat}
> $ bin/hadoop fs -get file - > /dev/null
> Usage: java FsShell -get [-ignoreCrc] [-crc] <src> <localdst>
> get: Illegal option -
> {noformat}
> In 0.16, it used to write 'file' to stdout.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-3175) "-get file -" does not work
Posted by "Nigel Daley (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-3175?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Nigel Daley updated HADOOP-3175:
--------------------------------
Priority: Blocker (was: Major)
> "-get file -" does not work
> ---------------------------
>
> Key: HADOOP-3175
> URL: https://issues.apache.org/jira/browse/HADOOP-3175
> Project: Hadoop Core
> Issue Type: Bug
> Components: fs
> Affects Versions: 0.17.0
> Reporter: Raghu Angadi
> Assignee: Edward J. Yoon
> Priority: Blocker
> Fix For: 0.17.0
>
>
> {noformat}
> $ bin/hadoop fs -get file - > /dev/null
> Usage: java FsShell -get [-ignoreCrc] [-crc] <src> <localdst>
> get: Illegal option -
> {noformat}
> In 0.16, it used to write 'file' to stdout.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (HADOOP-3175) "-get file -" does not work
Posted by "Edward J. Yoon (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-3175?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Edward J. Yoon reassigned HADOOP-3175:
--------------------------------------
Assignee: Edward J. Yoon
> "-get file -" does not work
> ---------------------------
>
> Key: HADOOP-3175
> URL: https://issues.apache.org/jira/browse/HADOOP-3175
> Project: Hadoop Core
> Issue Type: Bug
> Components: fs
> Affects Versions: 0.17.0
> Reporter: Raghu Angadi
> Assignee: Edward J. Yoon
>
> {noformat}
> $ bin/hadoop fs -get file - > /dev/null
> Usage: java FsShell -get [-ignoreCrc] [-crc] <src> <localdst>
> get: Illegal option -
> {noformat}
> In 0.16, it used to write 'file' to stdout.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Issue Comment Edited: (HADOOP-3175) "-get file -" does not
work
Posted by "Raghu Angadi (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-3175?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12586488#action_12586488 ]
rangadi edited comment on HADOOP-3175 at 4/7/08 11:07 AM:
---------------------------------------------------------------
does '{{-put - file}}' work with this? Looks like args after "-" are not added to parameter list. Do you want to call the test 'testUdanax'?
was (Author: rangadi):
does "-put - file" work with this? Looks like args after "-" are not added to parameter list. Do you want to call the test 'testUdanax'?
> "-get file -" does not work
> ---------------------------
>
> Key: HADOOP-3175
> URL: https://issues.apache.org/jira/browse/HADOOP-3175
> Project: Hadoop Core
> Issue Type: Bug
> Components: fs
> Affects Versions: 0.17.0
> Reporter: Raghu Angadi
> Assignee: Edward J. Yoon
> Priority: Blocker
> Fix For: 0.17.0
>
> Attachments: 3175.patch
>
>
> {noformat}
> $ bin/hadoop fs -get file - > /dev/null
> Usage: java FsShell -get [-ignoreCrc] [-crc] <src> <localdst>
> get: Illegal option -
> {noformat}
> In 0.16, it used to write 'file' to stdout.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-3175) "-get file -" does not work
Posted by "Raghu Angadi (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-3175?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Raghu Angadi updated HADOOP-3175:
---------------------------------
Resolution: Fixed
Hadoop Flags: [Reviewed]
Status: Resolved (was: Patch Available)
I just committed this. Thanks Edward!
> "-get file -" does not work
> ---------------------------
>
> Key: HADOOP-3175
> URL: https://issues.apache.org/jira/browse/HADOOP-3175
> Project: Hadoop Core
> Issue Type: Bug
> Components: fs
> Affects Versions: 0.17.0
> Reporter: Raghu Angadi
> Assignee: Edward J. Yoon
> Priority: Blocker
> Fix For: 0.17.0
>
> Attachments: 3175.patch, 3175_v01.patch, 3175_v02.patch
>
>
> {noformat}
> $ bin/hadoop fs -get file - > /dev/null
> Usage: java FsShell -get [-ignoreCrc] [-crc] <src> <localdst>
> get: Illegal option -
> {noformat}
> In 0.16, it used to write 'file' to stdout.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-3175) "-get file -" does not work
Posted by "Raghu Angadi (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-3175?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Raghu Angadi updated HADOOP-3175:
---------------------------------
Status: Patch Available (was: Open)
> "-get file -" does not work
> ---------------------------
>
> Key: HADOOP-3175
> URL: https://issues.apache.org/jira/browse/HADOOP-3175
> Project: Hadoop Core
> Issue Type: Bug
> Components: fs
> Affects Versions: 0.17.0
> Reporter: Raghu Angadi
> Assignee: Edward J. Yoon
> Priority: Blocker
> Fix For: 0.17.0
>
> Attachments: 3175.patch, 3175_v01.patch, 3175_v02.patch
>
>
> {noformat}
> $ bin/hadoop fs -get file - > /dev/null
> Usage: java FsShell -get [-ignoreCrc] [-crc] <src> <localdst>
> get: Illegal option -
> {noformat}
> In 0.16, it used to write 'file' to stdout.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-3175) "-get file -" does not work
Posted by "Edward J. Yoon (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-3175?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12587014#action_12587014 ]
Edward J. Yoon commented on HADOOP-3175:
----------------------------------------
+1 I always wants a 2 percent something else.
> "-get file -" does not work
> ---------------------------
>
> Key: HADOOP-3175
> URL: https://issues.apache.org/jira/browse/HADOOP-3175
> Project: Hadoop Core
> Issue Type: Bug
> Components: fs
> Affects Versions: 0.17.0
> Reporter: Raghu Angadi
> Assignee: Edward J. Yoon
> Priority: Blocker
> Fix For: 0.17.0
>
> Attachments: 3175.patch, 3175_v01.patch, 3175_v02.patch
>
>
> {noformat}
> $ bin/hadoop fs -get file - > /dev/null
> Usage: java FsShell -get [-ignoreCrc] [-crc] <src> <localdst>
> get: Illegal option -
> {noformat}
> In 0.16, it used to write 'file' to stdout.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-3175) "-get file -" does not work
Posted by "Raghu Angadi (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-3175?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12586675#action_12586675 ]
Raghu Angadi commented on HADOOP-3175:
--------------------------------------
I didn't quite follow the adding ">" and "/dev/null" to the test.
I will see if I can submit a slightly modified version of your patch.
> "-get file -" does not work
> ---------------------------
>
> Key: HADOOP-3175
> URL: https://issues.apache.org/jira/browse/HADOOP-3175
> Project: Hadoop Core
> Issue Type: Bug
> Components: fs
> Affects Versions: 0.17.0
> Reporter: Raghu Angadi
> Assignee: Edward J. Yoon
> Priority: Blocker
> Fix For: 0.17.0
>
> Attachments: 3175.patch
>
>
> {noformat}
> $ bin/hadoop fs -get file - > /dev/null
> Usage: java FsShell -get [-ignoreCrc] [-crc] <src> <localdst>
> get: Illegal option -
> {noformat}
> In 0.16, it used to write 'file' to stdout.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-3175) "-get file -" does not work
Posted by "Edward J. Yoon (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-3175?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12586606#action_12586606 ]
Edward J. Yoon commented on HADOOP-3175:
----------------------------------------
Oh. It's my habit-forming namings.
> "-get file -" does not work
> ---------------------------
>
> Key: HADOOP-3175
> URL: https://issues.apache.org/jira/browse/HADOOP-3175
> Project: Hadoop Core
> Issue Type: Bug
> Components: fs
> Affects Versions: 0.17.0
> Reporter: Raghu Angadi
> Assignee: Edward J. Yoon
> Priority: Blocker
> Fix For: 0.17.0
>
> Attachments: 3175.patch
>
>
> {noformat}
> $ bin/hadoop fs -get file - > /dev/null
> Usage: java FsShell -get [-ignoreCrc] [-crc] <src> <localdst>
> get: Illegal option -
> {noformat}
> In 0.16, it used to write 'file' to stdout.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-3175) "-get file -" does not work
Posted by "Edward J. Yoon (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-3175?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Edward J. Yoon updated HADOOP-3175:
-----------------------------------
Status: Patch Available (was: Open)
Submitting.
> "-get file -" does not work
> ---------------------------
>
> Key: HADOOP-3175
> URL: https://issues.apache.org/jira/browse/HADOOP-3175
> Project: Hadoop Core
> Issue Type: Bug
> Components: fs
> Affects Versions: 0.17.0
> Reporter: Raghu Angadi
> Assignee: Edward J. Yoon
> Priority: Blocker
> Fix For: 0.17.0
>
> Attachments: 3175.patch
>
>
> {noformat}
> $ bin/hadoop fs -get file - > /dev/null
> Usage: java FsShell -get [-ignoreCrc] [-crc] <src> <localdst>
> get: Illegal option -
> {noformat}
> In 0.16, it used to write 'file' to stdout.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-3175) "-get file -" does not work
Posted by "Edward J. Yoon (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-3175?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Edward J. Yoon updated HADOOP-3175:
-----------------------------------
Attachment: 3175_v01.patch
Please review this v01.patch.
> "-get file -" does not work
> ---------------------------
>
> Key: HADOOP-3175
> URL: https://issues.apache.org/jira/browse/HADOOP-3175
> Project: Hadoop Core
> Issue Type: Bug
> Components: fs
> Affects Versions: 0.17.0
> Reporter: Raghu Angadi
> Assignee: Edward J. Yoon
> Priority: Blocker
> Fix For: 0.17.0
>
> Attachments: 3175.patch, 3175_v01.patch
>
>
> {noformat}
> $ bin/hadoop fs -get file - > /dev/null
> Usage: java FsShell -get [-ignoreCrc] [-crc] <src> <localdst>
> get: Illegal option -
> {noformat}
> In 0.16, it used to write 'file' to stdout.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Issue Comment Edited: (HADOOP-3175) "-get file -" does not
work
Posted by "Raghu Angadi (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-3175?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12585809#action_12585809 ]
rangadi edited comment on HADOOP-3175 at 4/4/08 3:38 PM:
--------------------------------------------------------------
Thanks Edward for looking into this. I am setting the fix version to "0.17" since this is a very user visible problem.
was (Author: rangadi):
Thank Edward for looking into this. I am setting the fix version to "0.17" since this is a very user visible problem.
> "-get file -" does not work
> ---------------------------
>
> Key: HADOOP-3175
> URL: https://issues.apache.org/jira/browse/HADOOP-3175
> Project: Hadoop Core
> Issue Type: Bug
> Components: fs
> Affects Versions: 0.17.0
> Reporter: Raghu Angadi
> Assignee: Edward J. Yoon
> Fix For: 0.17.0
>
>
> {noformat}
> $ bin/hadoop fs -get file - > /dev/null
> Usage: java FsShell -get [-ignoreCrc] [-crc] <src> <localdst>
> get: Illegal option -
> {noformat}
> In 0.16, it used to write 'file' to stdout.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-3175) "-get file -" does not work
Posted by "Milind Bhandarkar (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-3175?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12587393#action_12587393 ]
Milind Bhandarkar commented on HADOOP-3175:
-------------------------------------------
Oops my mistake. Sorry for that.
> "-get file -" does not work
> ---------------------------
>
> Key: HADOOP-3175
> URL: https://issues.apache.org/jira/browse/HADOOP-3175
> Project: Hadoop Core
> Issue Type: Bug
> Components: fs
> Affects Versions: 0.17.0
> Reporter: Raghu Angadi
> Assignee: Edward J. Yoon
> Priority: Blocker
> Fix For: 0.17.0
>
> Attachments: 3175.patch, 3175_v01.patch, 3175_v02.patch
>
>
> {noformat}
> $ bin/hadoop fs -get file - > /dev/null
> Usage: java FsShell -get [-ignoreCrc] [-crc] <src> <localdst>
> get: Illegal option -
> {noformat}
> In 0.16, it used to write 'file' to stdout.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-3175) "-get file -" does not work
Posted by "Edward J. Yoon (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-3175?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12585814#action_12585814 ]
Edward J. Yoon commented on HADOOP-3175:
----------------------------------------
Yes, that's a good idea.
> "-get file -" does not work
> ---------------------------
>
> Key: HADOOP-3175
> URL: https://issues.apache.org/jira/browse/HADOOP-3175
> Project: Hadoop Core
> Issue Type: Bug
> Components: fs
> Affects Versions: 0.17.0
> Reporter: Raghu Angadi
> Assignee: Edward J. Yoon
> Fix For: 0.17.0
>
>
> {noformat}
> $ bin/hadoop fs -get file - > /dev/null
> Usage: java FsShell -get [-ignoreCrc] [-crc] <src> <localdst>
> get: Illegal option -
> {noformat}
> In 0.16, it used to write 'file' to stdout.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.