[GitHub] [geode] jdeppe-pivotal commented on pull request #5818: GEODE-8769: help ensure stats are settled before testing

[GitBox <gi...@apache.org>]

jdeppe-pivotal commented on pull request #5818:
URL: https://github.com/apache/geode/pull/5818#issuecomment-740291484


   I agree that this fix is probably not going to address the issue. It's more like the async nature of netty that's causing this. Since we do `jedis.close()` in the `after` call and then reset stats in the `before` the client count decrement 'event' might only happen after the stats are decremented. As it stands I think just `awaiting` for the client count to reach zero at the start of the before block should fix this issue.
   @dschneider-pivotal I'd be hesitant to remove the `reset` method. Because of the async nature of some of these stats it would still be an issue if you grabbed the 'current' value of a stat at the start of the test. (Perhaps it's only client connections that are affected by this).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org