You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@metron.apache.org by nickwallen <gi...@git.apache.org> on 2016/08/30 16:45:50 UTC

[GitHub] incubator-metron pull request #237: METRON-399 Stellar Date Functions Should...

GitHub user nickwallen opened a pull request:

    https://github.com/apache/incubator-metron/pull/237

    METRON-399 Stellar Date Functions Should Default to Current Time

    ### [METRON-399](https://issues.apache.org/jira/browse/METRON-399)
    
    The Stellar date functions expect an argument of a Long containing the epoch time in milliseconds.  If no argument is supplied, a parse exception is thrown.
    
    ```
    WEEK_OF_YEAR(timestamp)
    ```
    
    This should be changed so that if no argument is supplied, the function assumes the current time.
    
    ```
    WEEK_OF_YEAR()
    ```
    
    If an argument is passed that is not valid, the function should continue to return null.
    
    This updates the functioning of all date functions included in #231 .  


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/nickwallen/incubator-metron METRON-399

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-metron/pull/237.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #237
    
----
commit 388b11d2907f47dd66cecc73621309db772360b7
Author: Nick Allen <ni...@nickallen.org>
Date:   2016-08-30T16:42:04Z

    METRON-399 Stellar Date Functions Should Default to Current Time

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-metron pull request #237: METRON-399 Stellar Date Functions Should...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/incubator-metron/pull/237


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-metron issue #237: METRON-399 Stellar Date Functions Should Defaul...

Posted by cestella <gi...@git.apache.org>.
Github user cestella commented on the issue:

    https://github.com/apache/incubator-metron/pull/237
  
    +1, good stuff


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---