You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/04/19 04:34:59 UTC

[GitHub] [flink] wolfboys opened a new pull request, #19511: [FLINK-27299][Runtime/Configuration] flink parsing parameter bug fixed.

wolfboys opened a new pull request, #19511:
URL: https://github.com/apache/flink/pull/19511

   
   
   ## What is the purpose of the change
   
   When I am running a flink job, I specify a running parameter with a "#" sign in it. The parsing fails.
   
   e.g: flink run com.myJob --sink.password db@123#123 
   
   only parse the content in front of "#", after reading the source code It is found that the parameters are intercepted according to "#" in the loadYAMLResource method of GlobalConfiguration. This part needs to be improved
   
   ## Brief change log
     -  before: `line.split("#", 2) ` after: `line.split("\\s+#", 2)` Following yaml's parameter parsing rules, the content after " #" ( space + #) is the real comment part, which should be discarded when parsing parameters
   
   ## Verifying this change
   
   This change is a trivial rework / code cleanup without any test coverage.
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): no
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no
     - The serializers: no
     - The runtime per-record code paths (performance sensitive): don't know
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
     - The S3 file system connector: no
   
   ## Documentation
   
     - Does this pull request introduce a new feature?  no
     - If yes, how is the feature documented?  not applicable
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] wolfboys commented on pull request #19511: [FLINK-27299][Runtime/Configuration] flink parsing parameter bug fixed.

Posted by GitBox <gi...@apache.org>.
wolfboys commented on PR #19511:
URL: https://github.com/apache/flink/pull/19511#issuecomment-1102849629

   @wuchong PTAL, thx.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] wolfboys commented on pull request #19511: [FLINK-27299][Runtime/Configuration] flink parsing parameter bug fixed.

Posted by GitBox <gi...@apache.org>.
wolfboys commented on PR #19511:
URL: https://github.com/apache/flink/pull/19511#issuecomment-1102848946

   > @wolfboys , the change looks good to me. However, it would be better to add a test for it, e.g. in the `GlobalConfigurationTest`.
   
   PTAL, thx


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] wuchong commented on pull request #19511: [FLINK-27299][Runtime/Configuration] flink parsing parameter bug fixed.

Posted by GitBox <gi...@apache.org>.
wuchong commented on PR #19511:
URL: https://github.com/apache/flink/pull/19511#issuecomment-1102010941

   @wolfboys , the change looks good to me. However, it would be better to add a test for it, e.g. in the `GlobalConfigurationTest`.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] wolfboys commented on pull request #19511: [FLINK-27299][Runtime/Configuration] flink parsing parameter bug fixed.

Posted by GitBox <gi...@apache.org>.
wolfboys commented on PR #19511:
URL: https://github.com/apache/flink/pull/19511#issuecomment-1102020291

   > 
   
   OK, I'll add testCases. 😁 thank you for your review.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] wolfboys closed pull request #19511: [FLINK-27299][Runtime/Configuration] flink parsing parameter bug fixed.

Posted by GitBox <gi...@apache.org>.
wolfboys closed pull request #19511: [FLINK-27299][Runtime/Configuration] flink parsing parameter bug fixed.
URL: https://github.com/apache/flink/pull/19511


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #19511: [FLINK-27299][Runtime/Configuration] flink parsing parameter bug fixed.

Posted by GitBox <gi...@apache.org>.
flinkbot commented on PR #19511:
URL: https://github.com/apache/flink/pull/19511#issuecomment-1102008061

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "06f23287f0507bf1f4159028a42f9f6c6a2b637d",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "06f23287f0507bf1f4159028a42f9f6c6a2b637d",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 06f23287f0507bf1f4159028a42f9f6c6a2b637d UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org