[GitHub] [arrow] andersonm-ibm commented on a change in pull request #10450: ARROW-9947: [Python] High-level Python API for Parquet encryption of files.

[GitBox <gi...@apache.org>]

andersonm-ibm commented on a change in pull request #10450:
URL: https://github.com/apache/arrow/pull/10450#discussion_r768763456



##########
File path: cpp/src/parquet/encryption/key_toolkit_internal.cc
##########
@@ -31,7 +31,8 @@ static constexpr const int32_t kAcceptableDataKeyLengths[] = {128, 192, 256};
 std::string EncryptKeyLocally(const std::string& key_bytes, const std::string& master_key,
                               const std::string& aad) {
   AesEncryptor key_encryptor(ParquetCipher::AES_GCM_V1,
-                             static_cast<int>(master_key.size()), false);
+                             static_cast<int>(master_key.size()), false,
+                             false /*write_length*/);

Review comment:
       This fixes an interoperability issue with Java/Spark.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org