You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@datafusion.apache.org by "mzabaluev (via GitHub)" <gi...@apache.org> on 2026/08/31 15:39:57 UTC
[PR] bench: `multi_group_by` cases to exercise `List` [datafusion]
mzabaluev opened a new pull request, #24824:
URL: https://github.com/apache/datafusion/pull/24824
Benchmark to accompany #23648.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] bench: `multi_group_by` cases to exercise `List` [datafusion]
Posted by "rluvaton (via GitHub)" <gi...@apache.org>.
rluvaton merged PR #24824:
URL: https://github.com/apache/datafusion/pull/24824
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] bench: `multi_group_by` cases to exercise `List` [datafusion]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #24824:
URL: https://github.com/apache/datafusion/pull/24824#issuecomment-5481075443
## [Codecov](https://app.codecov.io/gh/apache/datafusion/pull/24824?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 81.58%. Comparing base ([`5e168c9`](https://app.codecov.io/gh/apache/datafusion/commit/5e168c9d014433f9d34d42ae3c6defa770023942?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`ad79220`](https://app.codecov.io/gh/apache/datafusion/commit/ad79220c9bc940e215e3dc47d5b33f765057d2cc?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 1 commits behind head on main.
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## main #24824 +/- ##
==========================================
- Coverage 81.58% 81.58% -0.01%
==========================================
Files 1123 1123
Lines 406610 406610
Branches 406610 406610
==========================================
- Hits 331720 331714 -6
- Misses 55452 55455 +3
- Partials 19438 19441 +3
```
</details>
[:umbrella: View full report in Codecov by Harness](https://app.codecov.io/gh/apache/datafusion/pull/24824?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
- :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] bench: `multi_group_by` cases to exercise `List` [datafusion]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #24824:
URL: https://github.com/apache/datafusion/pull/24824#issuecomment-5494863955
<!-- semver-check-comment -->
Thank you for opening this pull request!
Reviewer note: [cargo-semver-checks](https://github.com/obi1kenobi/cargo-semver-checks) reported the current version number is not SemVer-compatible with the changes in this pull request (compared against the base branch).
<details>
<summary>Details</summary>
```
Cloning apache/main
Building datafusion-physical-plan v55.0.0 (current)
Built [ 38.976s] (current)
Parsing datafusion-physical-plan v55.0.0 (current)
Parsed [ 0.143s] (current)
Building datafusion-physical-plan v55.0.0 (baseline)
Built [ 37.727s] (baseline)
Parsing datafusion-physical-plan v55.0.0 (baseline)
Parsed [ 0.147s] (baseline)
Checking datafusion-physical-plan v55.0.0 -> v55.0.0 (no change; assume patch)
Checked [ 1.044s] 223 checks: 222 pass, 1 fail, 0 warn, 31 skip
--- failure trait_method_missing: pub trait method removed or renamed ---
Description:
A trait method is no longer callable, and may have been renamed or removed entirely.
ref: https://doc.rust-lang.org/cargo/reference/semver.html#trait-item-signature
impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.50.0/src/lints/trait_method_missing.ron
Failed in:
method values_preserving of trait GroupValues, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/db4e7abda50a83c18e0611c57f3e9fad08532d46/datafusion/physical-plan/src/aggregates/group_values/mod.rs:127
method supports_values_preserving of trait GroupValues, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/db4e7abda50a83c18e0611c57f3e9fad08532d46/datafusion/physical-plan/src/aggregates/group_values/mod.rs:135
method values_preserving of trait GroupColumn, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/db4e7abda50a83c18e0611c57f3e9fad08532d46/datafusion/physical-plan/src/aggregates/group_values/multi_group_by/mod.rs:114
Summary semver requires new major version: 1 major and 0 minor checks failed
Finished [ 80.684s] datafusion-physical-plan
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org