You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Gaurav Aradhye <ga...@clogeny.com> on 2014/07/31 16:58:48 UTC
Review Request 24154: CLOUDSTACK-7215: Make expunge=True as default
parameter value while calling destroyVirtualMachine through base library
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24154/
-----------------------------------------------------------
Review request for cloudstack and Santhosh Edukulla.
Bugs: CLOUDSTACK-7215
https://issues.apache.org/jira/browse/CLOUDSTACK-7215
Repository: cloudstack-git
Description
-------
In almost 90% of the scenarios where VMs are created through test case, VMs are added to cleanup list and the delete method is called for them through cleanup_resources method in utils.py file.
These VMs remain in destroyed state for long time and keep blocking the resources (IP Address etc) and hence the load on the setup on which regression build is fired increases.
Making expunge=True as default parameter in destroyVirtualMachine api call through base library will make all these VMs expunge quickly making resources available for next test cases.
Also, it can be passed as False whenever we don't want VM to expunge immediately, and in case when we recover the VM through test case after destroying it. Pass expunge=False for all such scenarios.
This will hugely boost the test cases execution speed too.
Diffs
-----
test/integration/component/test_advancedsg_networks.py 2794f96
test/integration/component/test_multiple_ips_per_nic.py 24b85df
test/integration/component/test_ps_domain_limits.py afb0955
test/integration/component/test_ps_limits.py 1993e93
test/integration/component/test_vpc_vm_life_cycle.py fd995cd
tools/marvin/marvin/lib/base.py 58033c6
Diff: https://reviews.apache.org/r/24154/diff/
Testing
-------
Yes.
Thanks,
Gaurav Aradhye
Re: Review Request 24154: CLOUDSTACK-7215: Make expunge=True as default
parameter value while calling destroyVirtualMachine through base library
Posted by Santhosh Edukulla <sa...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24154/#review49447
-----------------------------------------------------------
Ship it!
Ship It!
- Santhosh Edukulla
On July 31, 2014, 2:58 p.m., Gaurav Aradhye wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24154/
> -----------------------------------------------------------
>
> (Updated July 31, 2014, 2:58 p.m.)
>
>
> Review request for cloudstack and Santhosh Edukulla.
>
>
> Bugs: CLOUDSTACK-7215
> https://issues.apache.org/jira/browse/CLOUDSTACK-7215
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> In almost 90% of the scenarios where VMs are created through test case, VMs are added to cleanup list and the delete method is called for them through cleanup_resources method in utils.py file.
>
> These VMs remain in destroyed state for long time and keep blocking the resources (IP Address etc) and hence the load on the setup on which regression build is fired increases.
>
> Making expunge=True as default parameter in destroyVirtualMachine api call through base library will make all these VMs expunge quickly making resources available for next test cases.
>
> Also, it can be passed as False whenever we don't want VM to expunge immediately, and in case when we recover the VM through test case after destroying it. Pass expunge=False for all such scenarios.
>
> This will hugely boost the test cases execution speed too.
>
>
> Diffs
> -----
>
> test/integration/component/test_advancedsg_networks.py 2794f96
> test/integration/component/test_multiple_ips_per_nic.py 24b85df
> test/integration/component/test_ps_domain_limits.py afb0955
> test/integration/component/test_ps_limits.py 1993e93
> test/integration/component/test_vpc_vm_life_cycle.py fd995cd
> tools/marvin/marvin/lib/base.py 58033c6
>
> Diff: https://reviews.apache.org/r/24154/diff/
>
>
> Testing
> -------
>
> Yes.
>
>
> Thanks,
>
> Gaurav Aradhye
>
>
Re: Review Request 24154: CLOUDSTACK-7215: Make expunge=True as default
parameter value while calling destroyVirtualMachine through base library
Posted by Gaurav Aradhye <ga...@clogeny.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24154/#review49445
-----------------------------------------------------------
Hi Santhoshe, can you please review this?
- Gaurav Aradhye
On July 31, 2014, 8:28 p.m., Gaurav Aradhye wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24154/
> -----------------------------------------------------------
>
> (Updated July 31, 2014, 8:28 p.m.)
>
>
> Review request for cloudstack and Santhosh Edukulla.
>
>
> Bugs: CLOUDSTACK-7215
> https://issues.apache.org/jira/browse/CLOUDSTACK-7215
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> In almost 90% of the scenarios where VMs are created through test case, VMs are added to cleanup list and the delete method is called for them through cleanup_resources method in utils.py file.
>
> These VMs remain in destroyed state for long time and keep blocking the resources (IP Address etc) and hence the load on the setup on which regression build is fired increases.
>
> Making expunge=True as default parameter in destroyVirtualMachine api call through base library will make all these VMs expunge quickly making resources available for next test cases.
>
> Also, it can be passed as False whenever we don't want VM to expunge immediately, and in case when we recover the VM through test case after destroying it. Pass expunge=False for all such scenarios.
>
> This will hugely boost the test cases execution speed too.
>
>
> Diffs
> -----
>
> test/integration/component/test_advancedsg_networks.py 2794f96
> test/integration/component/test_multiple_ips_per_nic.py 24b85df
> test/integration/component/test_ps_domain_limits.py afb0955
> test/integration/component/test_ps_limits.py 1993e93
> test/integration/component/test_vpc_vm_life_cycle.py fd995cd
> tools/marvin/marvin/lib/base.py 58033c6
>
> Diff: https://reviews.apache.org/r/24154/diff/
>
>
> Testing
> -------
>
> Yes.
>
>
> Thanks,
>
> Gaurav Aradhye
>
>
Re: Review Request 24154: CLOUDSTACK-7215: Make expunge=True as default
parameter value while calling destroyVirtualMachine through base library
Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24154/#review49448
-----------------------------------------------------------
Commit c32b19a07d0eaa6dc0195ecf1aa9b952a91dc997 in cloudstack's branch refs/heads/master from Gaurav Aradhye
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=c32b19a ]
CLOUDSTACK-7215: Make expunge=True as default parameter value while calling destroyVirtualMachine through base library
Signed-off-by: Santhosh Edukulla <sa...@gmail.com>
- ASF Subversion and Git Services
On July 31, 2014, 2:58 p.m., Gaurav Aradhye wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24154/
> -----------------------------------------------------------
>
> (Updated July 31, 2014, 2:58 p.m.)
>
>
> Review request for cloudstack and Santhosh Edukulla.
>
>
> Bugs: CLOUDSTACK-7215
> https://issues.apache.org/jira/browse/CLOUDSTACK-7215
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> In almost 90% of the scenarios where VMs are created through test case, VMs are added to cleanup list and the delete method is called for them through cleanup_resources method in utils.py file.
>
> These VMs remain in destroyed state for long time and keep blocking the resources (IP Address etc) and hence the load on the setup on which regression build is fired increases.
>
> Making expunge=True as default parameter in destroyVirtualMachine api call through base library will make all these VMs expunge quickly making resources available for next test cases.
>
> Also, it can be passed as False whenever we don't want VM to expunge immediately, and in case when we recover the VM through test case after destroying it. Pass expunge=False for all such scenarios.
>
> This will hugely boost the test cases execution speed too.
>
>
> Diffs
> -----
>
> test/integration/component/test_advancedsg_networks.py 2794f96
> test/integration/component/test_multiple_ips_per_nic.py 24b85df
> test/integration/component/test_ps_domain_limits.py afb0955
> test/integration/component/test_ps_limits.py 1993e93
> test/integration/component/test_vpc_vm_life_cycle.py fd995cd
> tools/marvin/marvin/lib/base.py 58033c6
>
> Diff: https://reviews.apache.org/r/24154/diff/
>
>
> Testing
> -------
>
> Yes.
>
>
> Thanks,
>
> Gaurav Aradhye
>
>