You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@mynewt.apache.org by "sjanc (via GitHub)" <gi...@apache.org> on 2025/08/06 10:46:55 UTC
[PR] nimble: Use BLE_NPL_TIME_FOREVER for ble_npl_mutex_pend timeout [mynewt-nimble]
sjanc opened a new pull request, #2102:
URL: https://github.com/apache/mynewt-nimble/pull/2102
If no timeout is required we should use BLE_NPL_TIME_FOREVER when locking.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@mynewt.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] nimble: Use BLE_NPL_TIME_FOREVER for ble_npl_mutex_pend timeout [mynewt-nimble]
Posted by "github-advanced-security[bot] (via GitHub)" <gi...@apache.org>.
github-advanced-security[bot] commented on code in PR #2102:
URL: https://github.com/apache/mynewt-nimble/pull/2102#discussion_r2256769148
##########
nimble/host/src/ble_gap.c:
##########
@@ -6965,7 +6965,7 @@
disc_preempted = 0;
/* Protects slaves from accessing by multiple threads */
- ble_npl_mutex_pend(&preempt_done_mutex, 0xFFFFFFFF);
+ ble_npl_mutex_pend(&preempt_done_mutex, BLE_NPL_TIME_FOREVER);
Review Comment:
## Expression has no effect
This expression has no effect (because [ble_npl_mutex_pend](1) has no external side effects).
[Show more details](https://github.com/apache/mynewt-nimble/security/code-scanning/135)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@mynewt.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] nimble: Use BLE_NPL_TIME_FOREVER for ble_npl_mutex_pend timeout [mynewt-nimble]
Posted by "sjanc (via GitHub)" <gi...@apache.org>.
sjanc merged PR #2102:
URL: https://github.com/apache/mynewt-nimble/pull/2102
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@mynewt.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org