You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by GitBox <gi...@apache.org> on 2020/06/02 21:08:10 UTC
[GitHub] [qpid-dispatch] bhardesty opened a new pull request #752: NO-JIRA: Fix broken xref in qpid dispatch book
bhardesty opened a new pull request #752:
URL: https://github.com/apache/qpid-dispatch/pull/752
In https://qpid.apache.org/releases/qpid-dispatch-1.12.0/user-guide/index.html#creating-vhost-policies-qdr, the xref to the Address patterns section was broken (see the "sources | sourcePatterns" line). This is due to a known Asciidoctor issue with multiple xrefs in a single line. This PR works around the issue by adding a line break (which still maintains the correct pagination in the output).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[GitHub] [qpid-dispatch] pwright commented on pull request #752: NO-JIRA: Fix broken xref in qpid dispatch book
Posted by GitBox <gi...@apache.org>.
pwright commented on pull request #752:
URL: https://github.com/apache/qpid-dispatch/pull/752#issuecomment-638139294
@bhardesty I've created https://github.com/apache/qpid-dispatch/pull/753 and included your commit
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[GitHub] [qpid-dispatch] bhardesty commented on pull request #752: NO-JIRA: Fix broken xref in qpid dispatch book
Posted by GitBox <gi...@apache.org>.
bhardesty commented on pull request #752:
URL: https://github.com/apache/qpid-dispatch/pull/752#issuecomment-638270875
Fix included in PR 753.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[GitHub] [qpid-dispatch] codecov-commenter commented on pull request #752: NO-JIRA: Fix broken xref in qpid dispatch book
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #752:
URL: https://github.com/apache/qpid-dispatch/pull/752#issuecomment-637831068
# [Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/752?src=pr&el=h1) Report
> Merging [#752](https://codecov.io/gh/apache/qpid-dispatch/pull/752?src=pr&el=desc) into [master](https://codecov.io/gh/apache/qpid-dispatch/commit/ee82acda5656ca0b5bb6ef86b9869f9ecfac1559&el=desc) will **increase** coverage by `0.01%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/qpid-dispatch/pull/752?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #752 +/- ##
==========================================
+ Coverage 86.60% 86.62% +0.01%
==========================================
Files 96 96
Lines 21936 21936
==========================================
+ Hits 18998 19002 +4
+ Misses 2938 2934 -4
```
| [Impacted Files](https://codecov.io/gh/apache/qpid-dispatch/pull/752?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [src/router\_core/core\_client\_api.c](https://codecov.io/gh/apache/qpid-dispatch/pull/752/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL2NvcmVfY2xpZW50X2FwaS5j) | `91.41% <0.00%> (-0.38%)` | :arrow_down: |
| [src/router\_core/delivery.c](https://codecov.io/gh/apache/qpid-dispatch/pull/752/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL2RlbGl2ZXJ5LmM=) | `90.90% <0.00%> (+0.18%)` | :arrow_up: |
| [src/iterator.c](https://codecov.io/gh/apache/qpid-dispatch/pull/752/diff?src=pr&el=tree#diff-c3JjL2l0ZXJhdG9yLmM=) | `89.36% <0.00%> (+0.18%)` | :arrow_up: |
| [src/router\_core/transfer.c](https://codecov.io/gh/apache/qpid-dispatch/pull/752/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL3RyYW5zZmVyLmM=) | `93.75% <0.00%> (+0.24%)` | :arrow_up: |
| [src/router\_core/route\_tables.c](https://codecov.io/gh/apache/qpid-dispatch/pull/752/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL3JvdXRlX3RhYmxlcy5j) | `80.69% <0.00%> (+0.57%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/752?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/752?src=pr&el=footer). Last update [ee82acd...7b65eb5](https://codecov.io/gh/apache/qpid-dispatch/pull/752?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[GitHub] [qpid-dispatch] bhardesty closed pull request #752: NO-JIRA: Fix broken xref in qpid dispatch book
Posted by GitBox <gi...@apache.org>.
bhardesty closed pull request #752:
URL: https://github.com/apache/qpid-dispatch/pull/752
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org