You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@submarine.apache.org by GitBox <gi...@apache.org> on 2022/07/13 04:44:45 UTC
[GitHub] [submarine] joshvictor1024 opened a new pull request, #978: Submarine 1292
joshvictor1024 opened a new pull request, #978:
URL: https://github.com/apache/submarine/pull/978
### What is this PR for?
<!-- A few sentences describing the overall goals of the pull request's commits.
First time? Check out the contributing guide - https://submarine.apache.org/contribution/contributions.html
-->
Add end-to-end test to submarine-cloud-v3
### What type of PR is it?
Feature
### Todos
* [x] - prepare to run in-cluster
* [x] - write e2e test and add to Github Action
* [x] - add new development doc
### What is the Jira issue?
<!-- * Open an issue on Jira https://issues.apache.org/jira/browse/SUBMARINE/
* Put link here, and add [SUBMARINE-*Jira number*] in PR title, eg. `SUBMARINE-23. PR title`
-->
https://issues.apache.org/jira/browse/SUBMARINE-1292
### How should this be tested?
<!--
* First time? Setup Travis CI as described on https://submarine.apache.org/contribution/contributions.html#continuous-integration
* Strongly recommended: add automated unit tests for any new or changed behavior
* Outline any manual steps to test the PR here.
-->
Follow `submarine-cloud-v3/docs/developer-guide.md`
### Screenshots (if appropriate)
### Questions:
* Do the license files need updating? No
* Are there breaking changes for older versions? No
* Does this need new documentation? Yes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@submarine.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [submarine] cdmikechen commented on pull request #978: Submarine 1292
Posted by GitBox <gi...@apache.org>.
cdmikechen commented on PR #978:
URL: https://github.com/apache/submarine/pull/978#issuecomment-1183220280
```dockerfile
# manager is run as non-root user
# See submarine-cloud-v3/config/manager/manager.yaml
RUN addgroup -g 1000 -S mygroup
RUN adduser -u 1000 -S myuser -G mygroup
USER myuser
```
I think we can change `mygroup` and `myuser` to `submarine`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@submarine.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [submarine] codecov[bot] commented on pull request #978: Submarine 1292
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on PR #978:
URL: https://github.com/apache/submarine/pull/978#issuecomment-1182773059
# [Codecov](https://codecov.io/gh/apache/submarine/pull/978?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#978](https://codecov.io/gh/apache/submarine/pull/978?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (35a7c9d) into [master](https://codecov.io/gh/apache/submarine/commit/e7ed4a5b182a7cc3cad32f406a8327e6c788d966?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (e7ed4a5) will **not change** coverage.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## master #978 +/- ##
========================================
Coverage 9.18% 9.18%
Complexity 670 670
========================================
Files 234 234
Lines 23716 23716
Branches 3475 3475
========================================
Hits 2178 2178
Misses 21407 21407
Partials 131 131
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/submarine/pull/978?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/submarine/pull/978?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [e7ed4a5...35a7c9d](https://codecov.io/gh/apache/submarine/pull/978?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@submarine.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [submarine] joshvictor1024 commented on pull request #978: SUBMARINE-1292. Submarine-cloud-v3 e2e test
Posted by GitBox <gi...@apache.org>.
joshvictor1024 commented on PR #978:
URL: https://github.com/apache/submarine/pull/978#issuecomment-1183836245
> Hi, @joshvictor1024 thank you for your contribution~ Maybe we can change PR title to [SUBMARINE-1292](https://issues.apache.org/jira/browse/SUBMARINE-1292). Add submarine-cloud-v3 e2e test ?
Sorry, forgot about title format. Fixed.
> ```dockerfile
> # manager is run as non-root user
> # See submarine-cloud-v3/config/manager/manager.yaml
> RUN addgroup -g 1000 -S mygroup
> RUN adduser -u 1000 -S myuser -G mygroup
> USER myuser
> ```
>
> I think we can change `mygroup` and `myuser` to `submarine`
Good point, thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@submarine.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [submarine] cdmikechen commented on pull request #978: Submarine 1292
Posted by GitBox <gi...@apache.org>.
cdmikechen commented on PR #978:
URL: https://github.com/apache/submarine/pull/978#issuecomment-1183216866
hi, @joshvictor1024
Maybe we can change PR title to SUBMARINE-1292. Add submarine-cloud-v3 e2e test ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@submarine.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [submarine] asfgit closed pull request #978: SUBMARINE-1292. Add submarine-cloud-v3 e2e test
Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #978: SUBMARINE-1292. Add submarine-cloud-v3 e2e test
URL: https://github.com/apache/submarine/pull/978
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@submarine.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org