You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shenyu.apache.org by "sachin10fi (via GitHub)" <gi...@apache.org> on 2023/04/09 20:06:31 UTC
[GitHub] [shenyu] sachin10fi opened a new pull request, #4541: [ISSUE #4539] Added Enum Test Cases #4539
sachin10fi opened a new pull request, #4541:
URL: https://github.com/apache/shenyu/pull/4541
<!-- Describe your PR here; eg. Fixes #issueNo -->
<!--
Thank you for proposing a pull request. This template will guide you through the essential steps necessary for a pull request.
-->
Make sure that:
- [ ] You have read the [contribution guidelines](https://shenyu.apache.org/community/contributor-guide).
- [ ] You submit test cases (unit or integration tests) that back your changes.
- [ ] Your local test passed `./mvnw clean install -Dmaven.javadoc.skip=true`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shenyu] moremind commented on pull request #4541: [ISSUE #4539] Added enum test cases for common
Posted by "moremind (via GitHub)" <gi...@apache.org>.
moremind commented on PR #4541:
URL: https://github.com/apache/shenyu/pull/4541#issuecomment-1504537040
> pls add my wechat:yijia1949
@sachin10fi
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shenyu] li-keguo merged pull request #4541: [ISSUE #4539] Added enum test cases for common
Posted by "li-keguo (via GitHub)" <gi...@apache.org>.
li-keguo merged PR #4541:
URL: https://github.com/apache/shenyu/pull/4541
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shenyu] sachin10fi commented on pull request #4541: [ISSUE #4539] Added enum test cases for common
Posted by "sachin10fi (via GitHub)" <gi...@apache.org>.
sachin10fi commented on PR #4541:
URL: https://github.com/apache/shenyu/pull/4541#issuecomment-1501805218
> > @moremind Hello, common.cache.MemorySafeWindowTinyLFUMapTest.testWindowTinyLFU UT is failing in the build for some reason, I didn't make any changes to that file and it is passing in local
>
> Sorry, I have rerun the action
np, Thank You
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shenyu] moremind commented on pull request #4541: [ISSUE #4539] Added enum test cases for common
Posted by "moremind (via GitHub)" <gi...@apache.org>.
moremind commented on PR #4541:
URL: https://github.com/apache/shenyu/pull/4541#issuecomment-1501776871
> @moremind Hello, common.cache.MemorySafeWindowTinyLFUMapTest.testWindowTinyLFU UT is failing in the build for some reason, I didn't make any changes to that file and it is passing in local
Sorry, I have rerun the action
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shenyu] codecov-commenter commented on pull request #4541: [ISSUE #4539] Added enum test cases for common
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #4541:
URL: https://github.com/apache/shenyu/pull/4541#issuecomment-1501794073
## [Codecov](https://codecov.io/gh/apache/shenyu/pull/4541?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#4541](https://codecov.io/gh/apache/shenyu/pull/4541?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (5b4d61e) into [master](https://codecov.io/gh/apache/shenyu/commit/884cff0e0983ddc5e8a5b399adec17fe11dbc7f1?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (884cff0) will **increase** coverage by `0.08%`.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## master #4541 +/- ##
============================================
+ Coverage 68.26% 68.35% +0.08%
- Complexity 7642 7659 +17
============================================
Files 1033 1033
Lines 29575 29564 -11
Branches 2673 2669 -4
============================================
+ Hits 20189 20207 +18
+ Misses 7796 7767 -29
Partials 1590 1590
```
[see 20 files with indirect coverage changes](https://codecov.io/gh/apache/shenyu/pull/4541/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shenyu] sachin10fi commented on pull request #4541: [ISSUE #4539] Added enum test cases for common
Posted by "sachin10fi (via GitHub)" <gi...@apache.org>.
sachin10fi commented on PR #4541:
URL: https://github.com/apache/shenyu/pull/4541#issuecomment-1501773849
@moremind Hello, common.cache.MemorySafeWindowTinyLFUMapTest.testWindowTinyLFU UT is failing in the build for some reason, I didn't make any changes to that file and it is passing in local
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shenyu] moremind commented on pull request #4541: [ISSUE #4539] Added enum test cases for common
Posted by "moremind (via GitHub)" <gi...@apache.org>.
moremind commented on PR #4541:
URL: https://github.com/apache/shenyu/pull/4541#issuecomment-1504495780
pls add my wechat:yijia1949
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org