You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/08/27 05:44:47 UTC

[GitHub] [shardingsphere-elasticjob] TeslaCN opened a new issue #1422: The property Content-Type of HTTP job only works with x-www-form-urlencode

TeslaCN opened a new issue #1422:
URL: https://github.com/apache/shardingsphere-elasticjob/issues/1422


   https://github.com/apache/shardingsphere-elasticjob/blob/a8573f5beb089d8061ed5154659078893f6517b8/elasticjob-executor/elasticjob-executor-type/elasticjob-http-executor/src/main/java/org/apache/shardingsphere/elasticjob/http/executor/HttpJobExecutor.java#L64-L69
   
   I have some ideas:
   1. The shardingContext is been serialized as key-value format. It is incompatiable with request body in JSON format.
   What's more, I think the scenarios of HTTP job is biased to Restful API. 
   2. Why doesn't pass the sharding context if the data is empty? Maybe we can attach sharding context to query when using GET method.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere-elasticjob] Technoboy- removed a comment on issue #1422: The property Content-Type of HTTP job only works with x-www-form-urlencode

Posted by GitBox <gi...@apache.org>.
Technoboy- removed a comment on issue #1422:
URL: https://github.com/apache/shardingsphere-elasticjob/issues/1422#issuecomment-681621560


   Yes, really. We just support the basic type and method right now. 
   We can refactor this component by HttpClient.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere-elasticjob] Technoboy- commented on issue #1422: The property Content-Type of HTTP job only works with x-www-form-urlencode

Posted by GitBox <gi...@apache.org>.
Technoboy- commented on issue #1422:
URL: https://github.com/apache/shardingsphere-elasticjob/issues/1422#issuecomment-681621560


   Yes, really. We just support the basic type and method right now. 
   We can refactor this component by HttpClient.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere-elasticjob] Technoboy- closed issue #1422: The property Content-Type of HTTP job only works with x-www-form-urlencode

Posted by GitBox <gi...@apache.org>.
Technoboy- closed issue #1422:
URL: https://github.com/apache/shardingsphere-elasticjob/issues/1422


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere-elasticjob] Technoboy- commented on issue #1422: The property Content-Type of HTTP job only works with x-www-form-urlencode

Posted by GitBox <gi...@apache.org>.
Technoboy- commented on issue #1422:
URL: https://github.com/apache/shardingsphere-elasticjob/issues/1422#issuecomment-683371567


   We can set shardingContext as a Header key, so that we can resolve this issue easily and no need to refactor by HttpClient.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org