You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kie.apache.org by "ricardozanini (via GitHub)" <gi...@apache.org> on 2024/05/17 18:55:47 UTC
[PR] Fix kie-issues #1236 - Replace quay.io with docker.io, review version.go [incubator-kie-kogito-serverless-operator]
ricardozanini opened a new pull request, #466:
URL: https://github.com/apache/incubator-kie-kogito-serverless-operator/pull/466
<!--
Welcome to the SonataFlow Operator! Before contributing, make sure to:
- Rebase your branch on the latest upstream main
- Link any relevant issues, PR's, or documentation
- Check that the commit message is concise and helpful:
- When fixing an issue, add "Closes #<ISSUE_NUMBER>"
- Follow the below checklist
-->
**Description of the change:**
Fixes https://github.com/apache/incubator-kie-issues/issues/1236
**Motivation for the change:**
We need to realign the images with docker.io in order to release under Apache.
**Checklist**
- [ ] Add or Modify a unit test for your change
- [ ] Have you verified that tall the tests are passing?
<details>
<summary>
How to backport a pull request to a different branch?
</summary>
In order to automatically create a **backporting pull request** please add one or more labels having the following format `backport-<branch-name>`, where `<branch-name>` is the name of the branch where the pull request must be backported to (e.g., `backport-7.67.x` to backport the original PR to the `7.67.x` branch).
> **NOTE**: **backporting** is an action aiming to move a change (usually a commit) from a branch (usually the main one) to another one, which is generally referring to a still maintained release branch. Keeping it simple: it is about to move a specific change or a set of them from one branch to another.
Once the original pull request is successfully merged, the automated action will create one backporting pull request per each label (with the previous format) that has been added.
If something goes wrong, the author will be notified and at this point a manual backporting is needed.
> **NOTE**: this automated backporting is triggered whenever a pull request on `main` branch is labeled or closed, but both conditions must be satisfied to get the new PR created.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] Fix kie-issues #1236 - Replace quay.io with docker.io, review version.go [incubator-kie-kogito-serverless-operator]
Posted by "ricardozanini (via GitHub)" <gi...@apache.org>.
ricardozanini commented on PR #466:
URL: https://github.com/apache/incubator-kie-kogito-serverless-operator/pull/466#issuecomment-2127397603
@thiagoelg thanks! It worked: https://github.com/apache/incubator-kie-kogito-serverless-operator/pull/469
I'm gonna rebase it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] Fix kie-issues #1236 - Replace quay.io with docker.io, review version.go [incubator-kie-kogito-serverless-operator]
Posted by "ricardozanini (via GitHub)" <gi...@apache.org>.
ricardozanini commented on PR #466:
URL: https://github.com/apache/incubator-kie-kogito-serverless-operator/pull/466#issuecomment-2118208352
@tiagobento @thiagoelg fyi
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] Fix kie-issues #1236 - Replace quay.io with docker.io, review version.go [incubator-kie-kogito-serverless-operator]
Posted by "ricardozanini (via GitHub)" <gi...@apache.org>.
ricardozanini commented on PR #466:
URL: https://github.com/apache/incubator-kie-kogito-serverless-operator/pull/466#issuecomment-2118257184
@jstastny-cz I think we need to align the Jenkins CI part, since the weekly I guess we will publish the `main` tag, right? And the release, the `operatorVersion`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] Fix kie-issues #1236 - Replace quay.io with docker.io, review version.go [incubator-kie-kogito-serverless-operator]
Posted by "ricardozanini (via GitHub)" <gi...@apache.org>.
ricardozanini commented on PR #466:
URL: https://github.com/apache/incubator-kie-kogito-serverless-operator/pull/466#issuecomment-2125764816
@thiagoelg please remove the request for changes
e2e is failing duo to the images renaming
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] Fix kie-issues #1236 - Replace quay.io with docker.io, review version.go [incubator-kie-kogito-serverless-operator]
Posted by "thiagoelg (via GitHub)" <gi...@apache.org>.
thiagoelg commented on PR #466:
URL: https://github.com/apache/incubator-kie-kogito-serverless-operator/pull/466#issuecomment-2125837334
> @thiagoelg please remove the request for changes
>
> e2e is failing duo to the images renaming
It seems that it's failing with a similar error we got on kie-tools, this change might fix it: https://github.com/apache/incubator-kie-tools/pull/2347
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] Fix kie-issues #1236 - Replace quay.io with docker.io, review version.go [incubator-kie-kogito-serverless-operator]
Posted by "rodrigonull (via GitHub)" <gi...@apache.org>.
rodrigonull commented on PR #466:
URL: https://github.com/apache/incubator-kie-kogito-serverless-operator/pull/466#issuecomment-2180586454
@ricardozanini can we merge this PR? We need to merge this one and the https://github.com/apache/incubator-kie-kogito-serverless-operator/pull/494 to unblock the seed jobs on Apache Jenkins
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] Fix kie-issues #1236 - Replace quay.io with docker.io, review version.go [incubator-kie-kogito-serverless-operator]
Posted by "thiagoelg (via GitHub)" <gi...@apache.org>.
thiagoelg commented on code in PR #466:
URL: https://github.com/apache/incubator-kie-kogito-serverless-operator/pull/466#discussion_r1606891264
##########
config/manifests/bases/sonataflow-operator.clusterserviceversion.yaml:
##########
@@ -5,7 +5,7 @@ metadata:
alm-examples: '[]'
capabilities: Basic Install
categories: Application Runtime
- containerImage: quay.io/kiegroup/kogito-serverless-operator-nightly:latest
+ containerImage: qdocker.io/apache/incubator-kie-sonataflow-operator:main
Review Comment:
```suggestion
containerImage: docker.io/apache/incubator-kie-sonataflow-operator:main
```
Small typo
##########
container-builder/examples/dockerfiles/SonataFlow.dockerfile:
##########
@@ -15,7 +15,7 @@
# specific language governing permissions and limitations
# under the License.
-FROM quay.io/kiegroup/kogito-swf-builder-nightly:latest AS builder
+FROM ocker.io/apache/incubator-kie-sonataflow-builder:main AS builder
Review Comment:
```suggestion
FROM docker.io/apache/incubator-kie-sonataflow-builder:main AS builder
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org