You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/12/07 19:36:05 UTC
[GitHub] [arrow-datafusion] alamb opened a new pull request, #4546: minor: Remove more clones from the planner @alamb
alamb opened a new pull request, #4546:
URL: https://github.com/apache/arrow-datafusion/pull/4546
Draft as it builds on https://github.com/apache/arrow-datafusion/pull/4534
# Which issue does this PR close?
N/A
# Rationale for this change
Less cloning is better
# What changes are included in this PR?
Allow `subquery_alias` and `subquery_alias_owned` to take an existing `String` rather than always copying it
# Are these changes tested?
Covered by existing tests
# Are there any user-facing changes?
No
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] ursabot commented on pull request #4546: minor: Remove more clones from the planner
Posted by GitBox <gi...@apache.org>.
ursabot commented on PR #4546:
URL: https://github.com/apache/arrow-datafusion/pull/4546#issuecomment-1348984580
Benchmark runs are scheduled for baseline = 0de7d819f5f598ab7606a111ac8b578aeb1cb967 and contender = 1ddcafeb305b17d6932e215bd3a4c1b599c1c536. 1ddcafeb305b17d6932e215bd3a4c1b599c1c536 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on ec2-t3-xlarge-us-east-2] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/feb5cd2244584fe5ab51c1f1a920ff22...bedd76d7e1874f5c8bfe24b6c66ce74b/)
[Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on test-mac-arm] [test-mac-arm](https://conbench.ursa.dev/compare/runs/318ccc98504b440a8ab89fa1dc537141...20b98c49e16d47299d90658a16682ded/)
[Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on ursa-i9-9960x] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/e97c016833f34ae4a0706957d864229d...6bb250c33bdc46cbb844c7b153732173/)
[Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on ursa-thinkcentre-m75q] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/2d284795713a499386bfa4a3f2a7e0f2...75b2e36c951446cbb56db21b489195af/)
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb merged pull request #4546: minor: Remove more clones from the planner
Posted by GitBox <gi...@apache.org>.
alamb merged PR #4546:
URL: https://github.com/apache/arrow-datafusion/pull/4546
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb commented on a diff in pull request #4546: minor: Remove more clones from the planner
Posted by GitBox <gi...@apache.org>.
alamb commented on code in PR #4546:
URL: https://github.com/apache/arrow-datafusion/pull/4546#discussion_r1046044588
##########
datafusion/common/src/column.rs:
##########
@@ -70,7 +71,7 @@ impl Column {
// name
Column {
relation: None,
- name: String::from(flat_name),
+ name: flat_name,
Review Comment:
This would always clone previously, and now it allows the caller to pass in a `String` if they have one and avoid the `clone`
##########
datafusion/expr/src/expr_fn.rs:
##########
@@ -25,11 +25,17 @@ use crate::{
ScalarFunctionImplementation, ScalarUDF, Signature, StateTypeFunction, Volatility,
};
use arrow::datatypes::DataType;
-use datafusion_common::Result;
+use datafusion_common::{Column, Result};
use std::sync::Arc;
/// Create a column expression based on a qualified or unqualified column name
-pub fn col(ident: &str) -> Expr {
+///
+/// example:
Review Comment:
This is demonstrating you can still call `col` with a `&str` but now also with a `String` or `&String` to allow backwards compatibility as well as reuse
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org