[GitHub] [nutch] sebastian-nagel commented on a change in pull request #569: NUTCH-2849 Replace remaining package.html files with package-info.java

[GitBox <gi...@apache.org>]

sebastian-nagel commented on a change in pull request #569:
URL: https://github.com/apache/nutch/pull/569#discussion_r576824015



##########
File path: build.xml
##########
@@ -186,6 +186,7 @@
       doctitle="${name} ${version} API"
       bottom="Copyright © ${year} The Apache Software Foundation"
       failonerror="true"
+      failonwarning="true"

Review comment:
       Observed two warnings when running `ant clean javadoc` (which made the build to fail):
   ``` 
     [javadoc] .../src/java/org/apache/nutch/protocol/RobotRulesParser.java:58: warning - Tag @link: reference not found: getRobotRulesSet
     [javadoc] .../src/plugin/indexer-elastic/src/java/org/apache/nutch/indexwriter/elastic/ElasticIndexWriter.java:204: warning - Tag @link: reference not found: BulkProcessor.Listener
     ...
     [javadoc] 2 warnings
   
   BUILD FAILED
   .../build.xml:723: Javadoc issued warnings.
   ```

##########
File path: build.xml
##########
@@ -809,6 +811,7 @@
       <classpath>
         <fileset dir="${build.plugins}" >
           <include name="**/*.jar"/>
+          <exclude name="any23/javax.annotation-api*.jar"/>

Review comment:
       Ok. Nice, this solves the remaining "Multiple sources of package comments found" warning (see #568).




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org