You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by "Abacn (via GitHub)" <gi...@apache.org> on 2025/04/01 15:53:18 UTC
[PR] Bump GoogleAdsIO to v19 [beam]
Abacn opened a new pull request, #34497:
URL: https://github.com/apache/beam/pull/34497
In preparation for Beam 2.65.0. GoogleAdsv17 is set to sunset on June 4, 2025: https://developers.google.com/google-ads/api/docs/sunset-dates
* Make pipeline source code using GoogleAdsIO backward compatible
* Move GoogleAds dependencies outside of BeamModulePlugin since only one module using it
**Please** add a meaningful description for your change here
------------------------
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment `fixes #<ISSUE NUMBER>` instead.
- [ ] Update `CHANGES.md` with noteworthy changes.
- [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://github.com/apache/beam/blob/master/CONTRIBUTING.md#make-the-reviewers-job-easier).
To check the build health, please visit [https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
GitHub Actions Tests Status (on master branch)
------------------------------------------------------------------------------------------------
[](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Go+tests%22+branch%3Amaster+event%3Aschedule)
See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI or the [workflows README](https://github.com/apache/beam/blob/master/.github/workflows/README.md) to see a list of phrases to trigger workflows.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Bump GoogleAdsIO to v19 [beam]
Posted by "Abacn (via GitHub)" <gi...@apache.org>.
Abacn commented on code in PR #34497:
URL: https://github.com/apache/beam/pull/34497#discussion_r2025216360
##########
sdks/java/io/google-ads/src/main/java/org/apache/beam/sdk/io/googleads/GoogleAdsIO.java:
##########
@@ -17,17 +17,84 @@
*/
package org.apache.beam.sdk.io.googleads;
+import com.google.protobuf.Message;
+import java.io.Serializable;
+import org.apache.beam.sdk.transforms.PTransform;
+import org.apache.beam.sdk.values.PCollection;
+import org.checkerframework.checker.nullness.qual.Nullable;
+
/**
* {@link GoogleAdsIO} provides an API for reading from the <a
* href="https://developers.google.com/google-ads/api/docs/start">Google Ads API</a> over supported
* versions of the Google Ads client libraries.
*
- * @see GoogleAdsV17
+ * @see GoogleAdsV19
*/
-public class GoogleAdsIO {
- private GoogleAdsIO() {}
+public abstract class GoogleAdsIO<GoogleAdsRowT, SearchGoogleAdsStreamRequestT> {
+
+ @SuppressWarnings(
+ "TypeParameterUnusedInFormals") // for source code backward compatible when underlying API
+ // version changed
+ public abstract <T extends PTransform<PCollection<String>, PCollection<GoogleAdsRowT>>> T read();
+
+ @SuppressWarnings(
+ "TypeParameterUnusedInFormals") // for source code backward compatible when underlying API
+ // version changed
+ public abstract <
+ T extends
+ PTransform<PCollection<SearchGoogleAdsStreamRequestT>, PCollection<GoogleAdsRowT>>>
+ T readAll();
+
+ public static GoogleAdsV19 current() {
Review Comment:
Then code snippet
```
GoogleAdsIO.current().readAll().withXXX()
```
would not compile.
This change just make pipeline source code compatible with future google-ads version bump, but the underlying return type still changed every time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Bump GoogleAdsIO to v19 [beam]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #34497:
URL: https://github.com/apache/beam/pull/34497#issuecomment-2769953348
Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment `assign set of reviewers`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Bump GoogleAdsIO to v19 [beam]
Posted by "ahmedabu98 (via GitHub)" <gi...@apache.org>.
ahmedabu98 commented on code in PR #34497:
URL: https://github.com/apache/beam/pull/34497#discussion_r2025192711
##########
sdks/java/io/google-ads/src/main/java/org/apache/beam/sdk/io/googleads/GoogleAdsIO.java:
##########
@@ -17,17 +17,84 @@
*/
package org.apache.beam.sdk.io.googleads;
+import com.google.protobuf.Message;
+import java.io.Serializable;
+import org.apache.beam.sdk.transforms.PTransform;
+import org.apache.beam.sdk.values.PCollection;
+import org.checkerframework.checker.nullness.qual.Nullable;
+
/**
* {@link GoogleAdsIO} provides an API for reading from the <a
* href="https://developers.google.com/google-ads/api/docs/start">Google Ads API</a> over supported
* versions of the Google Ads client libraries.
*
- * @see GoogleAdsV17
+ * @see GoogleAdsV19
*/
-public class GoogleAdsIO {
- private GoogleAdsIO() {}
+public abstract class GoogleAdsIO<GoogleAdsRowT, SearchGoogleAdsStreamRequestT> {
+
+ @SuppressWarnings(
+ "TypeParameterUnusedInFormals") // for source code backward compatible when underlying API
+ // version changed
+ public abstract <T extends PTransform<PCollection<String>, PCollection<GoogleAdsRowT>>> T read();
+
+ @SuppressWarnings(
+ "TypeParameterUnusedInFormals") // for source code backward compatible when underlying API
+ // version changed
+ public abstract <
+ T extends
+ PTransform<PCollection<SearchGoogleAdsStreamRequestT>, PCollection<GoogleAdsRowT>>>
+ T readAll();
+
+ public static GoogleAdsV19 current() {
Review Comment:
```suggestion
public static GoogleAdsIO current() {
```
Maybe this should stay generic?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Bump GoogleAdsIO to v19 [beam]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #34497:
URL: https://github.com/apache/beam/pull/34497#issuecomment-2770374040
Assigning reviewers. If you would like to opt out of this review, comment `assign to next reviewer`:
R: @ahmedabu98 for label java.
R: @damccorm for label build.
Available commands:
- `stop reviewer notifications` - opt out of the automated review tooling
- `remind me after tests pass` - tag the comment author after tests pass
- `waiting on author` - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)
The PR bot will only process comments in the main thread (not review comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Bump GoogleAdsIO to v19 [beam]
Posted by "Abacn (via GitHub)" <gi...@apache.org>.
Abacn merged PR #34497:
URL: https://github.com/apache/beam/pull/34497
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org