You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@fluss.apache.org by "charlesdong1991 (via GitHub)" <gi...@apache.org> on 2026/03/08 10:51:37 UTC
[PR] chore: Check tablet server availabitility in cpp tests [fluss-rust]
charlesdong1991 opened a new pull request, #437:
URL: https://github.com/apache/fluss-rust/pull/437
i think tests in cpp fail now, and we should check tablet server availability as well?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@fluss.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] chore: Check tablet server availabitility in cpp tests [fluss-rust]
Posted by "luoyuxia (via GitHub)" <gi...@apache.org>.
luoyuxia merged PR #437:
URL: https://github.com/apache/fluss-rust/pull/437
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@fluss.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] chore: Check tablet server availabitility in cpp tests [fluss-rust]
Posted by "fresh-borzoni (via GitHub)" <gi...@apache.org>.
fresh-borzoni commented on PR #437:
URL: https://github.com/apache/fluss-rust/pull/437#issuecomment-4019192543
> @charlesdong1991 Ty for the PR, LGTM
>
> Q: have you experienced cpp integration tests failure? In practice, all processes would try quick check and fail and go to WaitForCluster() which checks all ports. So in order for tests to fail, one process should start docker and have coordinator port ready, when other processes are still on a fast check. As all the processes start quickly and go for 1s fast check - close to zero chances practically.
>
> But it's fine as correctness fix 👍
Ah, I see, that's a different thing, we have everything started, but tablet_server hasn't registered yet - yes, this is correct fix then for the actual very possible race condition in tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@fluss.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] chore: Check tablet server availabitility in cpp tests [fluss-rust]
Posted by "charlesdong1991 (via GitHub)" <gi...@apache.org>.
charlesdong1991 commented on PR #437:
URL: https://github.com/apache/fluss-rust/pull/437#issuecomment-4019108586
> Q: have you experienced cpp integration tests failure?
@fresh-borzoni it seems happen twice after merging:
- https://github.com/apache/fluss-rust/actions/runs/22818521359/job/66187448589
- https://github.com/apache/fluss-rust/actions/runs/22819350526/job/66189578607
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@fluss.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] chore: Check tablet server availabitility in cpp tests [fluss-rust]
Posted by "charlesdong1991 (via GitHub)" <gi...@apache.org>.
charlesdong1991 commented on PR #437:
URL: https://github.com/apache/fluss-rust/pull/437#issuecomment-4018830761
i think this should fix, but PTAL @fresh-borzoni @luoyuxia 🙏
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@fluss.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org