You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shenyu.apache.org by GitBox <gi...@apache.org> on 2022/12/08 02:07:21 UTC
[GitHub] [shenyu] tian-pengfei commented on a diff in pull request #4187: [type:bugfix]Fixed signing function of the sign plugin When there is no request body
tian-pengfei commented on code in PR #4187:
URL: https://github.com/apache/shenyu/pull/4187#discussion_r1042852557
##########
shenyu-plugin/shenyu-plugin-sign/src/main/java/org/apache/shenyu/plugin/sign/service/DefaultSignService.java:
##########
@@ -126,6 +126,6 @@ private Pair<Boolean, String> sign(final ShenyuContext shenyuContext, final Serv
}
private String buildExtSignKey(final String signKey, final ShenyuContext shenyuContext) {
- return String.join("", Constants.TIMESTAMP, shenyuContext.getTimestamp(), Constants.PATH, shenyuContext.getPath(), Constants.VERSION, "1.0.0", signKey);
+ return String.join("", Constants.PATH, shenyuContext.getPath(), Constants.TIMESTAMP, shenyuContext.getTimestamp(), Constants.VERSION, "1.0.0", signKey);
Review Comment:
In #4242, I changed it back according to the current(2.5.1) document . The comments above are based on the 2.5.0 documentation
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org