You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by tn...@apache.org on 2012/12/03 22:27:36 UTC
svn commit: r1416672 - /commons/proper/email/trunk/pom.xml
Author: tn
Date: Mon Dec 3 21:27:34 2012
New Revision: 1416672
URL: http://svn.apache.org/viewvc?rev=1416672&view=rev
Log:
Upgrade test dependencies: commons-io:2.4, retrotranslator-runtime:1.2.9, subethasmtp:3.1.7
Modified:
commons/proper/email/trunk/pom.xml
Modified: commons/proper/email/trunk/pom.xml
URL: http://svn.apache.org/viewvc/commons/proper/email/trunk/pom.xml?rev=1416672&r1=1416671&r2=1416672&view=diff
==============================================================================
--- commons/proper/email/trunk/pom.xml (original)
+++ commons/proper/email/trunk/pom.xml Mon Dec 3 21:27:34 2012
@@ -210,37 +210,21 @@
<dependency>
<groupId>commons-io</groupId>
<artifactId>commons-io</artifactId>
- <version>1.4</version>
+ <version>2.4</version>
<scope>test</scope>
</dependency>
<dependency>
<groupId>net.sf.retrotranslator</groupId>
<artifactId>retrotranslator-runtime</artifactId>
- <version>1.2.1</version>
+ <version>1.2.9</version>
<scope>test</scope>
</dependency>
- <dependency>
- <groupId>org.subethamail</groupId>
- <artifactId>subethasmtp-smtp</artifactId>
- <version>1.2</version>
- <classifier>java14</classifier>
- <!--<url>http://subethasmtp.tigris.org/</url>-->
- <scope>test</scope>
- </dependency>
- <dependency>
- <groupId>org.subethamail</groupId>
- <artifactId>subethasmtp-wiser</artifactId>
- <version>1.2</version>
- <classifier>java14</classifier>
- <!--<url>http://subethasmtp.tigris.org/wiser.html</url>-->
- <scope>test</scope>
- <exclusions>
- <exclusion>
- <groupId>org.subethamail</groupId>
- <artifactId>subethasmtp-smtp</artifactId>
- </exclusion>
- </exclusions>
- </dependency>
+ <dependency>
+ <groupId>org.subethamail</groupId>
+ <artifactId>subethasmtp</artifactId>
+ <version>3.1.7</version>
+ <scope>test</scope>
+ </dependency>
</dependencies>
<properties>
Re: svn commit: r1416672 - /commons/proper/email/trunk/pom.xml
Posted by sebb <se...@gmail.com>.
On 5 December 2012 20:47, Thomas Neidhart <th...@gmail.com> wrote:
> On 12/04/2012 10:41 PM, sebb wrote:
>> On 4 December 2012 21:16, Thomas Neidhart <th...@gmail.com> wrote:
>>> On 12/03/2012 11:25 PM, sebb wrote:
>>>> On 3 December 2012 22:11, Thomas Neidhart <th...@gmail.com> wrote:
>>>>> On 12/03/2012 11:01 PM, Gary Gregory wrote:
>>>>>> Note that Commons IO 2.4 requires a minimum of JDK 1.6.
>>>>>
>>>>> ok, reverted to IO 2.2.
>>>>>
>>>>>> <dependency>
>>>>>> <groupId>net.sf.retrotranslator</groupId>
>>>>>> <artifactId>retrotranslator-runtime</artifactId>
>>>>>> - <version>1.2.1</version>
>>>>>> + <version>1.2.9</version>
>>>>>> <scope>test</scope>
>>>>>> </dependency>
>>>>>
>>>>>> Is the above dependency still needed for Java 1.5?
>>>>>
>>>>> Actually I did not yet look into it, but a brief search shows that it is
>>>>> only needed for compatibility with jdk 1.3 & 1.4, so I guess we can
>>>>> remove it now?
>>>>
>>>> As I suspected.
>>>>
>>>> It's only a test dependency anyway.
>>>>
>>>> Try a test; remove it and retest?
>>>
>>> I have seen you already did the change yourself together with lots of
>>> other things.
>>
>> Yes, I did the test as above.
>>
>>> Thanks!
>>
>> OK, no problem!
>>
>> The fixes found a bug in one of the tests - trying to use String
>> instead of InternetAddress when calling setCc.
>>
>> BTW Clirr reports several errors, but I think these are false positives.
>> Several String constants were removed from the Email class (not by me)
>> and moved into an interface that it now implements.
>>
>> The constants are still accessible as Email.CONSTANT, so I assume this
>> should not cause problems.
>>
>> But ideally someone should compile a jar of the 1.2 test classes
>> (using the 1.2 tag) and test against the 1.3 main jar.
>> That would show any binary compat issues. [I think we now
>> automatically include test jars in the Maven output, but may not have
>> been done for 1.2]
>
> ok, I compiled the 1.3 jar, created the 1.2 test-jar and used the junit
> command line tool to run the 1.2 tests using the 1.3 jar.
>
> All tests were successful.
Excellent!
Thanks for doing this.
> Thomas
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
Re: svn commit: r1416672 - /commons/proper/email/trunk/pom.xml
Posted by Thomas Neidhart <th...@gmail.com>.
On 12/04/2012 10:41 PM, sebb wrote:
> On 4 December 2012 21:16, Thomas Neidhart <th...@gmail.com> wrote:
>> On 12/03/2012 11:25 PM, sebb wrote:
>>> On 3 December 2012 22:11, Thomas Neidhart <th...@gmail.com> wrote:
>>>> On 12/03/2012 11:01 PM, Gary Gregory wrote:
>>>>> Note that Commons IO 2.4 requires a minimum of JDK 1.6.
>>>>
>>>> ok, reverted to IO 2.2.
>>>>
>>>>> <dependency>
>>>>> <groupId>net.sf.retrotranslator</groupId>
>>>>> <artifactId>retrotranslator-runtime</artifactId>
>>>>> - <version>1.2.1</version>
>>>>> + <version>1.2.9</version>
>>>>> <scope>test</scope>
>>>>> </dependency>
>>>>
>>>>> Is the above dependency still needed for Java 1.5?
>>>>
>>>> Actually I did not yet look into it, but a brief search shows that it is
>>>> only needed for compatibility with jdk 1.3 & 1.4, so I guess we can
>>>> remove it now?
>>>
>>> As I suspected.
>>>
>>> It's only a test dependency anyway.
>>>
>>> Try a test; remove it and retest?
>>
>> I have seen you already did the change yourself together with lots of
>> other things.
>
> Yes, I did the test as above.
>
>> Thanks!
>
> OK, no problem!
>
> The fixes found a bug in one of the tests - trying to use String
> instead of InternetAddress when calling setCc.
>
> BTW Clirr reports several errors, but I think these are false positives.
> Several String constants were removed from the Email class (not by me)
> and moved into an interface that it now implements.
>
> The constants are still accessible as Email.CONSTANT, so I assume this
> should not cause problems.
>
> But ideally someone should compile a jar of the 1.2 test classes
> (using the 1.2 tag) and test against the 1.3 main jar.
> That would show any binary compat issues. [I think we now
> automatically include test jars in the Maven output, but may not have
> been done for 1.2]
ok, I compiled the 1.3 jar, created the 1.2 test-jar and used the junit
command line tool to run the 1.2 tests using the 1.3 jar.
All tests were successful.
Thomas
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
Re: svn commit: r1416672 - /commons/proper/email/trunk/pom.xml
Posted by sebb <se...@gmail.com>.
On 4 December 2012 21:16, Thomas Neidhart <th...@gmail.com> wrote:
> On 12/03/2012 11:25 PM, sebb wrote:
>> On 3 December 2012 22:11, Thomas Neidhart <th...@gmail.com> wrote:
>>> On 12/03/2012 11:01 PM, Gary Gregory wrote:
>>>> Note that Commons IO 2.4 requires a minimum of JDK 1.6.
>>>
>>> ok, reverted to IO 2.2.
>>>
>>>> <dependency>
>>>> <groupId>net.sf.retrotranslator</groupId>
>>>> <artifactId>retrotranslator-runtime</artifactId>
>>>> - <version>1.2.1</version>
>>>> + <version>1.2.9</version>
>>>> <scope>test</scope>
>>>> </dependency>
>>>
>>>> Is the above dependency still needed for Java 1.5?
>>>
>>> Actually I did not yet look into it, but a brief search shows that it is
>>> only needed for compatibility with jdk 1.3 & 1.4, so I guess we can
>>> remove it now?
>>
>> As I suspected.
>>
>> It's only a test dependency anyway.
>>
>> Try a test; remove it and retest?
>
> I have seen you already did the change yourself together with lots of
> other things.
Yes, I did the test as above.
> Thanks!
OK, no problem!
The fixes found a bug in one of the tests - trying to use String
instead of InternetAddress when calling setCc.
BTW Clirr reports several errors, but I think these are false positives.
Several String constants were removed from the Email class (not by me)
and moved into an interface that it now implements.
The constants are still accessible as Email.CONSTANT, so I assume this
should not cause problems.
But ideally someone should compile a jar of the 1.2 test classes
(using the 1.2 tag) and test against the 1.3 main jar.
That would show any binary compat issues. [I think we now
automatically include test jars in the Maven output, but may not have
been done for 1.2]
> Thomas
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
Re: svn commit: r1416672 - /commons/proper/email/trunk/pom.xml
Posted by Thomas Neidhart <th...@gmail.com>.
On 12/03/2012 11:25 PM, sebb wrote:
> On 3 December 2012 22:11, Thomas Neidhart <th...@gmail.com> wrote:
>> On 12/03/2012 11:01 PM, Gary Gregory wrote:
>>> Note that Commons IO 2.4 requires a minimum of JDK 1.6.
>>
>> ok, reverted to IO 2.2.
>>
>>> <dependency>
>>> <groupId>net.sf.retrotranslator</groupId>
>>> <artifactId>retrotranslator-runtime</artifactId>
>>> - <version>1.2.1</version>
>>> + <version>1.2.9</version>
>>> <scope>test</scope>
>>> </dependency>
>>
>>> Is the above dependency still needed for Java 1.5?
>>
>> Actually I did not yet look into it, but a brief search shows that it is
>> only needed for compatibility with jdk 1.3 & 1.4, so I guess we can
>> remove it now?
>
> As I suspected.
>
> It's only a test dependency anyway.
>
> Try a test; remove it and retest?
I have seen you already did the change yourself together with lots of
other things.
Thanks!
Thomas
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
Re: svn commit: r1416672 - /commons/proper/email/trunk/pom.xml
Posted by sebb <se...@gmail.com>.
On 3 December 2012 22:11, Thomas Neidhart <th...@gmail.com> wrote:
> On 12/03/2012 11:01 PM, Gary Gregory wrote:
>> Note that Commons IO 2.4 requires a minimum of JDK 1.6.
>
> ok, reverted to IO 2.2.
>
>> <dependency>
>> <groupId>net.sf.retrotranslator</groupId>
>> <artifactId>retrotranslator-runtime</artifactId>
>> - <version>1.2.1</version>
>> + <version>1.2.9</version>
>> <scope>test</scope>
>> </dependency>
>
>> Is the above dependency still needed for Java 1.5?
>
> Actually I did not yet look into it, but a brief search shows that it is
> only needed for compatibility with jdk 1.3 & 1.4, so I guess we can
> remove it now?
As I suspected.
It's only a test dependency anyway.
Try a test; remove it and retest?
> Thomas
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
Re: svn commit: r1416672 - /commons/proper/email/trunk/pom.xml
Posted by Thomas Neidhart <th...@gmail.com>.
On 12/03/2012 11:01 PM, Gary Gregory wrote:
> Note that Commons IO 2.4 requires a minimum of JDK 1.6.
ok, reverted to IO 2.2.
> <dependency>
> <groupId>net.sf.retrotranslator</groupId>
> <artifactId>retrotranslator-runtime</artifactId>
> - <version>1.2.1</version>
> + <version>1.2.9</version>
> <scope>test</scope>
> </dependency>
> Is the above dependency still needed for Java 1.5?
Actually I did not yet look into it, but a brief search shows that it is
only needed for compatibility with jdk 1.3 & 1.4, so I guess we can
remove it now?
Thomas
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
Re: svn commit: r1416672 - /commons/proper/email/trunk/pom.xml
Posted by Gary Gregory <ga...@gmail.com>.
Note that Commons IO 2.4 requires a minimum of JDK 1.6.
Gary
On Mon, Dec 3, 2012 at 4:27 PM, <tn...@apache.org> wrote:
> Author: tn
> Date: Mon Dec 3 21:27:34 2012
> New Revision: 1416672
>
> URL: http://svn.apache.org/viewvc?rev=1416672&view=rev
> Log:
> Upgrade test dependencies: commons-io:2.4, retrotranslator-runtime:1.2.9,
> subethasmtp:3.1.7
>
> Modified:
> commons/proper/email/trunk/pom.xml
>
> Modified: commons/proper/email/trunk/pom.xml
> URL:
> http://svn.apache.org/viewvc/commons/proper/email/trunk/pom.xml?rev=1416672&r1=1416671&r2=1416672&view=diff
>
> ==============================================================================
> --- commons/proper/email/trunk/pom.xml (original)
> +++ commons/proper/email/trunk/pom.xml Mon Dec 3 21:27:34 2012
> @@ -210,37 +210,21 @@
> <dependency>
> <groupId>commons-io</groupId>
> <artifactId>commons-io</artifactId>
> - <version>1.4</version>
> + <version>2.4</version>
> <scope>test</scope>
> </dependency>
> <dependency>
> <groupId>net.sf.retrotranslator</groupId>
> <artifactId>retrotranslator-runtime</artifactId>
> - <version>1.2.1</version>
> + <version>1.2.9</version>
> <scope>test</scope>
> </dependency>
> - <dependency>
> - <groupId>org.subethamail</groupId>
> - <artifactId>subethasmtp-smtp</artifactId>
> - <version>1.2</version>
> - <classifier>java14</classifier>
> - <!--<url>http://subethasmtp.tigris.org/</url>-->
> - <scope>test</scope>
> - </dependency>
> - <dependency>
> - <groupId>org.subethamail</groupId>
> - <artifactId>subethasmtp-wiser</artifactId>
> - <version>1.2</version>
> - <classifier>java14</classifier>
> - <!--<url>http://subethasmtp.tigris.org/wiser.html</url>-->
> - <scope>test</scope>
> - <exclusions>
> - <exclusion>
> - <groupId>org.subethamail</groupId>
> - <artifactId>subethasmtp-smtp</artifactId>
> - </exclusion>
> - </exclusions>
> - </dependency>
> + <dependency>
> + <groupId>org.subethamail</groupId>
> + <artifactId>subethasmtp</artifactId>
> + <version>3.1.7</version>
> + <scope>test</scope>
> + </dependency>
> </dependencies>
>
> <properties>
>
>
>
--
E-Mail: garydgregory@gmail.com | ggregory@apache.org
JUnit in Action, 2nd Ed: <http://goog_1249600977>http://bit.ly/ECvg0
Spring Batch in Action: <http://s.apache.org/HOq>http://bit.ly/bqpbCK
Blog: http://garygregory.wordpress.com
Home: http://garygregory.com/
Tweet! http://twitter.com/GaryGregory
Re: svn commit: r1416672 - /commons/proper/email/trunk/pom.xml
Posted by sebb <se...@gmail.com>.
On 3 December 2012 21:27, <tn...@apache.org> wrote:
> Author: tn
> Date: Mon Dec 3 21:27:34 2012
> New Revision: 1416672
>
> URL: http://svn.apache.org/viewvc?rev=1416672&view=rev
> Log:
> Upgrade test dependencies: commons-io:2.4, retrotranslator-runtime:1.2.9, subethasmtp:3.1.7
>
> Modified:
> commons/proper/email/trunk/pom.xml
>
> Modified: commons/proper/email/trunk/pom.xml
> URL: http://svn.apache.org/viewvc/commons/proper/email/trunk/pom.xml?rev=1416672&r1=1416671&r2=1416672&view=diff
> ==============================================================================
> --- commons/proper/email/trunk/pom.xml (original)
> +++ commons/proper/email/trunk/pom.xml Mon Dec 3 21:27:34 2012
> @@ -210,37 +210,21 @@
> <dependency>
> <groupId>commons-io</groupId>
> <artifactId>commons-io</artifactId>
> - <version>1.4</version>
> + <version>2.4</version>
> <scope>test</scope>
> </dependency>
> <dependency>
> <groupId>net.sf.retrotranslator</groupId>
> <artifactId>retrotranslator-runtime</artifactId>
> - <version>1.2.1</version>
> + <version>1.2.9</version>
> <scope>test</scope>
> </dependency>
Is the above dependency still needed for Java 1.5?
> - <dependency>
> - <groupId>org.subethamail</groupId>
> - <artifactId>subethasmtp-smtp</artifactId>
> - <version>1.2</version>
> - <classifier>java14</classifier>
> - <!--<url>http://subethasmtp.tigris.org/</url>-->
> - <scope>test</scope>
> - </dependency>
> - <dependency>
> - <groupId>org.subethamail</groupId>
> - <artifactId>subethasmtp-wiser</artifactId>
> - <version>1.2</version>
> - <classifier>java14</classifier>
> - <!--<url>http://subethasmtp.tigris.org/wiser.html</url>-->
> - <scope>test</scope>
> - <exclusions>
> - <exclusion>
> - <groupId>org.subethamail</groupId>
> - <artifactId>subethasmtp-smtp</artifactId>
> - </exclusion>
> - </exclusions>
> - </dependency>
> + <dependency>
> + <groupId>org.subethamail</groupId>
> + <artifactId>subethasmtp</artifactId>
> + <version>3.1.7</version>
> + <scope>test</scope>
> + </dependency>
> </dependencies>
>
> <properties>
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org