You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/11/09 23:39:29 UTC
[GitHub] [arrow-datafusion] isidentical opened a new pull request, #4163: MINOR: enable `dyn_cmp_dict` feature on arrow for physical expr crate
isidentical opened a new pull request, #4163:
URL: https://github.com/apache/arrow-datafusion/pull/4163
Seems like when we are executing the test suite for the physical exprs in a standalone way (which I tend to do quite a lot 😄), it fails with a test requiring a specific feature from `arrow-rs` (`dyn_cmp_dict`). It is already turned on for `datafusion-core`, so ideally this should not change anything.
```
$ cargo test --package datafusion-physical-expr 1,135s
[...]
failures:
---- expressions::binary::tests::test_dictionary_type_to_array_coersion stdout ----
thread 'expressions::binary::tests::test_dictionary_type_to_array_coersion' panicked at 'assertion failed: `(left == right)`
left: `1`,
right: `0`: the test returned a termination value with a non-zero status code (1) which indicates a failure', /rustc/4b91a6ea7258a947e59c6522cd5898e7c0a6a88f/library/test/src/lib.rs:184:5
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
failures:
expressions::binary::tests::test_dictionary_type_to_array_coersion
test result: FAILED. 345 passed; 1 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.25s
error: test failed, to rerun pass '-p datafusion-physical-expr --lib'
```
```
$ cargo test --package datafusion-physical-expr --lib -- expressions::binary::tests::test_dictionary_type_to_array_coersion --exact --nocapture 129ms
Finished test [unoptimized + debuginfo] target(s) in 0.07s
Running unittests src/lib.rs (target/debug/deps/datafusion_physical_expr-e292b53aa0ae60cf)
running 1 test
Error: ArrowError(CastError("Comparing array of type Dictionary(Int32, Utf8) with array of type Dictionary(Int32, Utf8) requires \"dyn_cmp_dict\" feature"))
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb merged pull request #4163: MINOR: enable `dyn_cmp_dict` feature on arrow for physical expr crate
Posted by GitBox <gi...@apache.org>.
alamb merged PR #4163:
URL: https://github.com/apache/arrow-datafusion/pull/4163
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] isidentical commented on pull request #4163: MINOR: enable `dyn_cmp_dict` feature on arrow for physical expr crate
Posted by GitBox <gi...@apache.org>.
isidentical commented on PR #4163:
URL: https://github.com/apache/arrow-datafusion/pull/4163#issuecomment-1310340279
> Can we only enable this for dev, dyn_cmp_dict is an extremely heavy feature that is intentionally not enabled by default?
Makes sense @tustvold, I've changed the PR to only enable it as part of the dev dependencies.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] ursabot commented on pull request #4163: MINOR: enable `dyn_cmp_dict` feature on arrow for physical expr crate
Posted by GitBox <gi...@apache.org>.
ursabot commented on PR #4163:
URL: https://github.com/apache/arrow-datafusion/pull/4163#issuecomment-1310811208
Benchmark runs are scheduled for baseline = 456c254223707cb79f4ace8b1f113b5a6d6a992d and contender = 36890b835ee8b969bbdc1c0800006b36002552af. 36890b835ee8b969bbdc1c0800006b36002552af is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on ec2-t3-xlarge-us-east-2] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/fbd28418d7374a28807dc10b8464eb77...3a6ad1c2d0a9469ebbe60eb0827c1e0e/)
[Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on test-mac-arm] [test-mac-arm](https://conbench.ursa.dev/compare/runs/b1a5b77d48f34f7eb473bf78c3a017d3...85c236326eda414d8559cb679a79ee28/)
[Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on ursa-i9-9960x] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/3db27b2a3003485db3874b44087486be...577a9e14097c42ceaa3c744d7395f6cb/)
[Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on ursa-thinkcentre-m75q] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/99dd56fd3bda4477ad4e48474d666d54...b057f1ae5206408cbcafdb23425f40e5/)
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] tustvold commented on pull request #4163: MINOR: enable `dyn_cmp_dict` feature on arrow for physical expr crate
Posted by GitBox <gi...@apache.org>.
tustvold commented on PR #4163:
URL: https://github.com/apache/arrow-datafusion/pull/4163#issuecomment-1309631723
Can we only enable this for dwv, dyn_cmp_dict is an extremely heavy feature that is intentionally not enabled by default?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org