You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2018/03/21 21:30:12 UTC

[GitHub] jai1 commented on a change in pull request #1417: Replace cached data key from the map if present already

jai1 commented on a change in pull request #1417: Replace cached data key from the map if present already
URL: https://github.com/apache/incubator-pulsar/pull/1417#discussion_r176244734
 
 

 ##########
 File path: pulsar-client-cpp/lib/MessageCrypto.h
 ##########
 @@ -136,6 +136,7 @@ class MessageCrypto {
     bool getKeyAndDecryptData(const proto::MessageMetadata& msgMetadata, SharedBuffer& payload,
                               SharedBuffer& decryptedPayload);
     std::string stringToHex(const std::string& inputStr, size_t len);
 
 Review comment:
   Do we still need the old signature?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services