You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@kvrocks.apache.org by "jihuayu (via GitHub)" <gi...@apache.org> on 2026/04/13 07:14:49 UTC
[PR] feat(ci): add caching for CMake FetchContent in CI workflow [kvrocks]
jihuayu opened a new pull request, #3448:
URL: https://github.com/apache/kvrocks/pull/3448
Due to the current instability of GitHub services, dependency download failures occur frequently during CI runs. I add FetchContent caching to prevent these network issues from failing the CI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(ci): add caching for CMake FetchContent in CI workflow [kvrocks]
Posted by "PragmaTwice (via GitHub)" <gi...@apache.org>.
PragmaTwice commented on PR #3448:
URL: https://github.com/apache/kvrocks/pull/3448#issuecomment-4235957243
> env.CMAKE_JEMALLOC_VARIANT, env.CMAKE_LUA_VARIANT,
I don't think we need this. They are useless and introduce complexity.
> Do you think it’s better to cache each job individually (now), or do a full cache at the beginning of the action?
I think we'd better to choose the simplest way.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(ci): add caching for CMake FetchContent in CI workflow [kvrocks]
Posted by "sonarqubecloud[bot] (via GitHub)" <gi...@apache.org>.
sonarqubecloud[bot] commented on PR #3448:
URL: https://github.com/apache/kvrocks/pull/3448#issuecomment-4250146355
## [](https://sonarcloud.io/dashboard?id=apache_kvrocks&pullRequest=3448) **Quality Gate passed**
Issues
 [0 New issues](https://sonarcloud.io/project/issues?id=apache_kvrocks&pullRequest=3448&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_kvrocks&pullRequest=3448&issueStatuses=ACCEPTED)
Measures
 [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_kvrocks&pullRequest=3448&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_kvrocks&pullRequest=3448&metric=new_coverage&view=list)
 [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_kvrocks&pullRequest=3448&metric=new_duplicated_lines_density&view=list)
[See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_kvrocks&pullRequest=3448)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(ci): add caching for CMake FetchContent in CI workflow [kvrocks]
Posted by "jihuayu (via GitHub)" <gi...@apache.org>.
jihuayu commented on PR #3448:
URL: https://github.com/apache/kvrocks/pull/3448#issuecomment-4240446244
> env.CMAKE_JEMALLOC_VARIANT, env.CMAKE_LUA_VARIANT,
> I don't think we need this. They are useless and introduce complexity.
This variable is just for readability; otherwise, we’d be stuck facing a very long cache key.
```${{ format('cmake-fetch-archives-v1-{0}-{1}-{2}-{3}', matrix.os, startsWith(matrix.os, 'macos') && 'without-jemalloc' || matrix.without_jemalloc && 'without-jemalloc' || 'with-jemalloc' , matrix.without_luajit && 'without-luajit' || 'with-luajit' , hashFiles('CMakeLists.txt', 'cmake/**/*')) }}```
As I understand it, the Lua and jemalloc options must be cached separately because they pull different source codes. Is that correct?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(ci): add caching for CMake FetchContent in CI workflow [kvrocks]
Posted by "jihuayu (via GitHub)" <gi...@apache.org>.
jihuayu commented on code in PR #3448:
URL: https://github.com/apache/kvrocks/pull/3448#discussion_r3079047920
##########
.github/workflows/kvrocks.yaml:
##########
@@ -65,13 +68,40 @@ jobs:
with:
config: .github/config/licenserc.yml
+ prepare-deps-cache:
+ name: Prepare dependency cache
+ needs: [precondition]
+ if: ${{ needs.precondition.outputs.docs_only != 'true' }}
+ runs-on: ubuntu-22.04
+ steps:
+ - uses: actions/checkout@v6
+ - name: Cache Kvrocks dependencies
+ id: cache-kvrocks-deps
+ uses: actions/cache@v5
+ with:
+ path: ${{ env.KVROCKS_DEPS_CACHE_DIR }}
+ key: kvrocks-full-deps-${{ hashFiles('x.py', 'CMakeLists.txt', 'cmake/**/*.cmake') }}
+ enableCrossOsArchive: true
+ - name: Warm Kvrocks dependency cache
+ if: ${{ steps.cache-kvrocks-deps.outputs.cache-hit != 'true' }}
+ run: |
+ ./x.py build .github/ci-cache-default --skip-build --dep-dir ${{ env.KVROCKS_DEPS_CACHE_DIR }}
+ ./x.py build .github/ci-cache-lua --skip-build --dep-dir ${{ env.KVROCKS_DEPS_CACHE_DIR }} -D ENABLE_LUAJIT=OFF
+ rm -rf .github/ci-cache-default .github/ci-cache-lua
Review Comment:
All is right. Thank you!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(ci): add caching for CMake FetchContent in CI workflow [kvrocks]
Posted by "PragmaTwice (via GitHub)" <gi...@apache.org>.
PragmaTwice commented on code in PR #3448:
URL: https://github.com/apache/kvrocks/pull/3448#discussion_r3078019479
##########
.github/workflows/kvrocks.yaml:
##########
@@ -65,13 +68,40 @@ jobs:
with:
config: .github/config/licenserc.yml
+ prepare-deps-cache:
+ name: Prepare dependency cache
+ needs: [precondition]
+ if: ${{ needs.precondition.outputs.docs_only != 'true' }}
+ runs-on: ubuntu-22.04
+ steps:
+ - uses: actions/checkout@v6
+ - name: Cache Kvrocks dependencies
+ id: cache-kvrocks-deps
+ uses: actions/cache@v5
+ with:
+ path: ${{ env.KVROCKS_DEPS_CACHE_DIR }}
+ key: kvrocks-full-deps-${{ hashFiles('x.py', 'CMakeLists.txt', 'cmake/**/*.cmake') }}
+ enableCrossOsArchive: true
+ - name: Warm Kvrocks dependency cache
+ if: ${{ steps.cache-kvrocks-deps.outputs.cache-hit != 'true' }}
+ run: |
+ ./x.py build .github/ci-cache-default --skip-build --dep-dir ${{ env.KVROCKS_DEPS_CACHE_DIR }}
+ ./x.py build .github/ci-cache-lua --skip-build --dep-dir ${{ env.KVROCKS_DEPS_CACHE_DIR }} -D ENABLE_LUAJIT=OFF
+ rm -rf .github/ci-cache-default .github/ci-cache-lua
Review Comment:
why we need this job?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(ci): add caching for CMake FetchContent in CI workflow [kvrocks]
Posted by "PragmaTwice (via GitHub)" <gi...@apache.org>.
PragmaTwice commented on code in PR #3448:
URL: https://github.com/apache/kvrocks/pull/3448#discussion_r3078710974
##########
.github/workflows/kvrocks.yaml:
##########
@@ -65,13 +68,40 @@ jobs:
with:
config: .github/config/licenserc.yml
+ prepare-deps-cache:
+ name: Prepare dependency cache
+ needs: [precondition]
+ if: ${{ needs.precondition.outputs.docs_only != 'true' }}
+ runs-on: ubuntu-22.04
+ steps:
+ - uses: actions/checkout@v6
+ - name: Cache Kvrocks dependencies
+ id: cache-kvrocks-deps
+ uses: actions/cache@v5
+ with:
+ path: ${{ env.KVROCKS_DEPS_CACHE_DIR }}
+ key: kvrocks-full-deps-${{ hashFiles('x.py', 'CMakeLists.txt', 'cmake/**/*.cmake') }}
+ enableCrossOsArchive: true
+ - name: Warm Kvrocks dependency cache
+ if: ${{ steps.cache-kvrocks-deps.outputs.cache-hit != 'true' }}
+ run: |
+ ./x.py build .github/ci-cache-default --skip-build --dep-dir ${{ env.KVROCKS_DEPS_CACHE_DIR }}
+ ./x.py build .github/ci-cache-lua --skip-build --dep-dir ${{ env.KVROCKS_DEPS_CACHE_DIR }} -D ENABLE_LUAJIT=OFF
+ rm -rf .github/ci-cache-default .github/ci-cache-lua
Review Comment:
ahh got it.
please put it in `check-and-lint`. also you can use `./x.py fetch-deps`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(ci): add caching for CMake FetchContent in CI workflow [kvrocks]
Posted by "sonarqubecloud[bot] (via GitHub)" <gi...@apache.org>.
sonarqubecloud[bot] commented on PR #3448:
URL: https://github.com/apache/kvrocks/pull/3448#issuecomment-4235696467
## [](https://sonarcloud.io/dashboard?id=apache_kvrocks&pullRequest=3448) **Quality Gate passed**
Issues
 [0 New issues](https://sonarcloud.io/project/issues?id=apache_kvrocks&pullRequest=3448&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_kvrocks&pullRequest=3448&issueStatuses=ACCEPTED)
Measures
 [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_kvrocks&pullRequest=3448&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_kvrocks&pullRequest=3448&metric=new_coverage&view=list)
 [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_kvrocks&pullRequest=3448&metric=new_duplicated_lines_density&view=list)
[See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_kvrocks&pullRequest=3448)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(ci): add caching for CMake FetchContent in CI workflow [kvrocks]
Posted by "PragmaTwice (via GitHub)" <gi...@apache.org>.
PragmaTwice commented on code in PR #3448:
URL: https://github.com/apache/kvrocks/pull/3448#discussion_r3078024372
##########
.github/workflows/kvrocks.yaml:
##########
@@ -65,13 +68,40 @@ jobs:
with:
config: .github/config/licenserc.yml
+ prepare-deps-cache:
+ name: Prepare dependency cache
+ needs: [precondition]
+ if: ${{ needs.precondition.outputs.docs_only != 'true' }}
+ runs-on: ubuntu-22.04
+ steps:
+ - uses: actions/checkout@v6
+ - name: Cache Kvrocks dependencies
+ id: cache-kvrocks-deps
+ uses: actions/cache@v5
+ with:
+ path: ${{ env.KVROCKS_DEPS_CACHE_DIR }}
+ key: kvrocks-full-deps-${{ hashFiles('x.py', 'CMakeLists.txt', 'cmake/**/*.cmake') }}
+ enableCrossOsArchive: true
+ - name: Warm Kvrocks dependency cache
+ if: ${{ steps.cache-kvrocks-deps.outputs.cache-hit != 'true' }}
+ run: |
+ ./x.py build .github/ci-cache-default --skip-build --dep-dir ${{ env.KVROCKS_DEPS_CACHE_DIR }}
+ ./x.py build .github/ci-cache-lua --skip-build --dep-dir ${{ env.KVROCKS_DEPS_CACHE_DIR }} -D ENABLE_LUAJIT=OFF
+ rm -rf .github/ci-cache-default .github/ci-cache-lua
Review Comment:
we don't need a job to "warm" the cache.. you can try `--dep-dir` on your local to know how it works.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(ci): add caching for CMake FetchContent in CI workflow [kvrocks]
Posted by "jihuayu (via GitHub)" <gi...@apache.org>.
jihuayu merged PR #3448:
URL: https://github.com/apache/kvrocks/pull/3448
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(ci): add caching for CMake FetchContent in CI workflow [kvrocks]
Posted by "jihuayu (via GitHub)" <gi...@apache.org>.
jihuayu commented on code in PR #3448:
URL: https://github.com/apache/kvrocks/pull/3448#discussion_r3078033880
##########
.github/workflows/kvrocks.yaml:
##########
@@ -65,13 +68,40 @@ jobs:
with:
config: .github/config/licenserc.yml
+ prepare-deps-cache:
+ name: Prepare dependency cache
+ needs: [precondition]
+ if: ${{ needs.precondition.outputs.docs_only != 'true' }}
+ runs-on: ubuntu-22.04
+ steps:
+ - uses: actions/checkout@v6
+ - name: Cache Kvrocks dependencies
+ id: cache-kvrocks-deps
+ uses: actions/cache@v5
+ with:
+ path: ${{ env.KVROCKS_DEPS_CACHE_DIR }}
+ key: kvrocks-full-deps-${{ hashFiles('x.py', 'CMakeLists.txt', 'cmake/**/*.cmake') }}
+ enableCrossOsArchive: true
+ - name: Warm Kvrocks dependency cache
+ if: ${{ steps.cache-kvrocks-deps.outputs.cache-hit != 'true' }}
+ run: |
+ ./x.py build .github/ci-cache-default --skip-build --dep-dir ${{ env.KVROCKS_DEPS_CACHE_DIR }}
+ ./x.py build .github/ci-cache-lua --skip-build --dep-dir ${{ env.KVROCKS_DEPS_CACHE_DIR }} -D ENABLE_LUAJIT=OFF
+ rm -rf .github/ci-cache-default .github/ci-cache-lua
Review Comment:
GitHub Actions caches are immutable. Once a cache is created for a specific key, it cannot be updated or overwritten.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(ci): add caching for CMake FetchContent in CI workflow [kvrocks]
Posted by "jihuayu (via GitHub)" <gi...@apache.org>.
jihuayu commented on PR #3448:
URL: https://github.com/apache/kvrocks/pull/3448#issuecomment-4235369121
@PragmaTwice Thanks for the reminder. I’ve made the changes.
Do you think it’s better to cache each job individually (now), or do a full cache at the beginning of the action?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(ci): add caching for CMake FetchContent in CI workflow [kvrocks]
Posted by "sonarqubecloud[bot] (via GitHub)" <gi...@apache.org>.
sonarqubecloud[bot] commented on PR #3448:
URL: https://github.com/apache/kvrocks/pull/3448#issuecomment-4234882573
## [](https://sonarcloud.io/dashboard?id=apache_kvrocks&pullRequest=3448) **Quality Gate passed**
Issues
 [0 New issues](https://sonarcloud.io/project/issues?id=apache_kvrocks&pullRequest=3448&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_kvrocks&pullRequest=3448&issueStatuses=ACCEPTED)
Measures
 [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_kvrocks&pullRequest=3448&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_kvrocks&pullRequest=3448&metric=new_coverage&view=list)
 [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_kvrocks&pullRequest=3448&metric=new_duplicated_lines_density&view=list)
[See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_kvrocks&pullRequest=3448)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(ci): add caching for CMake FetchContent in CI workflow [kvrocks]
Posted by "jihuayu (via GitHub)" <gi...@apache.org>.
jihuayu commented on code in PR #3448:
URL: https://github.com/apache/kvrocks/pull/3448#discussion_r3078033880
##########
.github/workflows/kvrocks.yaml:
##########
@@ -65,13 +68,40 @@ jobs:
with:
config: .github/config/licenserc.yml
+ prepare-deps-cache:
+ name: Prepare dependency cache
+ needs: [precondition]
+ if: ${{ needs.precondition.outputs.docs_only != 'true' }}
+ runs-on: ubuntu-22.04
+ steps:
+ - uses: actions/checkout@v6
+ - name: Cache Kvrocks dependencies
+ id: cache-kvrocks-deps
+ uses: actions/cache@v5
+ with:
+ path: ${{ env.KVROCKS_DEPS_CACHE_DIR }}
+ key: kvrocks-full-deps-${{ hashFiles('x.py', 'CMakeLists.txt', 'cmake/**/*.cmake') }}
+ enableCrossOsArchive: true
+ - name: Warm Kvrocks dependency cache
+ if: ${{ steps.cache-kvrocks-deps.outputs.cache-hit != 'true' }}
+ run: |
+ ./x.py build .github/ci-cache-default --skip-build --dep-dir ${{ env.KVROCKS_DEPS_CACHE_DIR }}
+ ./x.py build .github/ci-cache-lua --skip-build --dep-dir ${{ env.KVROCKS_DEPS_CACHE_DIR }} -D ENABLE_LUAJIT=OFF
+ rm -rf .github/ci-cache-default .github/ci-cache-lua
Review Comment:
GitHub Actions caches are immutable. Once a cache is created for a specific key, it cannot be updated or overwritten.
So, we need to create all files intended for caching in a single step.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(ci): add caching for CMake FetchContent in CI workflow [kvrocks]
Posted by "sonarqubecloud[bot] (via GitHub)" <gi...@apache.org>.
sonarqubecloud[bot] commented on PR #3448:
URL: https://github.com/apache/kvrocks/pull/3448#issuecomment-4242661533
## [](https://sonarcloud.io/dashboard?id=apache_kvrocks&pullRequest=3448) **Quality Gate passed**
Issues
 [0 New issues](https://sonarcloud.io/project/issues?id=apache_kvrocks&pullRequest=3448&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_kvrocks&pullRequest=3448&issueStatuses=ACCEPTED)
Measures
 [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_kvrocks&pullRequest=3448&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_kvrocks&pullRequest=3448&metric=new_coverage&view=list)
 [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_kvrocks&pullRequest=3448&metric=new_duplicated_lines_density&view=list)
[See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_kvrocks&pullRequest=3448)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(ci): add caching for CMake FetchContent in CI workflow [kvrocks]
Posted by "jihuayu (via GitHub)" <gi...@apache.org>.
jihuayu commented on code in PR #3448:
URL: https://github.com/apache/kvrocks/pull/3448#discussion_r3079047920
##########
.github/workflows/kvrocks.yaml:
##########
@@ -65,13 +68,40 @@ jobs:
with:
config: .github/config/licenserc.yml
+ prepare-deps-cache:
+ name: Prepare dependency cache
+ needs: [precondition]
+ if: ${{ needs.precondition.outputs.docs_only != 'true' }}
+ runs-on: ubuntu-22.04
+ steps:
+ - uses: actions/checkout@v6
+ - name: Cache Kvrocks dependencies
+ id: cache-kvrocks-deps
+ uses: actions/cache@v5
+ with:
+ path: ${{ env.KVROCKS_DEPS_CACHE_DIR }}
+ key: kvrocks-full-deps-${{ hashFiles('x.py', 'CMakeLists.txt', 'cmake/**/*.cmake') }}
+ enableCrossOsArchive: true
+ - name: Warm Kvrocks dependency cache
+ if: ${{ steps.cache-kvrocks-deps.outputs.cache-hit != 'true' }}
+ run: |
+ ./x.py build .github/ci-cache-default --skip-build --dep-dir ${{ env.KVROCKS_DEPS_CACHE_DIR }}
+ ./x.py build .github/ci-cache-lua --skip-build --dep-dir ${{ env.KVROCKS_DEPS_CACHE_DIR }} -D ENABLE_LUAJIT=OFF
+ rm -rf .github/ci-cache-default .github/ci-cache-lua
Review Comment:
All right. Thank you!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(ci): add caching for CMake FetchContent in CI workflow [kvrocks]
Posted by "PragmaTwice (via GitHub)" <gi...@apache.org>.
PragmaTwice commented on PR #3448:
URL: https://github.com/apache/kvrocks/pull/3448#issuecomment-4240940675
> As I understand it, the Lua and jemalloc options must be cached separately because they pull different source codes. Is that correct?
Nope. The dep dir can be shared. The filename is different for different deps.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org