You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@avro.apache.org by suraj acharya <su...@gmail.com> on 2017/02/27 12:29:33 UTC
JavaScript failing on Branch-1.7
I was attempting to make a release for 1.7.X.
In the process I am running into failing JS tests.
I was wondering if someone who worked on JS for AVRO can take a look at the
issue.
If there are no takers for the same, does anyone have objection if for
Branch-1.7 the JS component is removed? The builds on Branch-1.8 and higher
are working fine. There have been changes to the way the npm setup happens
in Branch-1.8.
Any help is appreciated.
-Suraj Acharya
Re: JavaScript failing on Branch-1.7
Posted by Sean Busbey <bu...@cloudera.com>.
Barring someone from the javascript side of the project piping up
about branch-1.7, I'd be inclined to vote in favor of at least
removing the javascript libraries from the default top-level build and
convenience binaries for 1.7.
On Wed, Mar 22, 2017 at 5:31 PM, suraj acharya <su...@gmail.com> wrote:
> Hi,
> I have been trying for the last couple of weeks and I still haven't made
> progress.
>
> I am inclined to now call for a vote to decouple JS from 1.7.X.
>
> Thanks
>
> Suraj
>
>
> -Suraj Acharya
>
> On Wed, Mar 1, 2017 at 9:43 AM, suraj acharya <su...@gmail.com> wrote:
>
>> Hi Ryan,
>> Thanks for the reply.
>> I was on Node 6.
>> However, I am getting the same error on Node 4 and Node 5.
>> bash-4.1# ./build.sh test
>> npm WARN avro-js@0.0.1 license should be a valid SPDX license expression
>> A valid Gruntfile could not be found. Please see the getting started guide
>> for
>> more information on how to configure grunt: http://gruntjs.com/getting-sta
>> rted
>> Fatal error: Unable to find Gruntfile.
>> bash-4.1# npm version
>> { 'avro-js': '0.0.1',
>> npm: '3.7.3',
>> ares: '1.10.1-DEV',
>> http_parser: '2.6.2',
>> icu: '56.1',
>> modules: '47',
>> node: '5.9.0',
>> openssl: '1.0.2g',
>> uv: '1.8.0',
>> v8: '4.6.85.31',
>> zlib: '1.2.8' }
>> bash-4.1# npm version
>> { 'avro-js': '0.0.1',
>> npm: '2.15.11',
>> ares: '1.10.1-DEV',
>> http_parser: '2.7.0',
>> icu: '56.1',
>> modules: '46',
>> node: '4.7.3',
>> openssl: '1.0.2k',
>> uv: '1.9.1',
>> v8: '4.5.103.43',
>> zlib: '1.2.8' }
>> bash-4.1# ./build.sh test
>> npm WARN package.json avro-js@0.0.1 license should be a valid SPDX
>> license expression
>> underscore@1.8.3 node_modules/underscore
>>
>> grunt@1.0.1 node_modules/grunt
>> ├── grunt-known-options@1.1.0
>> ├── path-is-absolute@1.0.1
>> ├── eventemitter2@0.4.14
>> ├── rimraf@2.2.8
>> ├── exit@0.1.2
>> ├── iconv-lite@0.4.15
>> ├── coffee-script@1.10.0
>> ├── nopt@3.0.6 (abbrev@1.1.0)
>> ├── glob@7.0.6 (inherits@2.0.3, fs.realpath@1.0.0, once@1.4.0,
>> inflight@1.0.6)
>> ├── findup-sync@0.3.0 (glob@5.0.15)
>> ├── grunt-cli@1.2.0 (resolve@1.1.7)
>> ├── minimatch@3.0.3 (brace-expansion@1.1.6)
>> ├── js-yaml@3.5.5 (esprima@2.7.3, argparse@1.0.9)
>> ├── dateformat@1.0.12 (get-stdin@4.0.1, meow@3.7.0)
>> ├── grunt-legacy-util@1.0.0 (getobject@0.1.0, async@1.5.2, hooker@0.2.3,
>> which@1.2.12, underscore.string@3.2.3, lodash@4.3.0)
>> └── grunt-legacy-log@1.0.0 (hooker@0.2.3, colors@1.1.2,
>> underscore.string@3.2.3, lodash@3.10.1, grunt-legacy-log-utils@1.0.0)
>> A valid Gruntfile could not be found. Please see the getting started guide
>> for
>> more information on how to configure grunt: http://gruntjs.com/getting-sta
>> rted
>> Fatal error: Unable to find Gruntfile.
>>
>> I looked at the travis job you had shared. Comparing the commits on it, it
>> looks like the master is based on 1.8. I am trying to make 1.7 build and
>> test.
>> Do you think it is worthwhile to make the build.sh of 1.7 similar to the
>> one in 1.8? I see there are a lot of fundamental differences, and if we are
>> to back port those over, I am not sure if there are going to be other
>> issues.
>>
>> Can you give some pointers on the same?
>>
>>
>> -Suraj Acharya
>>
>> On Tue, Feb 28, 2017 at 2:29 AM, Ryan Blue <rb...@netflix.com.invalid>
>> wrote:
>>
>>> Suraj,
>>>
>>> I separated out a few implementations into separate repositories, set
>>> up Travis CI, and fixed a few tests in different implementations. It
>>> looks like the one for JS has tests passing in Node JS 4 and 5, but
>>> broken in 6: https://travis-ci.org/rdblue/avro-js/builds/187343704
>>>
>>> You may be running with Node JS 6?
>>>
>>> rb
>>>
>>> On Mon, Feb 27, 2017 at 4:29 AM, suraj acharya <su...@gmail.com>
>>> wrote:
>>> > I was attempting to make a release for 1.7.X.
>>> > In the process I am running into failing JS tests.
>>> > I was wondering if someone who worked on JS for AVRO can take a look at
>>> the
>>> > issue.
>>> > If there are no takers for the same, does anyone have objection if for
>>> > Branch-1.7 the JS component is removed? The builds on Branch-1.8 and
>>> higher
>>> > are working fine. There have been changes to the way the npm setup
>>> happens
>>> > in Branch-1.8.
>>> >
>>> > Any help is appreciated.
>>> >
>>> > -Suraj Acharya
>>>
>>>
>>>
>>> --
>>> Ryan Blue
>>> Software Engineer
>>> Netflix
>>>
>>
>>
--
busbey
Re: JavaScript failing on Branch-1.7
Posted by suraj acharya <su...@gmail.com>.
Hi,
I have been trying for the last couple of weeks and I still haven't made
progress.
I am inclined to now call for a vote to decouple JS from 1.7.X.
Thanks
Suraj
-Suraj Acharya
On Wed, Mar 1, 2017 at 9:43 AM, suraj acharya <su...@gmail.com> wrote:
> Hi Ryan,
> Thanks for the reply.
> I was on Node 6.
> However, I am getting the same error on Node 4 and Node 5.
> bash-4.1# ./build.sh test
> npm WARN avro-js@0.0.1 license should be a valid SPDX license expression
> A valid Gruntfile could not be found. Please see the getting started guide
> for
> more information on how to configure grunt: http://gruntjs.com/getting-sta
> rted
> Fatal error: Unable to find Gruntfile.
> bash-4.1# npm version
> { 'avro-js': '0.0.1',
> npm: '3.7.3',
> ares: '1.10.1-DEV',
> http_parser: '2.6.2',
> icu: '56.1',
> modules: '47',
> node: '5.9.0',
> openssl: '1.0.2g',
> uv: '1.8.0',
> v8: '4.6.85.31',
> zlib: '1.2.8' }
> bash-4.1# npm version
> { 'avro-js': '0.0.1',
> npm: '2.15.11',
> ares: '1.10.1-DEV',
> http_parser: '2.7.0',
> icu: '56.1',
> modules: '46',
> node: '4.7.3',
> openssl: '1.0.2k',
> uv: '1.9.1',
> v8: '4.5.103.43',
> zlib: '1.2.8' }
> bash-4.1# ./build.sh test
> npm WARN package.json avro-js@0.0.1 license should be a valid SPDX
> license expression
> underscore@1.8.3 node_modules/underscore
>
> grunt@1.0.1 node_modules/grunt
> ├── grunt-known-options@1.1.0
> ├── path-is-absolute@1.0.1
> ├── eventemitter2@0.4.14
> ├── rimraf@2.2.8
> ├── exit@0.1.2
> ├── iconv-lite@0.4.15
> ├── coffee-script@1.10.0
> ├── nopt@3.0.6 (abbrev@1.1.0)
> ├── glob@7.0.6 (inherits@2.0.3, fs.realpath@1.0.0, once@1.4.0,
> inflight@1.0.6)
> ├── findup-sync@0.3.0 (glob@5.0.15)
> ├── grunt-cli@1.2.0 (resolve@1.1.7)
> ├── minimatch@3.0.3 (brace-expansion@1.1.6)
> ├── js-yaml@3.5.5 (esprima@2.7.3, argparse@1.0.9)
> ├── dateformat@1.0.12 (get-stdin@4.0.1, meow@3.7.0)
> ├── grunt-legacy-util@1.0.0 (getobject@0.1.0, async@1.5.2, hooker@0.2.3,
> which@1.2.12, underscore.string@3.2.3, lodash@4.3.0)
> └── grunt-legacy-log@1.0.0 (hooker@0.2.3, colors@1.1.2,
> underscore.string@3.2.3, lodash@3.10.1, grunt-legacy-log-utils@1.0.0)
> A valid Gruntfile could not be found. Please see the getting started guide
> for
> more information on how to configure grunt: http://gruntjs.com/getting-sta
> rted
> Fatal error: Unable to find Gruntfile.
>
> I looked at the travis job you had shared. Comparing the commits on it, it
> looks like the master is based on 1.8. I am trying to make 1.7 build and
> test.
> Do you think it is worthwhile to make the build.sh of 1.7 similar to the
> one in 1.8? I see there are a lot of fundamental differences, and if we are
> to back port those over, I am not sure if there are going to be other
> issues.
>
> Can you give some pointers on the same?
>
>
> -Suraj Acharya
>
> On Tue, Feb 28, 2017 at 2:29 AM, Ryan Blue <rb...@netflix.com.invalid>
> wrote:
>
>> Suraj,
>>
>> I separated out a few implementations into separate repositories, set
>> up Travis CI, and fixed a few tests in different implementations. It
>> looks like the one for JS has tests passing in Node JS 4 and 5, but
>> broken in 6: https://travis-ci.org/rdblue/avro-js/builds/187343704
>>
>> You may be running with Node JS 6?
>>
>> rb
>>
>> On Mon, Feb 27, 2017 at 4:29 AM, suraj acharya <su...@gmail.com>
>> wrote:
>> > I was attempting to make a release for 1.7.X.
>> > In the process I am running into failing JS tests.
>> > I was wondering if someone who worked on JS for AVRO can take a look at
>> the
>> > issue.
>> > If there are no takers for the same, does anyone have objection if for
>> > Branch-1.7 the JS component is removed? The builds on Branch-1.8 and
>> higher
>> > are working fine. There have been changes to the way the npm setup
>> happens
>> > in Branch-1.8.
>> >
>> > Any help is appreciated.
>> >
>> > -Suraj Acharya
>>
>>
>>
>> --
>> Ryan Blue
>> Software Engineer
>> Netflix
>>
>
>
Re: JavaScript failing on Branch-1.7
Posted by suraj acharya <su...@gmail.com>.
Hi Ryan,
Thanks for the reply.
I was on Node 6.
However, I am getting the same error on Node 4 and Node 5.
bash-4.1# ./build.sh test
npm WARN avro-js@0.0.1 license should be a valid SPDX license expression
A valid Gruntfile could not be found. Please see the getting started guide
for
more information on how to configure grunt: http://gruntjs.com/getting-
started
Fatal error: Unable to find Gruntfile.
bash-4.1# npm version
{ 'avro-js': '0.0.1',
npm: '3.7.3',
ares: '1.10.1-DEV',
http_parser: '2.6.2',
icu: '56.1',
modules: '47',
node: '5.9.0',
openssl: '1.0.2g',
uv: '1.8.0',
v8: '4.6.85.31',
zlib: '1.2.8' }
bash-4.1# npm version
{ 'avro-js': '0.0.1',
npm: '2.15.11',
ares: '1.10.1-DEV',
http_parser: '2.7.0',
icu: '56.1',
modules: '46',
node: '4.7.3',
openssl: '1.0.2k',
uv: '1.9.1',
v8: '4.5.103.43',
zlib: '1.2.8' }
bash-4.1# ./build.sh test
npm WARN package.json avro-js@0.0.1 license should be a valid SPDX license
expression
underscore@1.8.3 node_modules/underscore
grunt@1.0.1 node_modules/grunt
├── grunt-known-options@1.1.0
├── path-is-absolute@1.0.1
├── eventemitter2@0.4.14
├── rimraf@2.2.8
├── exit@0.1.2
├── iconv-lite@0.4.15
├── coffee-script@1.10.0
├── nopt@3.0.6 (abbrev@1.1.0)
├── glob@7.0.6 (inherits@2.0.3, fs.realpath@1.0.0, once@1.4.0,
inflight@1.0.6)
├── findup-sync@0.3.0 (glob@5.0.15)
├── grunt-cli@1.2.0 (resolve@1.1.7)
├── minimatch@3.0.3 (brace-expansion@1.1.6)
├── js-yaml@3.5.5 (esprima@2.7.3, argparse@1.0.9)
├── dateformat@1.0.12 (get-stdin@4.0.1, meow@3.7.0)
├── grunt-legacy-util@1.0.0 (getobject@0.1.0, async@1.5.2, hooker@0.2.3,
which@1.2.12, underscore.string@3.2.3, lodash@4.3.0)
└── grunt-legacy-log@1.0.0 (hooker@0.2.3, colors@1.1.2,
underscore.string@3.2.3, lodash@3.10.1, grunt-legacy-log-utils@1.0.0)
A valid Gruntfile could not be found. Please see the getting started guide
for
more information on how to configure grunt: http://gruntjs.com/getting-
started
Fatal error: Unable to find Gruntfile.
I looked at the travis job you had shared. Comparing the commits on it, it
looks like the master is based on 1.8. I am trying to make 1.7 build and
test.
Do you think it is worthwhile to make the build.sh of 1.7 similar to the
one in 1.8? I see there are a lot of fundamental differences, and if we are
to back port those over, I am not sure if there are going to be other
issues.
Can you give some pointers on the same?
-Suraj Acharya
On Tue, Feb 28, 2017 at 2:29 AM, Ryan Blue <rb...@netflix.com.invalid>
wrote:
> Suraj,
>
> I separated out a few implementations into separate repositories, set
> up Travis CI, and fixed a few tests in different implementations. It
> looks like the one for JS has tests passing in Node JS 4 and 5, but
> broken in 6: https://travis-ci.org/rdblue/avro-js/builds/187343704
>
> You may be running with Node JS 6?
>
> rb
>
> On Mon, Feb 27, 2017 at 4:29 AM, suraj acharya <su...@gmail.com>
> wrote:
> > I was attempting to make a release for 1.7.X.
> > In the process I am running into failing JS tests.
> > I was wondering if someone who worked on JS for AVRO can take a look at
> the
> > issue.
> > If there are no takers for the same, does anyone have objection if for
> > Branch-1.7 the JS component is removed? The builds on Branch-1.8 and
> higher
> > are working fine. There have been changes to the way the npm setup
> happens
> > in Branch-1.8.
> >
> > Any help is appreciated.
> >
> > -Suraj Acharya
>
>
>
> --
> Ryan Blue
> Software Engineer
> Netflix
>
Re: JavaScript failing on Branch-1.7
Posted by Ryan Blue <rb...@netflix.com.INVALID>.
Suraj,
I separated out a few implementations into separate repositories, set
up Travis CI, and fixed a few tests in different implementations. It
looks like the one for JS has tests passing in Node JS 4 and 5, but
broken in 6: https://travis-ci.org/rdblue/avro-js/builds/187343704
You may be running with Node JS 6?
rb
On Mon, Feb 27, 2017 at 4:29 AM, suraj acharya <su...@gmail.com> wrote:
> I was attempting to make a release for 1.7.X.
> In the process I am running into failing JS tests.
> I was wondering if someone who worked on JS for AVRO can take a look at the
> issue.
> If there are no takers for the same, does anyone have objection if for
> Branch-1.7 the JS component is removed? The builds on Branch-1.8 and higher
> are working fine. There have been changes to the way the npm setup happens
> in Branch-1.8.
>
> Any help is appreciated.
>
> -Suraj Acharya
--
Ryan Blue
Software Engineer
Netflix