You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@jclouds.apache.org by Simone Locci <no...@github.com> on 2018/10/16 19:38:27 UTC
[jclouds/jclouds] JCLOUDS-1460: Add support for aws ec2 t3 instance
types (#1244)
You can view, comment on, or merge this pull request online at:
https://github.com/jclouds/jclouds/pull/1244
-- Commit Summary --
* Add support for aws ec2 t3 instance types
-- File Changes --
M apis/ec2/src/main/java/org/jclouds/ec2/compute/domain/EC2HardwareBuilder.java (69)
M apis/ec2/src/main/java/org/jclouds/ec2/domain/InstanceType.java (77)
M providers/aws-ec2/src/main/java/org/jclouds/aws/ec2/compute/suppliers/AWSEC2HardwareSupplier.java (14)
-- Patch Links --
https://github.com/jclouds/jclouds/pull/1244.patch
https://github.com/jclouds/jclouds/pull/1244.diff
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1244
Re: [jclouds/jclouds] JCLOUDS-1460: Add support for aws ec2 t3
instance types (#1244)
Posted by Trent Schmidt <no...@github.com>.
trentontrees commented on this pull request.
> @@ -429,6 +435,69 @@ public static EC2HardwareBuilder t2_large() {
.processors(ImmutableList.of(new Processor(1.0, 0.4))).rootDeviceType(RootDeviceType.EBS);
}
+ /**
+ * @see InstanceType#T3_NANO
+ */
+ public static EC2HardwareBuilder t3_nano() {
+ return new EC2HardwareBuilder(InstanceType.T3_NANO).t1()
+ .ram(512)
+ .processors(ImmutableList.of(new Processor(2.0, 1.0)));
AWS Instance Type reference page:
https://aws.amazon.com/ec2/instance-types/
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1244#discussion_r225708253
Re: [jclouds/jclouds] JCLOUDS-1460: Add support for aws ec2 t3
instance types (#1244)
Posted by Simone Locci <no...@github.com>.
pimuzzo commented on this pull request.
> @@ -429,6 +435,69 @@ public static EC2HardwareBuilder t2_large() {
.processors(ImmutableList.of(new Processor(1.0, 0.4))).rootDeviceType(RootDeviceType.EBS);
}
+ /**
+ * @see InstanceType#T3_NANO
+ */
+ public static EC2HardwareBuilder t3_nano() {
+ return new EC2HardwareBuilder(InstanceType.T3_NANO).t1()
+ .ram(512)
+ .processors(ImmutableList.of(new Processor(2.0, 1.0)));
Where can I found the correct speed?
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1244#pullrequestreview-165337209
Re: [jclouds/jclouds] JCLOUDS-1460: Add support for aws ec2 t3
instance types (#1244)
Posted by Simone Locci <no...@github.com>.
@pimuzzo pushed 1 commit.
9a3c172 Add CPU speed
--
You are receiving this because you are subscribed to this thread.
View it on GitHub:
https://github.com/jclouds/jclouds/pull/1244/files/31c2831cb6db734a355f70aa2b191f6452f9a383..9a3c172b1b2ffbfab7d1c5290077b0f8b065b432
Re: [jclouds/jclouds] JCLOUDS-1460: Add support for aws ec2 t3
instance types (#1244)
Posted by Trent Schmidt <no...@github.com>.
We did our work separately. The code in PR #1245 is slightly different than this. I do think that #1245 supersedes this, but that PR is current blocked because of a build error. The `t3()` method in this PR is slightly different as well.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1244#issuecomment-430419371
Re: [jclouds/jclouds] JCLOUDS-1460: Add support for aws ec2 t3
instance types (#1244)
Posted by Simone Locci <no...@github.com>.
Closed #1244.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1244#event-1909339275
Re: [jclouds/jclouds] JCLOUDS-1460: Add support for aws ec2 t3
instance types (#1244)
Posted by Simone Locci <no...@github.com>.
I think too that the @trentontrees 's PR supersedes this one :peace_symbol:
@andreaturli you can close this one, there will be other opportunities to collaborate
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1244#issuecomment-430599803
Re: [jclouds/jclouds] JCLOUDS-1460: Add support for aws ec2 t3
instance types (#1244)
Posted by Andrea Turli <no...@github.com>.
thanks @pimuzzo for the clarification
Feel free to close this yourself, and maybe help with the review of #1245, as you are waiting for (some) same features contained there!
Thanks!
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1244#issuecomment-430600791
Re: [jclouds/jclouds] JCLOUDS-1460: Add support for aws ec2 t3
instance types (#1244)
Posted by Andrea Turli <no...@github.com>.
I'm confused guys, does #1245 supersede this one?
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1244#issuecomment-430414297