You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@spark.apache.org by li...@apache.org on 2017/09/08 16:39:26 UTC
spark git commit: [SPARK-21946][TEST] fix flaky test: "alter table:
rename cached table" in InMemoryCatalogedDDLSuite
Repository: spark
Updated Branches:
refs/heads/master 0dfc1ec59 -> 8a4f228dc
[SPARK-21946][TEST] fix flaky test: "alter table: rename cached table" in InMemoryCatalogedDDLSuite
## What changes were proposed in this pull request?
This PR fixes flaky test `InMemoryCatalogedDDLSuite "alter table: rename cached table"`.
Since this test validates distributed DataFrame, the result should be checked by using `checkAnswer`. The original version used `df.collect().Seq` method that does not guaranty an order of each element of the result.
## How was this patch tested?
Use existing test case
Author: Kazuaki Ishizaki <is...@jp.ibm.com>
Closes #19159 from kiszk/SPARK-21946.
Project: http://git-wip-us.apache.org/repos/asf/spark/repo
Commit: http://git-wip-us.apache.org/repos/asf/spark/commit/8a4f228d
Tree: http://git-wip-us.apache.org/repos/asf/spark/tree/8a4f228d
Diff: http://git-wip-us.apache.org/repos/asf/spark/diff/8a4f228d
Branch: refs/heads/master
Commit: 8a4f228dc0afed7992695486ecab6bc522f1e392
Parents: 0dfc1ec
Author: Kazuaki Ishizaki <is...@jp.ibm.com>
Authored: Fri Sep 8 09:39:20 2017 -0700
Committer: gatorsmile <ga...@gmail.com>
Committed: Fri Sep 8 09:39:20 2017 -0700
----------------------------------------------------------------------
.../scala/org/apache/spark/sql/execution/command/DDLSuite.scala | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/spark/blob/8a4f228d/sql/core/src/test/scala/org/apache/spark/sql/execution/command/DDLSuite.scala
----------------------------------------------------------------------
diff --git a/sql/core/src/test/scala/org/apache/spark/sql/execution/command/DDLSuite.scala b/sql/core/src/test/scala/org/apache/spark/sql/execution/command/DDLSuite.scala
index ad6fc20..d19cfee 100644
--- a/sql/core/src/test/scala/org/apache/spark/sql/execution/command/DDLSuite.scala
+++ b/sql/core/src/test/scala/org/apache/spark/sql/execution/command/DDLSuite.scala
@@ -783,7 +783,7 @@ abstract class DDLSuite extends QueryTest with SQLTestUtils {
val df = (1 to 2).map { i => (i, i.toString) }.toDF("age", "name")
df.write.insertInto("students")
spark.catalog.cacheTable("students")
- assume(spark.table("students").collect().toSeq == df.collect().toSeq, "bad test: wrong data")
+ checkAnswer(spark.table("students"), df)
assume(spark.catalog.isCached("students"), "bad test: table was not cached in the first place")
sql("ALTER TABLE students RENAME TO teachers")
sql("CREATE TABLE students (age INT, name STRING) USING parquet")
@@ -792,7 +792,7 @@ abstract class DDLSuite extends QueryTest with SQLTestUtils {
assert(!spark.catalog.isCached("students"))
assert(spark.catalog.isCached("teachers"))
assert(spark.table("students").collect().isEmpty)
- assert(spark.table("teachers").collect().toSeq == df.collect().toSeq)
+ checkAnswer(spark.table("teachers"), df)
}
test("rename temporary table - destination table with database name") {
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@spark.apache.org
For additional commands, e-mail: commits-help@spark.apache.org