[jira] [Work logged] (BEAM-4375) Gradle doesn't run tests under RunWith(Enclosed.class)

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/BEAM-4375?focusedWorklogId=104212&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-104212 ]

ASF GitHub Bot logged work on BEAM-4375:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 21/May/18 19:58
            Start Date: 21/May/18 19:58
    Worklog Time Spent: 10m 
      Work Description: jkff opened a new pull request #5440: [BEAM-4375] Replaces usage of JUnit runners that do not work well with Gradle
URL: https://github.com/apache/beam/pull/5440
 
 
   RunWith(Enclosed.class) causes tests to be skipped https://github.com/gradle/gradle/issues/2985 (in this PR I also fixed MetricsTests which was actually failing).
   RunWith(Suite.class) causes them to be duplicated https://github.com/gradle/gradle/issues/5484 .
   
   R: @swegner 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

            Worklog Id:     (was: 104212)
            Time Spent: 10m
    Remaining Estimate: 0h

> Gradle doesn't run tests under RunWith(Enclosed.class)
> ------------------------------------------------------
>
>                 Key: BEAM-4375
>                 URL: https://issues.apache.org/jira/browse/BEAM-4375
>             Project: Beam
>          Issue Type: Bug
>          Components: build-system
>            Reporter: Eugene Kirpichov
>            Assignee: Scott Wegner
>            Priority: Blocker
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> If you run ./gradlew :beam-runners-direct-java:needsRunnerTests, and look at the produced test report, one can see that it is missing tests that have RunWith(Enclosed.class), e.g. ParDoTest, CombineTest, MetricsTest etc.
>  
> This is very very bad - some of these tests are already known to be (silently) broken.
>  
> Likely [https://github.com/gradle/gradle/issues/2985] . As an emergency measure, let's convert to top-level classes.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)