You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2021/02/17 04:28:16 UTC
[GitHub] [incubator-dolphinscheduler] AlleriaWindrunner commented on pull request #4747: [Fix-4137][Server]:TaskPriorityQueueConsumer no need to sleep for one second.
AlleriaWindrunner commented on pull request #4747:
URL: https://github.com/apache/incubator-dolphinscheduler/pull/4747#issuecomment-780289220
ok, i have analyzed three situations about this section code, and read the discussion in #4137.Considering that this is an internal scheduling system, I think you and GitFireMan's code are both fine. But I have a few suggestions for other users:
1. The default implementation is a generic version.
2. If you consider performance you can increase the worker node without having to optimize the code.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org