[GitHub] [incubator-druid] surekhasaharan commented on a change in pull request #7595: Optimize overshadowed segments computation

[GitBox <gi...@apache.org>]

surekhasaharan commented on a change in pull request #7595: Optimize overshadowed segments computation
URL: https://github.com/apache/incubator-druid/pull/7595#discussion_r282280885
 
 

 ##########
 File path: server/src/main/java/org/apache/druid/metadata/SQLMetadataSegmentManager.java
 ##########
 @@ -744,6 +757,32 @@ public DataSegment map(int index, ResultSet r, StatementContext ctx) throws SQLE
 
     // Replace "dataSources" atomically.
     dataSources = newDataSources;
+    overshadowedSegments = ImmutableSet.copyOf(determineOvershadowedSegments(segments));
+  }
+
+  /**
+   * This method builds a timeline from given segments and finds the overshadowed segments
+   *
+   * @return set of overshadowed segments
+   */
+  private Set<DataSegment> determineOvershadowedSegments(Iterable<DataSegment> segments)
 
 Review comment:
   changed to list

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org